[DOCS] Configuring the Ceph client

Bug #2047783 reported by Sean Schoonover
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Dmitriy Rabotyagov

Bug Description

In the ceph_clinet documentation section "Configure os_gnocchi with ceph_client" (https://opendev.org/openstack/openstack-ansible-ceph_client/src/branch/master/doc/source/configure-ceph.rst#configure-os_gnocchi-with-ceph_client) it provides this example:

```
ceph_extra_components:
  - component: gnocchi_api
    package: "{{ python_ceph_packages }}"
    client:
      - '{{ gnocchi_ceph_client }}'
    service: '{{ ceph_gnocchi_service_names }}'
```

This example will fail to place the ceph keyring file in the Gnocchi container because of a missing "name" variable under "client:".

https://opendev.org/openstack/openstack-ansible-ceph_client/commit/fdd2aaa00b appears to be where this behavior is changed.

The correct example should be:

```
ceph_extra_components:
  - component: gnocchi_api
    package: "{{ python_ceph_packages }}"
    client:
      - name: '{{ gnocchi_ceph_client }}'
    service: '{{ ceph_gnocchi_service_names }}'
```

Revision history for this message
Sean Schoonover (seansch) wrote :
Changed in openstack-ansible:
status: New → Confirmed
assignee: nobody → Dmitriy Rabotyagov (noonedeadpunk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-ceph_client (master)
Changed in openstack-ansible:
status: Confirmed → In Progress
Revision history for this message
Dmitriy Rabotyagov (noonedeadpunk) wrote :

Hi,

Thanks for reporting that.

It would be really nice if you could test out if old format of ceph_extra_components works with the patch above ^

Revision history for this message
Sean Schoonover (seansch) wrote :

Patch looks good, I tested both the old and new format, both succeeded without any errors. Thanks!

Revision history for this message
Dmitriy Rabotyagov (noonedeadpunk) wrote :

Great, thanks for taking time testing the patch!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-ceph_client (master)

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-ceph_client/+/904499
Committed: https://opendev.org/openstack/openstack-ansible-ceph_client/commit/6bb5f7dcdbeb60fc9c3fb50437f4766cc61b954c
Submitter: "Zuul (22348)"
Branch: master

commit 6bb5f7dcdbeb60fc9c3fb50437f4766cc61b954c
Author: Dmitriy Rabotyagov <email address hidden>
Date: Tue Jan 2 16:55:03 2024 +0100

    Add backwards compatibility of ceph_components format

    With [1] we have broken compatibility of potentially provided extra components
    config without any notice.

    In order to handle this now we fix backwards compatibility along with
    adding a deprecation note on the format of ``client``.

    [1] https://review.opendev.org/c/openstack/openstack-ansible-ceph_client/+/882827

    Closes-Bug: #2047783
    Change-Id: I89b67f0f0545d799194d8486a6bb25227279af84

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-ceph_client (stable/2023.2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-ceph_client (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-ceph_client/+/904849
Committed: https://opendev.org/openstack/openstack-ansible-ceph_client/commit/563c3b600a239f28792860beb4b0b6da0046b54d
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 563c3b600a239f28792860beb4b0b6da0046b54d
Author: Dmitriy Rabotyagov <email address hidden>
Date: Tue Jan 2 16:55:03 2024 +0100

    Add backwards compatibility of ceph_components format

    With [1] we have broken compatibility of potentially provided extra components
    config without any notice.

    In order to handle this now we fix backwards compatibility along with
    adding a deprecation note on the format of ``client``.

    [1] https://review.opendev.org/c/openstack/openstack-ansible-ceph_client/+/882827

    Closes-Bug: #2047783
    Change-Id: I89b67f0f0545d799194d8486a6bb25227279af84
    (cherry picked from commit 6bb5f7dcdbeb60fc9c3fb50437f4766cc61b954c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-ceph_client (stable/2023.1)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-ceph_client (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-ceph_client/+/917000
Committed: https://opendev.org/openstack/openstack-ansible-ceph_client/commit/e694b9141b16d5351048050419e895314d63f1b8
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit e694b9141b16d5351048050419e895314d63f1b8
Author: Dmitriy Rabotyagov <email address hidden>
Date: Tue Jan 2 16:55:03 2024 +0100

    Add backwards compatibility of ceph_components format

    With [1] we have broken compatibility of potentially provided extra components
    config without any notice.

    In order to handle this now we fix backwards compatibility along with
    adding a deprecation note on the format of ``client``.

    [1] https://review.opendev.org/c/openstack/openstack-ansible-ceph_client/+/882827

    Closes-Bug: #2047783
    Change-Id: I89b67f0f0545d799194d8486a6bb25227279af84
    (cherry picked from commit 6bb5f7dcdbeb60fc9c3fb50437f4766cc61b954c)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.