haproxy health probes do not work

[Alex Alexandrov]

Since https://review.opendev.org/c/openstack/openstack-ansible/+/887285
option httpchk is replaced with http-check. However, latter is ignored by haproxy if option httpchk is not specified in config, so health probes just won't work.
I think it should be added either in haproxy service template, or in group vars.

[Dmitriy Rabotyagov (noonedeadpunk)]

Ok, yes, as a result of absent `option httpchk` in backend configuration, we end up with "Layer4 check passed" instead of intended "Layer7 check passed".

If service is down it still should be reflected in haproxy as then L4 will fail as well, but it's valid bug that should be fixed asap.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/903463

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/903488
Committed: https://opendev.org/openstack/openstack-ansible/commit/6a276938e75137255478aab014f8765c7405cc50
Submitter: "Zuul (22348)"
Branch: master

commit 6a276938e75137255478aab014f8765c7405cc50
Author: Dmitriy Rabotyagov <email address hidden>
Date: Tue Dec 12 12:19:48 2023 +0100

    Fix http-check ordering for services

    Despite not being documented, order of http-check options are important

    Defining `expect` before `check` leads to configuration error. In order to
    avoid that we fix some defenitions of haproxy_services variable.

    Related-Bug: #2046223

    Needed-By: https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/903463
    Change-Id: I6153e1ba5a4c45e2ed78d69da73e6524e3911db0

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/903463
Committed: https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/16ab20815f449703a94923a8613bf3577bef2833
Submitter: "Zuul (22348)"
Branch: master

commit 16ab20815f449703a94923a8613bf3577bef2833
Author: Dmitriy Rabotyagov <email address hidden>
Date: Tue Dec 12 10:51:07 2023 +0100

    Add httpchk option when httpcheck_options are defined

    In order for http-check to work, option httpchk must be loaded first. Otherwise
    regular L4 check will be issued and all `http-check` will be simply ignored.

    Closes-Bug: #2046223
    Depends-On: https://review.opendev.org/c/openstack/openstack-ansible/+/903488
    Change-Id: Ie9ed322ab9c4a04d42cab4456567ac5d1f5c966b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/903544

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/903545

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/903545
Committed: https://opendev.org/openstack/openstack-ansible/commit/8bcd9198ff00363363fa3335e25c9fb6ece41847
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 8bcd9198ff00363363fa3335e25c9fb6ece41847
Author: Dmitriy Rabotyagov <email address hidden>
Date: Tue Dec 12 12:19:48 2023 +0100

    Fix http-check ordering for services

    Despite not being documented, order of http-check options are important

    Defining `expect` before `check` leads to configuration error. In order to
    avoid that we fix some defenitions of haproxy_services variable.

    Related-Bug: #2046223

    Needed-By: https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/903544
    Change-Id: I6153e1ba5a4c45e2ed78d69da73e6524e3911db0
    (cherry picked from commit 6a276938e75137255478aab014f8765c7405cc50)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-haproxy_server/+/903544
Committed: https://opendev.org/openstack/openstack-ansible-haproxy_server/commit/baf11a22fbf66ccd1cc95d60c3ea0c60a051decb
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit baf11a22fbf66ccd1cc95d60c3ea0c60a051decb
Author: Dmitriy Rabotyagov <email address hidden>
Date: Tue Dec 12 10:51:07 2023 +0100

    Add httpchk option when httpcheck_options are defined

    In order for http-check to work, option httpchk must be loaded first. Otherwise
    regular L4 check will be issued and all `http-check` will be simply ignored.

    Closes-Bug: #2046223
    Depends-On: https://review.opendev.org/c/openstack/openstack-ansible/+/903545
    Depends-On: https://review.opendev.org/c/openstack/openstack-ansible/+/904303
    Change-Id: Ie9ed322ab9c4a04d42cab4456567ac5d1f5c966b
    (cherry picked from commit 16ab20815f449703a94923a8613bf3577bef2833)