neutron_vpnaas_custom_config is copied to old etc folder on service upgrade

[Dmitriy Rabotyagov]

When performing openstack upgrade, neutron_vpnaas_custom_config is copied to /etc/neutron, that is a symlink to the old venv, since the venv is being re-link during handlers.

So there is a race condition, when config files are copied to the wrong environment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/897431

[Dmitriy Rabotyagov (noonedeadpunk)]

Eventually, it's not code bug but documentation issue. Since it's up to a deployer to define destination directories for vpnaas files.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-os_neutron/+/897431
Committed: https://opendev.org/openstack/openstack-ansible-os_neutron/commit/208ae99e2e3d385208922af53205b1fc2f93922e
Submitter: "Zuul (22348)"
Branch: master

commit 208ae99e2e3d385208922af53205b1fc2f93922e
Author: Dmitriy Rabotyagov <email address hidden>
Date: Thu Oct 5 15:34:39 2023 +0200

    [doc] Update example on how to define neutron_vpnaas_custom_config

    Closes-Bug: #2037649
    Change-Id: I55b11e225286f81ec83f287e713e79d7bb847d77