bootstrap-ansible script fails at sed CURRENT_OSA_VERSION

[George Shuklin]

Something broken after last Friday (18.11.2022). boostrap-ansible.sh worked, now it's fails at following:

+ sed -i 's|OSA_ANSIBLE_FORKS|10|g' /usr/local/bin/openstack-ansible.rc
+ cp -v scripts/openstack-ansible.sh /usr/local/bin/openstack-ansible
'scripts/openstack-ansible.sh' -> '/usr/local/bin/openstack-ansible'
+ sed -i 's|OSA_CLONE_DIR|/opt/openstack-ansible|g' /usr/local/bin/openstack-ansible
+ sed -i 's|CURRENT_OSA_VERSION|[pbr] Generating ChangeLog
25.2.0|g' /usr/local/bin/openstack-ansible
sed: -e expression #1, char 48: unterminated `s' command
++ exit_fail 375 0
++ set +x

I believe this happens because setup.py reports version with additional string:

/opt/ansible-runtime/bin/python setup.py --version 2>/dev/null
[pbr] Generating ChangeLog
25.2.0

The line `[pbr] Generating ChangeLog` does not look like a proper CURRENT_OSA_VERSION for me.

Versions checked:

25.0.0
25.2.0

Host OS: Debian 11.5

[George Shuklin (george-shuklin)]

Update: there is no problem on Ubuntu 20.04, setup.py --version report only version without string '[pbr] Generating ChangeLog'.

[George Shuklin (george-shuklin)]

I have suspicion that the problem is around python 3.9. There is a new release of setuptools, version 65.6.0 (released 19.11.2022), which subtly changed output behavior for setup.py execution.

[Dmitriy Rabotyagov (noonedeadpunk)]

Oh, you're right about setuptools. We used to fix setuptools version in prior releases, but dropped that since setuptools appeared in upper-constraints.
And I think we totally missed that in Yoga and Zed it's dropped out of u-c, or well, it's constrained only for specific python versions:
https://opendev.org/openstack/requirements/src/branch/stable/yoga/upper-constraints.txt#L643-L644

Quite easy to fix though, despite it's a bit annoying thing.

[George Shuklin (george-shuklin)]

I suspect that it was aggravated because there is no constrains for python3.9 (which is the default python for Debian Bullseye), and a very new version of setuptools is installed. Ubuntu is not affected, because there is python3.8 and there is constrain on setuptools version for it for python3.9.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/865297

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/865160

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/865312

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/865166

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Dmitriy Rabotyagov <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/865297

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Dmitriy Rabotyagov <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/865160

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/865312
Committed: https://opendev.org/openstack/openstack-ansible/commit/7eebc69e8a5a2a6346f68b11bd9f6b6109e10fd9
Submitter: "Zuul (22348)"
Branch: master

commit 7eebc69e8a5a2a6346f68b11bd9f6b6109e10fd9
Author: Dmitriy Rabotyagov <email address hidden>
Date: Tue Nov 22 18:10:01 2022 +0100

    Update self version fetching mechanism

    With release of new setuptools running setup.py --version started
    returining extra line. Eventually, running setup.py as a script is not
    considered as good practice and we should not rely on it's output much.
    Instead, we can leverage importlib.metadata as it should be more
    reliable in long run.

    Closes-Bug: #1997365
    Change-Id: Ife227db4ad25851456e1acc6b4daf198f39d989a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/865166
Committed: https://opendev.org/openstack/openstack-ansible/commit/f933194813de9d18b89040fa8c5b80bcd0dd967c
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit f933194813de9d18b89040fa8c5b80bcd0dd967c
Author: Dmitriy Rabotyagov <email address hidden>
Date: Tue Nov 22 18:10:01 2022 +0100

    Update self version fetching mechanism

    With release of new setuptools running setup.py --version started
    returining extra line. Eventually, running setup.py as a script is not
    considered as good practice and we should not rely on it's output much.
    Instead, we can leverage importlib.metadata as it should be more
    reliable in long run.

    Closes-Bug: #1997365
    Change-Id: Ife227db4ad25851456e1acc6b4daf198f39d989a

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 26.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 25.3.0 release.