Masakari install failure stable/xena

[Davide De Pasquale]

Dear all,

after a complete and successfully installed "stable/xena" with just the minimum services for operating some experiments (just nova, neutron, ceph, ceilometer, aodh, keystone, cinder, glance, heat, horizon) I have decided to upgrade the installation including some new services, such as masakari, barbican, octavia, mistral, zun.
Just because I am still in a pre-production environment, I have executed successfully
openstack-ansible setup-hosts.yml
openstack-ansible setup-infrastructure-yml

but when I execute openstack-ansible setup-openstack.yml, I received an error at os-masakari-install.yml that is strange for me.

Here the ansible error log:

PLAY [Gather masakari facts] *********************************************************************************************************************

TASK [Gather additional facts] *******************************************************************************************************************
included: /opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml for infra1_masakari_api_container-14a49e3e, infra2_masakari_api_container-66726060, infra3_masakari_api_container-11d3fa81, infra1, infra2, infra3, compute1, compute2, compute3, compute4

TASK [Gather additional facts] *******************************************************************************************************************
fatal: [infra1_masakari_api_container-14a49e3e]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: 'pacemaker_corosync_ring_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [infra2_masakari_api_container-66726060]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: 'pacemaker_corosync_ring_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [infra3_masakari_api_container-11d3fa81]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: 'pacemaker_corosync_ring_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [infra1]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: 'pacemaker_corosync_ring_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [infra2]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: 'pacemaker_corosync_ring_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [infra3]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: 'pacemaker_corosync_ring_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [compute1]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: 'pacemaker_corosync_ring_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [compute2]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: 'pacemaker_corosync_ring_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [compute3]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: 'pacemaker_corosync_ring_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [compute4]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: 'pacemaker_corosync_ring_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}

It seems an error in some configuration file regarding the definition of pacemaker_corosync_ring_interface.

Here my /etc/openstack_deploy/conf.d/masakari.yml file content
---
# The infra nodes that will be running the masakari services
masakari-infra_hosts:
  infra1:
    ip: 172.29.236.11
  infra2:
    ip: 172.29.236.12
  infra3:
    ip: 172.29.236.13

# The infra nodes that will be running the masakari monitors
masakari-monitor_hosts:
  compute1:
    ip: 172.29.236.31
  compute2:
    ip: 172.29.236.32
  compute3:
    ip: 172.29.236.33
  compute4:
    ip: 172.29.236.34

I have tested also with both infra and monitor hosts set to infras nodes. Same issue.
Do you have a workaround for this? Can you confirm the potential error? Any quick solution would be appreciated.

Thanks in advance
Davide

[Dmitriy Rabotyagov (noonedeadpunk)]

Hi Davide,

I believe we already merged and backported fix for the mentioned bug.

Please kindly check following commit and let us know of it solves your issue:
https://opendev.org/openstack/openstack-ansible/commit/41547fc5bd4841a7584105b271733fdc990541e5

It hasn't been released (tagged) yet as landed really recently, so it's present only on stable/xena.

Awaiting for your reply/confirmation.

[Davide De Pasquale (davidedepasquale)]

Dear Dmitriy,

thanks for the quick answer.
With the proposed change in /opt/openstack-ansible/playbooks/os-masakari-install.yml i have the following.

PLAY [Gather masakari facts] *********************************************************************************************************************

TASK [Gather additional facts] *******************************************************************************************************************
included: /opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml for infra1_masakari_api_container-14a49e3e, infra2_masakari_api_container-66726060, infra3_masakari_api_container-11d3fa81, infra1, infra2, infra3, compute1, compute2, compute3, compute4

TASK [Gather additional facts] *******************************************************************************************************************
fatal: [infra1_masakari_api_container-14a49e3e]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: {{ masakari_monitor_corosync_multicast_interface }}: 'masakari_monitor_corosync_multicast_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [infra2_masakari_api_container-66726060]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: {{ masakari_monitor_corosync_multicast_interface }}: 'masakari_monitor_corosync_multicast_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
fatal: [infra3_masakari_api_container-11d3fa81]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}: {{ masakari_monitor_corosync_multicast_interface }}: 'masakari_monitor_corosync_multicast_interface' is undefined\n\nThe error appears to be in '/opt/openstack-ansible/playbooks/common-tasks/gather-hardware-facts.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Gather additional facts\n ^ here\n"}
ok: [compute1]
ok: [infra1]
ok: [infra2]
ok: [infra3]
ok: [compute2]
ok: [compute3]
ok: [compute4]

PLAY [Setup corosync cluster]
......

the complete playbook completes but obviously with error. 1 error for each infra masakari container:

PLAY RECAP ***************************************************************************************************************************************
compute1 : ok=47 changed=28 unreachable=0 failed=0 skipped=18 rescued=0 ignored...

[Davide De Pasquale (davidedepasquale)]

I confirm the service is not working. No endpoints are listed after the playbook completion with
openstack endpoint list

I will keep waiting for any further detail.
ciao

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/846580

[Dmitriy Rabotyagov (noonedeadpunk)]

Yes, you're right, merged and suggested fix doesn't really fix issue outside of CI as indeed we had masakari_monitor_corosync_multicast_interface defined only for monitor_hosts rather then for masakari_all.

I have proposed fix that basically reverts playbook state to pre-xena version. Would be great if you could test it and review the change.

[Davide De Pasquale (davidedepasquale)]

I confirm the following playbook works without problem. Masakari is installed.
I have just modified (for other people reading this post) the following file /opt/openstack-ansible/playbooks/os-masakari-install.yml

---
# Copyright 2014, Rackspace US, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

- name: Setup corosync cluster
  hosts: masakari_monitor
  gather_facts: false
  serial: "{{ masakari_monitor_serial | default('100%') }}"
  user: root
  vars:
    pacemaker_corosync_group: masakari_monitor
    pacemaker_corosync_ring_interface: "{{ masakari_monitor_corosync_multicast_interface }}"
    haveged_enabled: false
  pre_tasks:
    - name: Gather additional facts
      include_tasks: "common-tasks/gather-hardware-facts.yml"
      vars:
        deployment_extra_facts_filter: "{{ 'ansible_' ~ pacemaker_corosync_ring_interface | replace('-','_') }}"
        deployment_extra_facts_subset: "!all,network"
      args:
        apply:
          tags:
            - always
      tags:
        - always
  roles:
    - role: "pacemaker_corosync"
      tags: pacemaker-corosync

- name: Install the masakari components
  hosts: masakari_all
  gather_facts: false
  serial: "{{ masakari_api_serial | default(['1','100%']) }}"
  user: root
  vars_files:
    - "defaults/repo_packages/openstack_services.yml"
    - "defaults/{{ install_method }}_install.yml"
  pre_tasks:
    - name: Gather additional facts
      include_tasks: "common-tasks/gather-hardware-facts.yml"
      args:
        apply:
          tags:
            - always
      tags:
        - always

    # In order to ensure that any container, software or
    # config file changes which causes a container/service
    # restart do not cause an unexpected outage, we drain
    # the load balancer back end for this container.
    - include_tasks: common-tasks/haproxy-endpoint-manage.yml
      vars:
        haproxy_backend: masakari_api-back
        haproxy_state: disabled
      when:
        - "'masakari_api' in group_names"
        - "groups['masakari_api'] | length > 1"

    - include_tasks: "common-tasks/os-{{ container_tech | default('lxc') }}-container-setup.yml"
      when: not is_metal

    - include_tasks: common-tasks/unbound-clients.yml
      when:
        - hostvars['localhost']['resolvconf_enabled'] | bool

  roles:
    - role: "os_masakari"

  post_tasks:
    # Now that container changes are done, we can set
    # the load balancer back end for this container
    # to available again.
    - include_tasks: common-tasks/haproxy-endpoint-manage.yml
      vars:
        haproxy_backend: masakari_api-back
        haproxy_state: enabled
      when:
        - "'masakari_api' in group_names"
        - "groups[...

[Davide De Pasquale (davidedepasquale)]

Just a quick update (if useful).
If I kill the QEMU process on the compute machine, the VM is re-initialized automatically.
If I shutdown the compute host nothing happen (neither a notification): the instance remain in "active" status but obviously it is not working (console, log...).

I will double check the use of masakari (if I find a clear user guide), but please if you think is an error on my side with the configurations above, any suggestion is very welcome.
Regards,
Davide

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/847260

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/846580
Committed: https://opendev.org/openstack/openstack-ansible/commit/8bc9b167ab9a4854aab5d49a10709c27e96ff833
Submitter: "Zuul (22348)"
Branch: master

commit 8bc9b167ab9a4854aab5d49a10709c27e96ff833
Author: Dmitriy Rabotyagov <email address hidden>
Date: Mon Jun 20 10:24:18 2022 +0200

    Return facts gathering to pre_tasks for masakari

    We don't have pacemaker_corosync_ring_interface defined outside of
    pacemaker_corosync_group and it won't be consistent across hosts.
    As it might include mix of containers/bare metal hosts, so interface
    name might be inconsistent.

    So let's not bring too much complexity for default option and just
    revert to old good working solution.

    This partially reverts change Ie996262043edb8fb9c7221a5cd98e98a0111ac28
    and I75bdab29353f33fa009bf9a7ff1f565f1660ed59

    Closes-Bug: #1979145
    Change-Id: I4099c66fd37813b6a4c6e5b8a312a12647969e71

[Dmitriy Rabotyagov (noonedeadpunk)]

So, how masakari-hostmonitor works. It listens on {{ masakari_monitor_corosync_multicast_interface }} on each compute for traffic send by corosync regarding cluster status.
When it sees that corosync detects another host as down, it will send a message to engine.

So first of all I would check that pacemaker cluster is healthy and see host being down. You can use 'crm_mon -1' for that.
Next you should ensure that hostnames in corosync cluster is exactly the same as added to masakari API.
And of course check the masakari-hostmonitor logs on other computes

There was another issue in masakari itself, but it should be fixed in Xena, and message would be produced anyway in case of hitting it, so I think it's not that. But issue was when compute name was not matching between "openstack hypervisor list" and " openstack compute service list"

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/847260
Committed: https://opendev.org/openstack/openstack-ansible/commit/345f0bea9ef73424213e73db7dae19a511db879d
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 345f0bea9ef73424213e73db7dae19a511db879d
Author: Dmitriy Rabotyagov <email address hidden>
Date: Mon Jun 20 10:24:18 2022 +0200

    Return facts gathering to pre_tasks for masakari

    We don't have pacemaker_corosync_ring_interface defined outside of
    pacemaker_corosync_group and it won't be consistent across hosts.
    As it might include mix of containers/bare metal hosts, so interface
    name might be inconsistent.

    So let's not bring too much complexity for default option and just
    revert to old good working solution.

    This partially reverts change Ie996262043edb8fb9c7221a5cd98e98a0111ac28
    and I75bdab29353f33fa009bf9a7ff1f565f1660ed59

    Closes-Bug: #1979145
    Change-Id: I4099c66fd37813b6a4c6e5b8a312a12647969e71

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/848006

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 25.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/848006
Committed: https://opendev.org/openstack/openstack-ansible/commit/d1f672340c1fa9170795106ee2502f210a8242ad
Submitter: "Zuul (22348)"
Branch: stable/xena

commit d1f672340c1fa9170795106ee2502f210a8242ad
Author: Dmitriy Rabotyagov <email address hidden>
Date: Mon Jun 20 10:24:18 2022 +0200

    Return facts gathering to pre_tasks for masakari

    We don't have pacemaker_corosync_ring_interface defined outside of
    pacemaker_corosync_group and it won't be consistent across hosts.
    As it might include mix of containers/bare metal hosts, so interface
    name might be inconsistent.

    So let's not bring too much complexity for default option and just
    revert to old good working solution.

    This partially reverts change Ie996262043edb8fb9c7221a5cd98e98a0111ac28
    and I75bdab29353f33fa009bf9a7ff1f565f1660ed59

    Closes-Bug: #1979145
    Depends-On: https://review.opendev.org/c/openstack/openstack-ansible-rabbitmq_server/+/850233
    Change-Id: I4099c66fd37813b6a4c6e5b8a312a12647969e71
    (cherry picked from commit 8bc9b167ab9a4854aab5d49a10709c27e96ff833)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 24.4.0 release.

[Davide De Pasquale (davidedepasquale)]

Ciao Dimitry,

I have updated to the latest version of stable/xena and re-executed
openstack-ansible os-masakari-install.yml

I receive the following error:

TASK [apt_package_pinning : Add apt pin preferences] ******************************************************************************************
fatal: [infra1_masakari_api_container-14a49e3e]: FAILED! => {"msg": "The conditional check 'ansible_facts['pkg_mgr'] == 'apt'' failed. The error was: error while evaluating conditional (ansible_facts['pkg_mgr'] == 'apt'): 'dict object' has no attribute 'pkg_mgr'\n\nThe error appears to be in '/etc/ansible/roles/apt_package_pinning/tasks/main.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Add apt pin preferences\n ^ here\n"}

do you think this is an error because I am trying to re-install the package?
Thanks for your kind help.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 26.0.0.0rc1 release candidate.

[Davide De Pasquale (davidedepasquale)]

Dear all,

let me notify that the error message I noticed on 2022-08-15 is present also in a fresh installation of openstack stable/zed on a new region I am deploying in these days (yes I am addicted to use Openstack in my cloud projects!)

TASK [apt_package_pinning : Add apt pin preferences] ******************************************************************************************
fatal: [infra1_masakari_api_container-14a49e3e]: FAILED! => {"msg": "The conditional check 'ansible_facts['pkg_mgr'] == 'apt'' failed. The error was: error while evaluating conditional (ansible_facts['pkg_mgr'] == 'apt'): 'dict object' has no attribute 'pkg_mgr'\n\nThe error appears to be in '/etc/ansible/roles/apt_package_pinning/tasks/main.yml': line 16, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Add apt pin preferences\n ^ here\n"}

It seems to me a problem in retreving facts about the pkg_mgr to use. The same statement and conditional check is performed several times in other ansible tasks during setup-openstack.yml

If I can be more useful for further testing simply answer me. I do not think this is a new bug but probably something already wrong in the last iteration on this thread.

Thanks in advance for any support.
Best regards,
Davide

[Dmitriy Rabotyagov (noonedeadpunk)]

Hi Davide,

Can you kindly provide slightly more output, to also include couple of previous tasks, so that we could see the context under which failed one was run.

Though looking at the code now, I think I see the issue you're hitting.

[Dmitriy Rabotyagov (noonedeadpunk)]

I think I have returned back this bug with the commit https://opendev.org/openstack/openstack-ansible/commit/8bc9b167ab9a4854aab5d49a10709c27e96ff833 :(

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/openstack-ansible-os_masakari/+/880360

[Dmitriy Rabotyagov (noonedeadpunk)]

It would be great if you could test in your environment if applying this patch (https://review.opendev.org/c/openstack/openstack-ansible-os_masakari/+/880360) is sufficient to cover the issue.

Please, remove /etc/openstack_deploy/ansible_facts/infra1_masakari_api_container-14a49e3e file to clean up cached facts in case any present.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/880459

[Davide De Pasquale (davidedepasquale)]

Ciao Dmitriy
it worked fine! I really thank you for the prompt reply!

Soon or later I will find time to start in actively contributing to OpenStack! I promise :)
Best regards,
Davide

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-os_masakari/+/880360
Committed: https://opendev.org/openstack/openstack-ansible-os_masakari/commit/7582a277616d834ff08dbbaf0f54b99b725c8d74
Submitter: "Zuul (22348)"
Branch: master

commit 7582a277616d834ff08dbbaf0f54b99b725c8d74
Author: Dmitriy Rabotyagov <email address hidden>
Date: Thu Apr 13 21:32:23 2023 +0200

    Drop apt_package_pinning from role requirements

    We don't pin packages in masakari role, so dependency on
    apt_package_pinning role can be safely removed.

    Change-Id: Ife81410d59e8a646aab741bc1a5ef01784bf13b0
    Related-Bug: #1979145

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/880459
Committed: https://opendev.org/openstack/openstack-ansible/commit/bb4f1c7b2a46b30de8bca3e695938022efe6be89
Submitter: "Zuul (22348)"
Branch: master

commit bb4f1c7b2a46b30de8bca3e695938022efe6be89
Author: Dmitriy Rabotyagov <email address hidden>
Date: Fri Apr 14 10:16:29 2023 +0200

    Gather generic masakari facts

    With commit [1] we moved extra facts gathering to pre_tasks
    but with that we did not enable generic facts gathering, which
    led to regression. So we cover this by ensuring that generic
    facts are also gathered and not only extra ones.

    [1] https://opendev.org/openstack/openstack-ansible/commit/8bc9b167ab9a4854aab5d49a10709c27e96ff833
    Closes-Bug: #1979145

    Change-Id: Ibb9dc3377a4de06af25281bf777b16faad16d261

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/880606

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/880607

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/880608

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/880608
Committed: https://opendev.org/openstack/openstack-ansible/commit/eb7f45fcdc7dd7118647efac43eeb7004a2c271b
Submitter: "Zuul (22348)"
Branch: stable/xena

commit eb7f45fcdc7dd7118647efac43eeb7004a2c271b
Author: Dmitriy Rabotyagov <email address hidden>
Date: Fri Apr 14 10:16:29 2023 +0200

    Gather generic masakari facts

    With commit [1] we moved extra facts gathering to pre_tasks
    but with that we did not enable generic facts gathering, which
    led to regression. So we cover this by ensuring that generic
    facts are also gathered and not only extra ones.

    [1] https://opendev.org/openstack/openstack-ansible/commit/8bc9b167ab9a4854aab5d49a10709c27e96ff833
    Closes-Bug: #1979145

    Change-Id: Ibb9dc3377a4de06af25281bf777b16faad16d261
    (cherry picked from commit bb4f1c7b2a46b30de8bca3e695938022efe6be89)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/880607
Committed: https://opendev.org/openstack/openstack-ansible/commit/75edbf3bea6e35abc70a45f29ca20a2dd8853f16
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 75edbf3bea6e35abc70a45f29ca20a2dd8853f16
Author: Dmitriy Rabotyagov <email address hidden>
Date: Fri Apr 14 10:16:29 2023 +0200

    Gather generic masakari facts

    With commit [1] we moved extra facts gathering to pre_tasks
    but with that we did not enable generic facts gathering, which
    led to regression. So we cover this by ensuring that generic
    facts are also gathered and not only extra ones.

    [1] https://opendev.org/openstack/openstack-ansible/commit/8bc9b167ab9a4854aab5d49a10709c27e96ff833
    Closes-Bug: #1979145

    Change-Id: Ibb9dc3377a4de06af25281bf777b16faad16d261
    (cherry picked from commit bb4f1c7b2a46b30de8bca3e695938022efe6be89)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/880606
Committed: https://opendev.org/openstack/openstack-ansible/commit/5a93aebaf5661f8e4d5a618b952a0bc95ea47b5b
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 5a93aebaf5661f8e4d5a618b952a0bc95ea47b5b
Author: Dmitriy Rabotyagov <email address hidden>
Date: Fri Apr 14 10:16:29 2023 +0200

    Gather generic masakari facts

    With commit [1] we moved extra facts gathering to pre_tasks
    but with that we did not enable generic facts gathering, which
    led to regression. So we cover this by ensuring that generic
    facts are also gathered and not only extra ones.

    [1] https://opendev.org/openstack/openstack-ansible/commit/8bc9b167ab9a4854aab5d49a10709c27e96ff833
    Closes-Bug: #1979145

    Change-Id: Ibb9dc3377a4de06af25281bf777b16faad16d261
    (cherry picked from commit bb4f1c7b2a46b30de8bca3e695938022efe6be89)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 25.3.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 26.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 24.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 27.0.0.0rc1 release candidate.