manila haproxy backend name mismatch

[Amine]

Hi

openstack ansible tag 22.3.1

when deploying manila, playbook failed on [set haproxy state] because haproxy backend is defined as "manilla-api-back" in os-manila.yml while it is named manila-back in haproxy.

correcting the mismatch solved the issue.

best

Amine

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/813885

[Amine (amine-bouabdallah)]

thanks.

the fix shouldn't also include the condition ?

when:
        - "'manila' in group_names"
        - "groups['manila'] | length > 1"
          # - "'manila_api' in group_names"
          # - "groups['manila_api'] | length > 1"

[Dmitriy Rabotyagov (noonedeadpunk)]

Hi,

No, it should not. Because you need to disable haproxy only when you run manila role against manila_api endpoints and don't disable api when you ran it against manila-share hosts for instance.

Group names are correct and manila_api group must exist according to https://opendev.org/openstack/openstack-ansible/src/branch/master/inventory/env.d/manila.yml#L16

[Amine (amine-bouabdallah)]

Hi.

noted.
still there is something there as when keeping the condition as is :

when:
  - "'manila_api' in group_names"
  - "groups['manila_api'] | length > 1"

the manila playbook fails at the same haproxy set state task. but when changed to

when:
  - "'manila' in group_names"
  - "groups['manila'] | length > 1"
it passes.

attached you can find a truncated error log for the first case.

[Dmitriy Rabotyagov (noonedeadpunk)]

Can you please attach log file with the error you see?

[Amine (amine-bouabdallah)]

sure...here it is

[Dmitriy Rabotyagov (noonedeadpunk)]

Ok, so I see here quite different issue. And I guess when you change condition, you don't see error because it's never satisfied.
I'm not quite sure what _exactly_ goes wrong there atm though. I will try to reproduce issue in sandbox and return back to you.

[Dmitriy Rabotyagov (noonedeadpunk)]

I tried to reproduce that, but I don't see any issue in my sandbox deployment but it works: https://paste.opendev.org/show/810077/

I did that on 22.3.1 with fix cherry-picked.

My guess why you have failure, is because you need to run haproxy-install.yml after defining group for manila in openstack_user_config or conf.d. Otherwise you won't have endpoints created which might be result of the failure.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/813885
Committed: https://opendev.org/openstack/openstack-ansible/commit/78d9a8596ad14e1caa483887545abb587c6c9fd9
Submitter: "Zuul (22348)"
Branch: master

commit 78d9a8596ad14e1caa483887545abb587c6c9fd9
Author: Dmitriy Rabotyagov <email address hidden>
Date: Wed Oct 13 22:02:03 2021 +0300

    Fix manila haproxy manage

    In manila playbook we incorrectly defined haproxy backend name.
    This wasn't catched by CI since we do single node deployment.

    Closes-Bug: #1947026
    Change-Id: I924504060179542bd2347b5155f70795d065381b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/814650

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/814651

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/814650
Committed: https://opendev.org/openstack/openstack-ansible/commit/eb029212158f1b9fe52cba51dd8cc09b13c47c0c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit eb029212158f1b9fe52cba51dd8cc09b13c47c0c
Author: Dmitriy Rabotyagov <email address hidden>
Date: Wed Oct 13 22:02:03 2021 +0300

    Fix manila haproxy manage

    In manila playbook we incorrectly defined haproxy backend name.
    This wasn't catched by CI since we do single node deployment.

    Closes-Bug: #1947026
    Change-Id: I924504060179542bd2347b5155f70795d065381b

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/814651
Committed: https://opendev.org/openstack/openstack-ansible/commit/5c9007aa838a5d043752cdbc30b1d351736fa4ea
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 5c9007aa838a5d043752cdbc30b1d351736fa4ea
Author: Dmitriy Rabotyagov <email address hidden>
Date: Wed Oct 13 22:02:03 2021 +0300

    Fix manila haproxy manage

    In manila playbook we incorrectly defined haproxy backend name.
    This wasn't catched by CI since we do single node deployment.

    Closes-Bug: #1947026
    Change-Id: I924504060179542bd2347b5155f70795d065381b

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 22.3.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 23.1.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 24.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 25.0.0.0b1 development milestone.