Allow disable console_agent when using spice console

[Flavio Picci]

Hello everyone,

since with windows guests using the spice console_agent leads to some issues (mainly with the pointer not working propertly), I would like to be able to specify `nova_console_agent_enabled: False` while enabling spice.
Currently setting `nova_console_agent_enabled` to False disables the whole spice server.

I would suggest to change the nova.conf.j2 section hardocding enabled = True or introduce another variable.
I think that hardcoding
```
[spice]
enabled = True
agent_enabled = {{ nova_console_agent_enabled }}
```
can be an option, I don't really see why one should specify `nova_console_type: spice` but wants to disable it.

OSA: stable/victoria

Thanks,
Flavio

[Dmitriy Rabotyagov (noonedeadpunk)]

Thanks for reporting this.

I've placed a patch https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/786077 to cover this. But I don't think it can be backported though. So for fixing thing for you I'd suggest using overrides:

nova_nova_conf_overrides:
  spice:
    agent_enabled: false

[Flavio Picci (flaviopicci)]

Hello Dmitriy,

I like the commited solution and using the conf override works fine for me.

Thanks,
Flavio

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/786077
Committed: https://opendev.org/openstack/openstack-ansible-os_nova/commit/fe8d651eaf43bd6cd09512c18fd0f66077ee8a39
Submitter: "Zuul (22348)"
Branch: master

commit fe8d651eaf43bd6cd09512c18fd0f66077ee8a39
Author: Dmitriy Rabotyagov <email address hidden>
Date: Tue Apr 13 19:48:40 2021 +0300

    Remove nova console variables

    Bunch of variables that were related to nova consoles were missused or
    unneded at all.
    Here we deprecate and remove them, along with
    fixing behaviour to disable spice agent functionality.

    Change-Id: I28f6d733db689eab879ae5939d1236e7c0d5f521
    Closes-Bug: #1923184

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_nova yoga-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_nova wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_nova xena-eom release.