OpenStack-Ansible

Fix security_shadow_utils_create_home boolean

Bug #1850200 reported by Ryan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Unassigned

Bug Description

Fix security_shadow_utils_create_home so it's not evaluated to True. Quoting yes will force a string (yes instead of True).
This causes directories to not be created for new users.

See: https://github.com/ansible/ansible/issues/11905

Fix is to add quotes around variable "yes"

https://github.com/openstack/ansible-hardening/pull/7

Diff:
https://patch-diff.githubusercontent.com/raw/openstack/ansible-hardening/pull/7.diff

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-hardening (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ansible-hardening/+/908977

Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-hardening (master)

Reviewed: https://review.opendev.org/c/openstack/ansible-hardening/+/908977
Committed: https://opendev.org/openstack/ansible-hardening/commit/510a0778a7172c047486f919b93b77e2a6671d8d
Submitter: "Zuul (22348)"
Branch: master

commit 510a0778a7172c047486f919b93b77e2a6671d8d
Author: Dmitriy Rabotyagov <email address hidden>
Date: Wed Feb 14 09:44:52 2024 +0100

    Use valid value for CREATE_HOME

    At the moment we pass boolean value to CREATE_HOME instead of yes/no.
    Leveraging ternary allows to always supply expected values despite of
    variable type in ansible.

    Closes-Bug: #1850200
    Change-Id: I957dc9b98f1de23ea66ea0e225989e4f907a02cb

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-hardening (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/ansible-hardening/+/914593

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-hardening (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/ansible-hardening/+/914594

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-hardening (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/ansible-hardening/+/914595

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-hardening (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/ansible-hardening/+/914593
Committed: https://opendev.org/openstack/ansible-hardening/commit/aa4e3fbf1aab3cd244d5a7b282dda2512ff40415
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit aa4e3fbf1aab3cd244d5a7b282dda2512ff40415
Author: Dmitriy Rabotyagov <email address hidden>
Date: Wed Feb 14 09:44:52 2024 +0100

    Use valid value for CREATE_HOME

    At the moment we pass boolean value to CREATE_HOME instead of yes/no.
    Leveraging ternary allows to always supply expected values despite of
    variable type in ansible.

    Closes-Bug: #1850200
    Change-Id: I957dc9b98f1de23ea66ea0e225989e4f907a02cb
    (cherry picked from commit 510a0778a7172c047486f919b93b77e2a6671d8d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-hardening (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/ansible-hardening/+/914594
Committed: https://opendev.org/openstack/ansible-hardening/commit/740a108032dfe22532ade421ac8ae07c33da9d13
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 740a108032dfe22532ade421ac8ae07c33da9d13
Author: Dmitriy Rabotyagov <email address hidden>
Date: Wed Feb 14 09:44:52 2024 +0100

    Use valid value for CREATE_HOME

    At the moment we pass boolean value to CREATE_HOME instead of yes/no.
    Leveraging ternary allows to always supply expected values despite of
    variable type in ansible.

    Closes-Bug: #1850200
    Change-Id: I957dc9b98f1de23ea66ea0e225989e4f907a02cb
    (cherry picked from commit 510a0778a7172c047486f919b93b77e2a6671d8d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-hardening (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/ansible-hardening/+/914595
Committed: https://opendev.org/openstack/ansible-hardening/commit/23ee60554334bbc0163ee9c66449068d50e31c4a
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 23ee60554334bbc0163ee9c66449068d50e31c4a
Author: Dmitriy Rabotyagov <email address hidden>
Date: Wed Feb 14 09:44:52 2024 +0100

    Use valid value for CREATE_HOME

    At the moment we pass boolean value to CREATE_HOME instead of yes/no.
    Leveraging ternary allows to always supply expected values despite of
    variable type in ansible.

    Closes-Bug: #1850200
    Change-Id: I957dc9b98f1de23ea66ea0e225989e4f907a02cb
    (cherry picked from commit 510a0778a7172c047486f919b93b77e2a6671d8d)

tags: added: in-stable-zed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.