OS Keystone role race condition during bootstrap

[Bjoern]

I encountered a race condition based on a previous OSA stein install where the credential migrated

https://github.com/openstack/openstack-ansible-os_keystone/blob/stable/stein/tasks/keystone_credential_create.yml#L87

tried to access a database which was not setup as the keystone_db_setup.yml is called later inside the main.yml. Once I moved the keystone_db_setup.yml before the credential_create playbook, the role successfully installed.

Error:

May 14 05:08:41 controller-3 keystone-manage[131151]: 2019-05-14 05:08:41.414 131151 CRITICAL keystone [-] Unhandled error: OperationalError: (pymysql.err.OperationalError) (1045
, u"Access denied for user 'keystone'@'infra-1.openstack.local' (using password: YES)")

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/659676

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/659676
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_keystone/commit/?id=3afb763c103665f8c04f3d8ebeda8b207e1fcab7
Submitter: Zuul
Branch: master

commit 3afb763c103665f8c04f3d8ebeda8b207e1fcab7
Author: Bjoern Teipel <email address hidden>
Date: Thu May 16 16:59:54 2019 -0500

    Execute the keystone db setup earlier in the process

    As the keystone credential_migrate command can access
    the keystone database in cases the os_keystone role
    stopped prematurely, the db setup playbook is moved
    in front of the `keystone_credential_create.yml` playbook
    to prevent and race condition.

    Change-Id: I8c89be0ffb4f23b79c0463bff2eb135b9769eb2a
    Closed-Bug: #1829438

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/665218

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665218
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_keystone/commit/?id=d074c927fdc372441d04764e2d1471bf11330909
Submitter: Zuul
Branch: stable/stein

commit d074c927fdc372441d04764e2d1471bf11330909
Author: Bjoern Teipel <email address hidden>
Date: Thu May 16 16:59:54 2019 -0500

    Execute the keystone db setup earlier in the process

    As the keystone credential_migrate command can access
    the keystone database in cases the os_keystone role
    stopped prematurely, the db setup playbook is moved
    in front of the `keystone_credential_create.yml` playbook
    to prevent and race condition.

    Change-Id: I8c89be0ffb4f23b79c0463bff2eb135b9769eb2a
    Closed-Bug: #1829438
    (cherry picked from commit 3afb763c103665f8c04f3d8ebeda8b207e1fcab7)

[VinceLe (legoll)]

I think this bug status should be updated