Drop name2int for string_to_int

Bug #1826243 reported by Mohammed Naser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Jonathan Rosser

Bug Description

The name2int is a module which really is doing what a filter should be doing, plus we already have a filter that does pretty much the same behavior, we only use name2int once here:

https://opendev.org/openstack/openstack-ansible-os_neutron/src/branch/master/tasks/neutron_l3_ha.yml

We should switch that task to use string_to_int and then proceed to remove the name2int module.

Mohammed Naser (mnaser)
tags: added: low-hanging-fruit
Revision history for this message
Mohammed Naser (mnaser) wrote :

removing this actually, because we have 'name2int' module which does the same, which really should be a *filter* not a module, so let's keeps string_2_int and move name2int to it

tags: added: plugin-cleanup
Changed in openstack-ansible:
status: New → Incomplete
status: Incomplete → Invalid
status: Invalid → New
summary: - Move string_2_int to integrated repo
+ Change name2int usage to string_to_int
description: updated
summary: - Change name2int usage to string_to_int
+ Drop name2int for string_to_int
Changed in openstack-ansible:
assignee: nobody → Georgina Shippey (gshippey)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to openstack-ansible-os_neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/656761

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-plugins (master)

Fix proposed to branch: master
Review: https://review.opendev.org/657761

Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on openstack-ansible-os_neutron (master)

Change abandoned by Jonathan Rosser (<email address hidden>) on branch: master
Review: https://review.opendev.org/656761
Reason: These tasks are removed in the master branch now

Changed in openstack-ansible:
assignee: Georgina Shippey (gshippey) → Jonathan Rosser (jrosser)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-plugins (master)

Reviewed: https://review.opendev.org/657761
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-plugins/commit/?id=5af0b9bcc34a93c6c49cb1c153dbba69f0fd79ea
Submitter: Zuul
Branch: master

commit 5af0b9bcc34a93c6c49cb1c153dbba69f0fd79ea
Author: Georgina <email address hidden>
Date: Wed May 8 08:37:07 2019 +0000

    Removing name2int module

    Module not widely used.
    Module usage should be replaced with string_2_int filter.

    Change-Id: I1b71275af47db50380965bbb8c899ae4d5aa439f
    Closes-Bug: #1826243

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins train-eol

This issue was fixed in the openstack/openstack-ansible-plugins train-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins ussuri-eol

This issue was fixed in the openstack/openstack-ansible-plugins ussuri-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins yoga-eom

This issue was fixed in the openstack/openstack-ansible-plugins yoga-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins victoria-eom

This issue was fixed in the openstack/openstack-ansible-plugins victoria-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins wallaby-eom

This issue was fixed in the openstack/openstack-ansible-plugins wallaby-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins xena-eom

This issue was fixed in the openstack/openstack-ansible-plugins xena-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins zed-eom

This issue was fixed in the openstack/openstack-ansible-plugins zed-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.