| 2019-03-19 10:19:46 |
Jesse Pretorius |
bug |
|
|
added bug |
| 2019-03-19 10:21:16 |
Jesse Pretorius |
description |
In openstack-ansible-plugins we have several 'netloc' filters which were useful prior to Ansible 2.4, but in Ansible 2.4 there is now the urlsplit filter which can perform all the same functions.
We should replace the use of all the netloc filters in all repositories with the url split filter, then remove the netloc filters from openstack-ansible-plugins.
This reduces our technical debt. |
In openstack-ansible-plugins we have several 'netloc' filters [1] which were useful prior to Ansible 2.4, but in Ansible 2.4 there is now the urlsplit filter which can perform all the same functions.
We should replace the use of all the netloc filters in all repositories with the url split filter, then remove the netloc filters from openstack-ansible-plugins.
This reduces our technical debt.
[1] https://github.com/openstack/openstack-ansible-plugins/blob/44a8205f5e6773d166b10e71a73aa8d2cbb6296e/filter/osa-filters.py#L156-L214 |
|
| 2019-03-19 10:22:17 |
Jesse Pretorius |
summary |
Replace custom netloc filters with sensible native urlsplit filter |
Replace custom netloc filters with ansible native urlsplit filter |
|
| 2019-03-19 10:36:02 |
Jesse Pretorius |
tags |
|
low-hanging-fruit |
|
| 2019-03-19 14:06:19 |
Georgina Shippey |
openstack-ansible: assignee |
|
Georgina Shippey (gshippey) |
|
| 2019-03-19 14:11:30 |
Jesse Pretorius |
description |
In openstack-ansible-plugins we have several 'netloc' filters [1] which were useful prior to Ansible 2.4, but in Ansible 2.4 there is now the urlsplit filter which can perform all the same functions.
We should replace the use of all the netloc filters in all repositories with the url split filter, then remove the netloc filters from openstack-ansible-plugins.
This reduces our technical debt.
[1] https://github.com/openstack/openstack-ansible-plugins/blob/44a8205f5e6773d166b10e71a73aa8d2cbb6296e/filter/osa-filters.py#L156-L214 |
In openstack-ansible-plugins we have several 'netloc' filters [1] which were useful prior to Ansible 2.4, but in Ansible 2.4 there is now the urlsplit filter [2] which can perform all the same functions.
We should replace the use of all the netloc filters in all repositories with the urlsplit filter, then remove the netloc filters from openstack-ansible-plugins.
Examples:
"{{ foo | get_netloc }}" -> "{{ foo | urlsplit('netloc') }}"
"{{ foo | get_netloc_no_port }}" -> "{{ foo | urlsplit('hostname') }}"
"{{ foo | get_netorigin }}" -> "{{ foo | urlsplit('scheme') ~ '://' ~ urlsplit('netloc') }}"
This reduces our technical debt.
[1] https://github.com/openstack/openstack-ansible-plugins/blob/44a8205f5e6773d166b10e71a73aa8d2cbb6296e/filter/osa-filters.py#L156-L214
[2] https://docs.ansible.com/ansible/2.7/user_guide/playbooks_filters.html#url-split-filter |
|
| 2019-03-19 14:11:55 |
Jesse Pretorius |
description |
In openstack-ansible-plugins we have several 'netloc' filters [1] which were useful prior to Ansible 2.4, but in Ansible 2.4 there is now the urlsplit filter [2] which can perform all the same functions.
We should replace the use of all the netloc filters in all repositories with the urlsplit filter, then remove the netloc filters from openstack-ansible-plugins.
Examples:
"{{ foo | get_netloc }}" -> "{{ foo | urlsplit('netloc') }}"
"{{ foo | get_netloc_no_port }}" -> "{{ foo | urlsplit('hostname') }}"
"{{ foo | get_netorigin }}" -> "{{ foo | urlsplit('scheme') ~ '://' ~ urlsplit('netloc') }}"
This reduces our technical debt.
[1] https://github.com/openstack/openstack-ansible-plugins/blob/44a8205f5e6773d166b10e71a73aa8d2cbb6296e/filter/osa-filters.py#L156-L214
[2] https://docs.ansible.com/ansible/2.7/user_guide/playbooks_filters.html#url-split-filter |
In openstack-ansible-plugins we have several 'netloc' filters [1] which were useful prior to Ansible 2.4, but in Ansible 2.4 there is now the urlsplit filter [2] which can perform all the same functions.
We should replace the use of all the netloc filters in all repositories with the urlsplit filter, then remove the netloc filters from openstack-ansible-plugins.
Examples:
"{{ foo | get_netloc }}" -> "{{ foo | urlsplit('netloc') }}"
"{{ foo | get_netloc_no_port }}" -> "{{ foo | urlsplit('hostname') }}"
"{{ foo | get_netorigin }}" ->
"{{ foo | urlsplit('scheme') ~ '://' ~ urlsplit('netloc') }}"
This reduces our technical debt.
[1] https://github.com/openstack/openstack-ansible-plugins/blob/44a8205f5e6773d166b10e71a73aa8d2cbb6296e/filter/osa-filters.py#L156-L214
[2] https://docs.ansible.com/ansible/2.7/user_guide/playbooks_filters.html#url-split-filter |
|
| 2019-03-19 14:13:26 |
Jesse Pretorius |
description |
In openstack-ansible-plugins we have several 'netloc' filters [1] which were useful prior to Ansible 2.4, but in Ansible 2.4 there is now the urlsplit filter [2] which can perform all the same functions.
We should replace the use of all the netloc filters in all repositories with the urlsplit filter, then remove the netloc filters from openstack-ansible-plugins.
Examples:
"{{ foo | get_netloc }}" -> "{{ foo | urlsplit('netloc') }}"
"{{ foo | get_netloc_no_port }}" -> "{{ foo | urlsplit('hostname') }}"
"{{ foo | get_netorigin }}" ->
"{{ foo | urlsplit('scheme') ~ '://' ~ urlsplit('netloc') }}"
This reduces our technical debt.
[1] https://github.com/openstack/openstack-ansible-plugins/blob/44a8205f5e6773d166b10e71a73aa8d2cbb6296e/filter/osa-filters.py#L156-L214
[2] https://docs.ansible.com/ansible/2.7/user_guide/playbooks_filters.html#url-split-filter |
In openstack-ansible-plugins we have several 'netloc' filters [1] which were useful prior to Ansible 2.4, but in Ansible 2.4 there is now the urlsplit filter [2] which can perform all the same functions.
We should replace the use of all the netloc filters in all repositories with the urlsplit filter, then remove the netloc filters from openstack-ansible-plugins.
Examples:
"{{ foo | get_netloc }}" -> "{{ foo | urlsplit('netloc') }}"
"{{ foo | get_netloc_no_port }}" -> "{{ foo | urlsplit('hostname') }}"
"{{ foo | get_netorigin }}" ->
"{{ foo | urlsplit('scheme') ~ '://' ~ urlsplit('netloc') }}"
This reduces our technical debt.
[1] https://github.com/openstack/openstack-ansible-plugins/blob/44a8205f5e6773d166b10e71a73aa8d2cbb6296e/filter/osa-filters.py#L156-L214
[2] https://docs.ansible.com/ansible/2.4/playbooks_filters.html#url-split-filter |
|
| 2019-04-23 12:38:31 |
OpenStack Infra |
openstack-ansible: status |
New |
In Progress |
|
| 2019-04-24 18:58:59 |
OpenStack Infra |
openstack-ansible: status |
In Progress |
Fix Released |
|
