New keepalived config is bugged

Bug #1816561 reported by Luis Filipe Domingues on 2019-02-19
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Luis Filipe Domingues

Bug Description

The patch from does not work properly well.

The option with the source of the script was called "src_ping_script" and it should be called src_check_script.

Plus, if we just use "check_script" and "src_check_script", the file from the source will be copy, to the target, and take the name set on "check_script". This could be an issue if we have parameters under "check_script".
For example, if we have something like:
check_script: "/etc/keepalived/ {{ keepalived_ping_count }} {{ keepalived_ping_address }}"

We could end up with a file name:
"/etc/keepalived/ 1"

We should for that have an optional field for setting the destination without taking the parameters, like dest_check_script.

Changed in openstack-ansible:
status: New → In Progress
assignee: nobody → Luis Filipe Domingues (domigues-luis)

Fix for the script name has been merged on upstream project:

Changed in openstack-ansible:
assignee: Luis Filipe Domingues (domigues-luis) → Jesse Pretorius (jesse-pretorius)
Changed in openstack-ansible:
assignee: Jesse Pretorius (jesse-pretorius) → Luis Filipe Domingues (domigues-luis)

Submitter: Zuul
Branch: master

commit cf4a3d96c925c0d1de0be80ced8ac88f2799a1eb
Author: Domingues Luis Filipe <email address hidden>
Date: Tue Feb 19 14:10:35 2019 +0100

    Fix keepalive pingable_check_script

    The source field needs to be called src_check_script
    instead of src_ping_check. Plus, check_script takes
    parameters, so we need to define the target name under
    dest_check_script field.

    Change-Id: I7b02a5d58816d3dc7b21a0b5f3bedab530f2b906
    Closes-bug: #1816561

Changed in openstack-ansible:
status: In Progress → Fix Released

This issue was fixed in the openstack/openstack-ansible development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers