Keepalived config is not future-proof

[Luis Filipe Domingues]

While doing some tests on one of our labs, we back-ported keepalived from disco (2.0.10). Doing that, keepalived stopped working.

The bug appear because keepalived, from version 2, switched from system() for executing scripts to execve().
https://github.com/acassen/keepalived/commit/b4566528e64370eb2ca07d24e43ecaef55d43073

The two jobs, vrrp_script haproxy_check_script and vrrp_script pingable_check_script, failed because the command is not executed in a shell anymore, and fail because the shell part (passed to the command as argument) are not understood by the command itself.

It could be a good idea to prepare the keepalived config to be future-proof.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/634209

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/634209
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=f91b88078a71525608664df6b4559cd7908117b2
Submitter: Zuul
Branch: master

commit f91b88078a71525608664df6b4559cd7908117b2
Author: Domingues Luis Filipe <email address hidden>
Date: Thu Jan 31 13:02:32 2019 +0100

    Make keepalived configuration future-proof

    As keepalived, from v2.0.0, uses execev() instead
    of system() for running scripts, the haproxy_check
    and the pingable_check will fail when upgrading
    keepalived. Exporting the full command into scripts
    make them compatibale with newer version of keepalived.

    Change-Id: Iea7d4565910046149d64dd1b4d8ec7bebb6e9e2a
    Closes-bug: #1814064

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 19.0.0.0b1 development milestone.