Upgrade from Pike to Queens skips setup-hosts when running neutron on bare metal

[Bjoern]

In case neutron was deployed to bare metal, on the infra hosts, the upgrade from P to Q will skip setup-hosts due to the exclusion based off "!neutron_agent" per https://github.com/openstack/openstack-ansible/blob/stable/queens/scripts/run-upgrade.sh#L180

We should much rather split up the setup-hosts to account for this situation.
Are there any other opinion on this ?

I'll create a initial PR.

[Jesse Pretorius (jesse-pretorius)]

FYI https://review.openstack.org/625898 resolved this for Queens->Rocky, and for Rocky->Stein we've opted to change the whole process to something a lot simpler which also solves the issue: https://review.openstack.org/624773

It may be best to just do the same as is now in master: https://github.com/openstack/openstack-ansible/blob/3fb15ad780c769c1991affff3b7ccb75ae138169/scripts/run-upgrade.sh#L171-L174

[Antony Messerli (antonym)]

Are there plans to backport this to Pike->Queens as well or is the transition of neutron-agents to baremetal getting in the way of this?

[Dmitriy Rabotyagov (noonedeadpunk)]

Sorry, Pike and Queens are already EOLed, so we can't backport any changes there.

I will marked it as fix released since it has been actually fixed.