container properties were not updated from env.d file

[Craig McIntyre]

Ubuntu xenial
openstack-ansible git branch queens/stable
container backing: LVM

Creating a yml file for a container in /etc/openstack_deploy/env.d and configuring container properties "container_fs_size" did not get parsed by the dynamic inventory.

To reproduce, copy pkg_repo.yml from /opt/openstack-ansible/inventory/env.d/ to /etc/openstack_deploy/env.d and modify container_skel as follows:

container_skel:
   repo_container:
     belongs_to:
       - repo-infra_containers
     contains:
       - pkg_repo
     properties:
      container_fs_size: 10G

execute "openstack-ansible lxc-containers-create.yml --vvv --limit repo_container,lxc_hosts" and observe that "fs_size" remained 5G.

lvdisplay shows LVM is 5GB

manually querying openstack_inventory.json shows "properties": {} under repo container.

To work around, update openstack_user_config.yml as follows:

repo-infra_hosts:
  infra1:
    ip: 172.29.236.11
    container_vars:
      properties:
        container_fs_size: 10G

[Jesse Pretorius (jesse-pretorius)]

For reference, the conversation which precipitated this bug and some triage was done in the IRC channel. See http://eavesdrop.openstack.org/irclogs/%23openstack-ansible/%23openstack-ansible.2018-12-17.log.html#t2018-12-17T14:23:23