glance db sync always fails during upgrade due to OsloDBDeprecationWarning: EngineFacade is deprecated

[Jérôme Drouet]

db_sync always fails during Q upgrade, see logs below

TASK [os_glance : Perform a Glance DB sync] ***********************************************************************************************************************************************************************
task path: /etc/ansible/roles/os_glance/tasks/glance_db_setup.yml:16
Friday 24 August 2018 11:54:35 +0200 (0:00:00.087) 0:00:19.915 *********
fatal: [os-controller01_glance_container-859e9543]: FAILED! => {"changed": false, "cmd": ["/openstack/venvs/glance-17.0.8/bin/glance-manage", "db_sync"], "delta": "0:00:01.713680", "end": "2018-08-24 11:54:37.043217", "failed": true, "msg": "non-zero return code", "rc": 1, "start": "2018-08-24 11:54:35.329537", "stderr": "/openstack/venvs/glance-17.0.8/lib/python2.7/site-packages/oslo_db/sqlalchemy/enginefacade.py:1336: OsloDBDeprecationWarning: EngineFacade is deprecated; please use oslo_db.sqlalchemy.enginefacade\n expire_on_commit=expire_on_commit, _conf=conf)", "stderr_lines": ["/openstack/venvs/glance-17.0.8/lib/python2.7/site-packages/oslo_db/sqlalchemy/enginefacade.py:1336: OsloDBDeprecationWarning: EngineFacade is deprecated; please use oslo_db.sqlalchemy.enginefacade", " expire_on_commit=expire_on_commit, _conf=conf)"], "stdout": "", "stdout_lines": []}

need a way to ignore only this deprecation/error in task, or use oslo_db.sqlalchemy.enginefacade instead

[Jean-Philippe Evrard (jean-philippe-evrard)]

Could you help us triage this issue?

We'd need:
- Extracts of the /var/log/glance
- Detailed version information from Pike and the version you are bumping in queens.
- Any information or overrides about the glance backends
- Information about the process used for upgrades

[Jérôme Drouet (jerome-drouet)]

My bad i assumed the return code 1 was triggered by the warning, having a closer look at glance-manage.log showed errors :
trying to drop already non exitant column and index in ocata_contract01_drop_is_public.py
during Liberty to Queens upgrade using ceph backend

# sudo -u glance -- /openstack/venvs/glance-17.0.8/bin/glance-manage db_sync ; echo $?
/openstack/venvs/glance-17.0.8/lib/python2.7/site-packages/oslo_db/sqlalchemy/enginefacade.py:1336: OsloDBDeprecationWarning: EngineFacade is deprecated; please use oslo_db.sqlalchemy.enginefacade
  expire_on_commit=expire_on_commit, _conf=conf)
Database is up to date. No migrations needed.
0
# sudo -u glance -- /openstack/venvs/glance-17.0.8/bin/glance-manage db version ; echo $?
/openstack/venvs/glance-17.0.8/lib/python2.7/site-packages/oslo_db/sqlalchemy/enginefacade.py:1336: OsloDBDeprecationWarning: EngineFacade is deprecated; please use oslo_db.sqlalchemy.enginefacade
  expire_on_commit=expire_on_commit, _conf=conf)
queens_contract01
0

migration is now fine and return code is now 0 despite the warning

sorry for the noise

regards