attempting to disable ctrl-alt-del reboot always skips

Bug #1787048 reported by om
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Kevin Carter

Bug Description

At the bottom is the code-snipit of the faulty code, it assumes the systemctl status returns 0 or 3, in which case I am experiencing it to return 3 all the time.

To fix I would simply just run the mask command without checking if it were mask'd to begin with.

Testing on my local RHEL7 (yum updated as of aug-09):

#### disabling the symlink

# systemctl unmask ctrl-alt-del.target
Removed symlink /etc/systemd/system/ctrl-alt-del.target.

#### check return code of status
# systemctl status ctrl-alt-del.target; echo $?
● reboot.target - Reboot
   Loaded: loaded (/usr/lib/systemd/system/reboot.target; disabled; vendor preset: disabled)
   Active: inactive (dead)
     Docs: man:systemd.special(7)
3

#### enabling the symlink
# systemctl mask ctrl-alt-del.target
Created symlink from /etc/systemd/system/ctrl-alt-del.target to /dev/null.

#### check return code of status
systemctl status ctrl-alt-del.target; echo $?
● ctrl-alt-del.target
   Loaded: masked (/dev/null; bad)
   Active: inactive (dead)
3

#### file: ansible-hardening/tasks/rhel7stig/misc.yml
#### line number: 38-58

# This returns an exit code of 0 if it's running, 3 if it's masked.
- name: Check if ctrl-alt-del.target is already masked
  command: systemctl status ctrl-alt-del.target
  register: cad_mask_check
  check_mode: no
  changed_when: False
  failed_when: cad_mask_check.rc not in [0,3]
  tags:
    - always

- name: V-71993 - The x86 Ctrl-Alt-Delete key sequence must be disabled
  command: systemctl mask ctrl-alt-del.target
  when:
    - security_rhel7_disable_ctrl_alt_delete | bool
    - cad_mask_check.rc != 3
  notify:
    - reload systemd
  tags:
    - high
    - misc
    - V-71993

Revision history for this message
Mohammed Naser (mnaser) wrote :

This should be fixed by using https://docs.ansible.com/ansible/2.4/systemd_module.html instead

Changed in openstack-ansible:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Kevin Carter (kevin-carter)
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-hardening (master)

Fix proposed to branch: master
Review: https://review.openstack.org/594366

Changed in openstack-ansible:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-hardening (master)

Reviewed: https://review.openstack.org/594366
Committed: https://git.openstack.org/cgit/openstack/ansible-hardening/commit/?id=111f48b2f670353f51476817420893950aef3609
Submitter: Zuul
Branch: master

commit 111f48b2f670353f51476817420893950aef3609
Author: Kevin Carter <email address hidden>
Date: Tue Aug 21 11:31:01 2018 -0500

    Correct issue with ansible hardening and systemd

    The systemd command does not have a stable api and can return different
    codes when executed. This change converts the task to query the target
    unit and disable it if it exists to a single systemd task using the
    ansible module.

    Closes-Bug: #1787048
    Change-Id: I74c43839cd7d3a8620a0fb8e405fbc3f6a0f44d0
    Signed-off-by: Kevin Carter <email address hidden>

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ansible-hardening stein-eol

This issue was fixed in the openstack/ansible-hardening stein-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ansible-hardening train-eol

This issue was fixed in the openstack/ansible-hardening train-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ansible-hardening ussuri-eol

This issue was fixed in the openstack/ansible-hardening ussuri-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ansible-hardening yoga-eom

This issue was fixed in the openstack/ansible-hardening yoga-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ansible-hardening victoria-eom

This issue was fixed in the openstack/ansible-hardening victoria-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ansible-hardening wallaby-eom

This issue was fixed in the openstack/ansible-hardening wallaby-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ansible-hardening xena-eom

This issue was fixed in the openstack/ansible-hardening xena-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.