neutron l3 agent fails to spawn HA router

[Jakob Englisch]

Env:
3 controller setup
new installation, OSA tag 17.0.6, centos 7.5 1805

Neutron with HA router VRRP setup.

Neutron-l3-agent fails with the following stacktrace: http://paste.openstack.org/show/MTMvb6BMWw9Aa6YTI0vX/

on controller 1, neutron-keepalived-state-change is not present in the current netns $PATH:
http://paste.openstack.org/show/726128/

journald: http://paste.openstack.org/show/726132/

fixing the script by symlinking
`ln -s /openstack/venvs/neutron-17.0.6/bin/neutron-keepalived-state-change /usr/local/bin/neutron-keepalived-state-change` leads to
http://paste.openstack.org/show/726129/ (where the HA IP is present on two controller nodes, i expected only one)

--
update:
adding
> kill_keepalived_state_change: KillFilter, root, neutron-keepalived-state-change, -15, -9, -HUP
to /etc/neutron/rootwrap.d/l3.filters is required as well, to cleanup orphan routers. it seems this script has been forgotten in OSA entirely

[Jonathan Rosser (jrosser)]

This is fixed in https://review.openstack.org/630374