Neutron role does not enable osprofiler

Bug #1781619 reported by Stuart Grace
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Low
Jonathan Rosser

Bug Description

The neutron pipelines in api-paste.ini do not include the osprofiler filter:
https://github.com/openstack/openstack-ansible-os_neutron/blob/3bd96fecbfa6abb1b591a74d5a4b89321a8328ff/templates/api-paste.ini.j2#L8-L9

The osprofiler filter is included in the standard pipelines for nova, glance, cinder, heat, magnum, etc. See for example:
https://github.com/openstack/openstack-ansible-os_nova/blob/9f53e04687d5cab829e5dcf9c2049fddd5f44ed7/templates/api-paste.ini.j2#L31-L32

This means when profiling is enabled, there is a gap in the timeline when the neutron API is executing.

Marc Gariépy (mgariepy)
Changed in openstack-ansible:
status: New → Confirmed
importance: Undecided → Medium
importance: Medium → Low
tags: added: low-hanging-fruit
Changed in openstack-ansible:
assignee: nobody → Jonathan Rosser (jrosser)
Revision history for this message
Kevin Carter (kevin-carter) wrote :

Once https://review.openstack.org/#/c/573511/ is merged this should be resolved. Users wanting to enable this for neutron can do so with a config_template override:

``` yaml

profiler_overrides: &os_profiler
  profiler:
    enabled: true
    trace_sqlalchemy: true
    hmac_keys: "UNIQUE_HMACKEY" # This needs to be set consistently throughout the deployment
    connection_string: "Elasticsearch://{{ internal_lb_vip_address }}:9201"
    es_doc_type: "notification"
    es_scroll_time: "2m"
    es_scroll_size: "10000"
    filter_error_trace: "false"

neutron_neutron_conf_overrides: *os_profiler

```

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/583400

Changed in openstack-ansible:
status: Confirmed → In Progress
Revision history for this message
Jonathan Rosser (jrosser) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_neutron (master)

Reviewed: https://review.openstack.org/583400
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_neutron/commit/?id=ad47b94849e772e4dc49d863b6a3fe7f89445dff
Submitter: Zuul
Branch: master

commit ad47b94849e772e4dc49d863b6a3fe7f89445dff
Author: Jonathan Rosser <email address hidden>
Date: Tue Jul 17 21:05:40 2018 +0000

    Add osprofiler to api-paste pipeline

    The osprofiler filter is included in the standard pipelines for
    nova, glance, cinder, heat, magnum [1], but is missing for
    upstream neutron.

    This means when a deployment uses profiling, there is a gap in the
    data collected when the neutron API is executing.

    Upstream fix https://review.openstack.org/#/c/583362/

    [1] https://github.com/openstack/openstack-ansible-os_nova/blob/master/templates/api-paste.ini.j2#L31-L32

    Change-Id: I63e2e8a1886527d363986bbb82c069eaaaa4406a
    Partial-Bug: #1781619

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.0.0.0b1

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.

Changed in openstack-ansible:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.