os-lxc-container-setup.yml was skipped for cinder_volume container when cinder uses rbd as backend

[Chenjun Shen]

Problem description:

please have a look at this task "Configure container (cinder-volume)", code -> https://github.com/openstack/openstack-ansible/blob/master/playbooks/common-playbooks/cinder.yml#L45-L58

We're using rbd as cinder backend instead of lvm, this task would do NOTHING, and there is no other task to run common-tasks/os-lxc-container-setup.yml on cinder_volume containers. So cinder_volume container would not be properly setup.

Problem side effect:

Because the cinder_volumes container is not properly setup, lxc config misses mount entry for /var/log.

The missing entry is as below:

lxc.mount.entry = /openstack/log/ctr0001_cinder_volumes_container-ac0d2c0a var/log none bind,create=dir 0 0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/581248

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/581248
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=92427a6531aca062d3e4cb536b0db55992aa0ef6
Submitter: Zuul
Branch: master

commit 92427a6531aca062d3e4cb536b0db55992aa0ef6
Author: Chenjun Shen <email address hidden>
Date: Tue Jul 10 10:15:10 2018 +0200

    Fix "configure container (other services)" when statement

    Configure container (other services) task should be executed when
    cinder_volume uses other than lvm as backend (for example. rbd). But the
    existing code completely skips both "Configure container
    (cinder-volume)" and "Configure container (other services)" tasks. So
    the cinder_volume container is not properly initialized when using rbd as
    backend.

    Change-Id: Ieb195e8a0cd3435fa3e872b609717aadc2ff41e8
    Closes-Bug: #1780789
    Closes-Bug: #1756005

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/622507

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/622507
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=a83274abfd7c1130a95481ece32cb44ce04745f1
Submitter: Zuul
Branch: stable/rocky

commit a83274abfd7c1130a95481ece32cb44ce04745f1
Author: Chenjun Shen <email address hidden>
Date: Tue Jul 10 10:15:10 2018 +0200

    Fix "configure container (other services)" when statement

    Configure container (other services) task should be executed when
    cinder_volume uses other than lvm as backend (for example. rbd). But the
    existing code completely skips both "Configure container
    (cinder-volume)" and "Configure container (other services)" tasks. So
    the cinder_volume container is not properly initialized when using rbd as
    backend.

    Change-Id: Ieb195e8a0cd3435fa3e872b609717aadc2ff41e8
    Closes-Bug: #1780789
    Closes-Bug: #1756005
    (cherry picked from commit 92427a6531aca062d3e4cb536b0db55992aa0ef6)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 18.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 19.0.0.0b1 development milestone.