pip install offline fails with new version of get-pip.py

Bug #1779534 reported by Ondrej Vasko
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
High
Jesse Pretorius

Bug Description

Task `pip cache install files locally` [1] fails with new (default) version of get-pip.py [2].

The command is executed currently as:

python /tmp/get-pip.py -d /tmp/pip_install --constraint /opt/global-requirement-pins.txt --constraint https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?id=23a4a4b5c9b17a31a367edbd2e28954e8d9bb231 pip setuptools wheel

But new version of pip does not support argument `-d`, so it fails with error `no such option: -d`.

Problem is that get-pip.py does not support new command download. I tried to use new syntax with command below and it doesn't work. It looks like this must be implemented upstream.

python /tmp/get-pip.py download --root /tmp/pip_install --constraint https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\?id\=23a4a4b5c9b17a31a367edbd2e28954e8d9bb231 pip setuptools wheel

As a workaround people may still use older version from URL https://bootstrap.pypa.io/3.2/get-pip.py. You will however need to override parameter:

pip_upstream_url: https://bootstrap.pypa.io/3.2/get-pip.py

This should concern all OSA versions and operating systems.

[1] https://github.com/openstack/openstack-ansible-pip_install/blob/master/tasks/install_offline.yml#L66
[2] https://bootstrap.pypa.io/get-pip.py

Revision history for this message
Ondrej Vasko (ondrej.vasko) wrote :

Also if file `/opt/global-requirement-pins.txt` is missing on localhost, it is not provisioned with `install_offline.yml` playbook.

Mohammed Naser (mnaser)
Changed in openstack-ansible:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Jesse Pretorius (jesse-pretorius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_install (master)

Fix proposed to branch: master
Review: https://review.openstack.org/579924

Changed in openstack-ansible:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-tests (master)

Fix proposed to branch: master
Review: https://review.openstack.org/579926

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/579927

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-pip_install (master)

Reviewed: https://review.openstack.org/579924
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=6c00fab455fd764836442b51b5d788fed32f8278
Submitter: Zuul
Branch: master

commit 6c00fab455fd764836442b51b5d788fed32f8278
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:02:53 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Closes-Bug: 1779534
    Change-Id: I5a4d4096457d84fcf3a9e21a6873dd61f2a456fc

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_install (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/580116

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_install (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/580117

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_install (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/580118

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-tests (master)

Reviewed: https://review.openstack.org/579926
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=aa0a76ce9c1cae9e9b11d13be6b67bfd81232c75
Submitter: Zuul
Branch: master

commit aa0a76ce9c1cae9e9b11d13be6b67bfd81232c75
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:09:14 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Change-Id: I6aa297ee6e1ca3a76f016a6a0c3d4a735433a9b2
    Closes-Bug: 1779534

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-tests (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/580137

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-tests (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/580138

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-tests (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/580139

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/579927
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=e79314ecd462f1388d72bada681cc792a588d8db
Submitter: Zuul
Branch: master

commit e79314ecd462f1388d72bada681cc792a588d8db
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:10:15 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Change-Id: I2a49a407e82c23540cd0aff209bd276c8a303bf0
    Closes-Bug: 1779534

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-pip_install (stable/pike)

Reviewed: https://review.openstack.org/580117
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=385d3381cb95da8c4e2a0e8cf693f05c7c7b9fe2
Submitter: Zuul
Branch: stable/pike

commit 385d3381cb95da8c4e2a0e8cf693f05c7c7b9fe2
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:02:53 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Closes-Bug: 1779534
    Change-Id: I5a4d4096457d84fcf3a9e21a6873dd61f2a456fc
    (cherry picked from commit 6c00fab455fd764836442b51b5d788fed32f8278)

tags: added: in-stable-pike
tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-pip_install (stable/ocata)

Reviewed: https://review.openstack.org/580118
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=1c8778b5bb8e1275cb599a0f4d21d81c19dfc5a5
Submitter: Zuul
Branch: stable/ocata

commit 1c8778b5bb8e1275cb599a0f4d21d81c19dfc5a5
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:02:53 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Closes-Bug: 1779534
    Change-Id: I5a4d4096457d84fcf3a9e21a6873dd61f2a456fc
    (cherry picked from commit 6c00fab455fd764836442b51b5d788fed32f8278)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-pip_install (stable/queens)

Reviewed: https://review.openstack.org/580116
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=f3a1342e6a35bb35a7006bd2f14f33e2bb8066dc
Submitter: Zuul
Branch: stable/queens

commit f3a1342e6a35bb35a7006bd2f14f33e2bb8066dc
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:02:53 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Closes-Bug: 1779534
    Change-Id: I5a4d4096457d84fcf3a9e21a6873dd61f2a456fc
    (cherry picked from commit 6c00fab455fd764836442b51b5d788fed32f8278)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-tests (stable/pike)

Reviewed: https://review.openstack.org/580138
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=9ee26dd0731db010e3ee6452a8f79f3ac2dd746a
Submitter: Zuul
Branch: stable/pike

commit 9ee26dd0731db010e3ee6452a8f79f3ac2dd746a
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:09:14 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Change-Id: I6aa297ee6e1ca3a76f016a6a0c3d4a735433a9b2
    Closes-Bug: 1779534
    (cherry picked from commit aa0a76ce9c1cae9e9b11d13be6b67bfd81232c75)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-tests (stable/ocata)

Reviewed: https://review.openstack.org/580139
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=72e6ad3421de8250e6b1a542aaa3ed8b18f0c6af
Submitter: Zuul
Branch: stable/ocata

commit 72e6ad3421de8250e6b1a542aaa3ed8b18f0c6af
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:09:14 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Change-Id: I6aa297ee6e1ca3a76f016a6a0c3d4a735433a9b2
    Closes-Bug: 1779534
    (cherry picked from commit aa0a76ce9c1cae9e9b11d13be6b67bfd81232c75)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-tests (stable/queens)

Reviewed: https://review.openstack.org/580137
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=b934d9cde0ac1d49fafb5e503f97fd2cbb35d5c0
Submitter: Zuul
Branch: stable/queens

commit b934d9cde0ac1d49fafb5e503f97fd2cbb35d5c0
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:09:14 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Change-Id: I6aa297ee6e1ca3a76f016a6a0c3d4a735433a9b2
    Closes-Bug: 1779534
    (cherry picked from commit aa0a76ce9c1cae9e9b11d13be6b67bfd81232c75)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/580398

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/580399

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/580402

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/queens)

Reviewed: https://review.openstack.org/580398
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=a4fa7aee4366239560658c8f4b3846445fea6bd9
Submitter: Zuul
Branch: stable/queens

commit a4fa7aee4366239560658c8f4b3846445fea6bd9
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:10:15 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Change-Id: I2a49a407e82c23540cd0aff209bd276c8a303bf0
    Closes-Bug: 1779534
    (cherry picked from commit e79314ecd462f1388d72bada681cc792a588d8db)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 17.0.6

This issue was fixed in the openstack/openstack-ansible 17.0.6 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/ocata)

Reviewed: https://review.openstack.org/580402
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=6832adb392fdf395206616b8dad2c4c6969e421d
Submitter: Zuul
Branch: stable/ocata

commit 6832adb392fdf395206616b8dad2c4c6969e421d
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:10:15 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Change-Id: I2a49a407e82c23540cd0aff209bd276c8a303bf0
    Closes-Bug: 1779534
    (cherry picked from commit e79314ecd462f1388d72bada681cc792a588d8db)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/pike)

Reviewed: https://review.openstack.org/580399
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=f11b17199e79d43a3a817da6ff7ab35f3f445e12
Submitter: Zuul
Branch: stable/pike

commit f11b17199e79d43a3a817da6ff7ab35f3f445e12
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 3 18:10:15 2018 +0100

    Pin get-pip.py to 3.2

    As get-pip.py evolves based on pip 10, while we're still using
    pip 9, changes in the way it can be used are causing problems.

    For example, the ability to use --download is no longer there.

    As such, let's pin to a known good version and leave it at that
    until we no longer need to use this script. Version 3.2 maps to
    pip 7.1.2 which fulfills our needs.

    Change-Id: I2a49a407e82c23540cd0aff209bd276c8a303bf0
    Closes-Bug: 1779534
    (cherry picked from commit e79314ecd462f1388d72bada681cc792a588d8db)

Revision history for this message
Satish Patel (satish-txt) wrote :

I am tying to upgrade my minor version from 16.0.14 to 16.0.15 and i stuck here, look like same bug which i reported here https://bugs.launchpad.net/openstack-ansible/+bug/1782051

I do have correct fix but still getting error, any idea?

Revision history for this message
Satish Patel (satish-txt) wrote :

This is what i found after working on with @cloudnull on IRC

get-pip.py version 3.2 has some issue.

https://bootstrap.pypa.io/3.2/get-pip.py

After changing 3.3 it fixed my issue

[root@ostack-log-01 opt]# wget https://bootstrap.pypa.io/3.3/get-pip.py

[root@ostack-log-01 opt]# python /opt/get-pip.py --isolated --constraint /opt/global-requirement-pins.txt --constraint http://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?id=60d840183f0665483e942649e5bc3e4f6ecbbad3 pip setuptools wheel

Command ran successful without error.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_install (master)

Fix proposed to branch: master
Review: https://review.openstack.org/583077

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-pip_install (master)

Reviewed: https://review.openstack.org/583077
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=79063a3e10ba733ea50a404627570c6a21bebd83
Submitter: Zuul
Branch: master

commit 79063a3e10ba733ea50a404627570c6a21bebd83
Author: Kevin Carter <email address hidden>
Date: Mon Jul 16 21:10:47 2018 -0500

    Update get-pip to version 3.3

    Version 3.2 has a bug with it on some systems that can result in the
    following stacktrace: [ http://paste.openstack.org/show/726064 ]. To
    correct this issue the version of the get-pip script has been set to 3.3
    which does not suffer from the same issue.

    Change-Id: Iaa824cc64bd0e8bdfdda4de243d80400f1529e8c
    Closes-Bug: #1779534
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_install (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/583234

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_install (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/583235

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-repo_build (master)

Fix proposed to branch: master
Review: https://review.openstack.org/583331

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/583342

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/583342
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=184dbb8e18973a8baf69d203c0b159367cb1ff8e
Submitter: Zuul
Branch: master

commit 184dbb8e18973a8baf69d203c0b159367cb1ff8e
Author: Dave Wilde <email address hidden>
Date: Tue Jul 17 14:07:41 2018 -0500

    Update get-pip to version 3.3

    Version 3.2 has a bug with it on some systems that can result in the
    following stacktrace: [ http://paste.openstack.org/show/726064 ]. To
    correct this issue the version of the get-pip script has been set to 3.3
    which does not suffer from the same issue.

    Change-Id: I61a7234dc4fbde1b9319874d82fe33578f490abc
    Partial-Bug: 1779534

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-repo_build (master)

Reviewed: https://review.openstack.org/583331
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-repo_build/commit/?id=8cbd722ac4de268cbf6c283f9825958071b6a6bb
Submitter: Zuul
Branch: master

commit 8cbd722ac4de268cbf6c283f9825958071b6a6bb
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 17 19:32:17 2018 +0100

    Update get-pip to version 3.3

    Version 3.2 has a bug with it on some systems that can result in the
    following stacktrace: [ http://paste.openstack.org/show/726064 ]. To
    correct this issue the version of the get-pip script has been set to 3.3
    which does not suffer from the same issue.

    Change-Id: Iaddb390a13d1955356e85af11ab087319808697c
    Closes-Bug: #1779534

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to openstack-ansible-pip_install (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/583925

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/584095

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/584098

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/584101

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-pip_install (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/584109

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to openstack-ansible-pip_install (stable/queens)

Reviewed: https://review.openstack.org/583925
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=aa74bf466e10bb41702d1187ca7779dd242e5145
Submitter: Zuul
Branch: stable/queens

commit aa74bf466e10bb41702d1187ca7779dd242e5145
Author: Jean-Philippe Evrard <email address hidden>
Date: Thu Jul 19 12:50:03 2018 +0200

    Ensure get-pip is not used when good version of pip is present

    This is a combined backport of three commits to make sure
    get-pip will be skipped if an appropriate version of pip is
    present.

    By skipping get-pip, no downgrade of pip will happen on the
    hosts, leading to issues like the bug here.

    Here are the commits:
    tests: Do not always fetch the get-pip.py script during tests

    Since we are testing the idempotence of this role, we shouldn't
    fetch the get-pip.py script on every iteration so we set the variable
    to 'false'. Moreover, we bump the PIP version to 9.0.3 since this is
    what is currently being deployed on the hosts. Finally, get-pip.py
    uses --force-reinstall by default which means that everything is being
    reinstalled all the time and this breaks idempotence. We can fix that by
    simply checking if a suitable version of PIP is installed and then use
    it to do a proper upgrade.

    ---

    tasks: main: Fix conditional for PIP script

    The conditional must search the 'stdout' item to find the string we
    are looking for.

    ---

    Ensure the fallback uses the same install method

    We have a test to ensure the install method of pip is from distro
    or get-pip. But if an issue appeared in the first task, the
    fallback method will automatically fallback to get-pip instead
    of fallback to the isolated version of the pre-defined CLI.

    This should ensure consistency by not using get-pip if it's not
    needed.

    ---

    (cherry picked from commit 40373daf7e27ab8cef00611945acf68c3e86fe82)
    (cherry picked from commit fe5d99228bb756a28fb433b4a734d1e604eb0482)
    (cherry picked from commit b6024a918442c0f89e207e496f497d14a8d55ba1)

    Change-Id: Ia6efeb278fd7a7ec32b9a48c8b3e44197afe182c
    Related-Bug: 1782051
    Related-Bug: 1779534

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-pip_install (stable/queens)

Reviewed: https://review.openstack.org/583234
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=73de271549e568268464507c269de4bb7f160763
Submitter: Zuul
Branch: stable/queens

commit 73de271549e568268464507c269de4bb7f160763
Author: Kevin Carter <email address hidden>
Date: Mon Jul 16 21:10:47 2018 -0500

    Update get-pip to version 3.3

    Version 3.2 has a bug with it on some systems that can result in the
    following stacktrace: [ http://paste.openstack.org/show/726064 ]. To
    correct this issue the version of the get-pip script has been set to 3.3
    which does not suffer from the same issue.

    Change-Id: Iaa824cc64bd0e8bdfdda4de243d80400f1529e8c
    Closes-Bug: #1779534
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 79063a3e10ba733ea50a404627570c6a21bebd83)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-pip_install (stable/pike)

Reviewed: https://review.openstack.org/583235
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=a39e6e0b4e1ecc95bb70331fc97bf136deea484d
Submitter: Zuul
Branch: stable/pike

commit a39e6e0b4e1ecc95bb70331fc97bf136deea484d
Author: Kevin Carter <email address hidden>
Date: Mon Jul 16 21:10:47 2018 -0500

    Update get-pip to version 3.3

    Version 3.2 has a bug with it on some systems that can result in the
    following stacktrace: [ http://paste.openstack.org/show/726064 ]. To
    correct this issue the version of the get-pip script has been set to 3.3
    which does not suffer from the same issue.

    Change-Id: Iaa824cc64bd0e8bdfdda4de243d80400f1529e8c
    Closes-Bug: #1779534
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 79063a3e10ba733ea50a404627570c6a21bebd83)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to openstack-ansible-repo_build (stable/queens)

Reviewed: https://review.openstack.org/584355
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-repo_build/commit/?id=64577cd93a5e5e2c37be61e07fa4f39a7a87c2ca
Submitter: Zuul
Branch: stable/queens

commit 64577cd93a5e5e2c37be61e07fa4f39a7a87c2ca
Author: Markos Chandras <email address hidden>
Date: Fri May 25 18:26:26 2018 +0100

    tasks: repo_build_wheels: Download get-pip.py if it does not exist

    /opt/get-pip.py may not exist if the host uses the distribution
    python-pip package. As such, we need to check if the file exists
    and download it if it's missing before trying to copy it to the
    repo build directory.

    This is a combined backport of:
    - https://review.openstack.org/570601
    - https://review.openstack.org/572422
    - https://review.openstack.org/580409
    - https://review.openstack.org/583331

    Related-Review: https://review.openstack.org/583925
    Related-Bug: #1779534
    Related-Bug: #1782051
    Change-Id: I693b930bf337fd08931d835d57ffe9ecae904517
    (cherry picked from commit ea4f8606df8a19edf5aa958a866f77ccafa62e47)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-pip_install (stable/ocata)

Reviewed: https://review.openstack.org/584109
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=64a204f434f7f68ef1c2f3c04bc84e186f5045b9
Submitter: Zuul
Branch: stable/ocata

commit 64a204f434f7f68ef1c2f3c04bc84e186f5045b9
Author: Kevin Carter <email address hidden>
Date: Mon Jul 16 21:10:47 2018 -0500

    Update get-pip to version 3.3

    Version 3.2 has a bug with it on some systems that can result in the
    following stacktrace: [ http://paste.openstack.org/show/726064 ]. To
    correct this issue the version of the get-pip script has been set to 3.3
    which does not suffer from the same issue.

    Change-Id: Iaa824cc64bd0e8bdfdda4de243d80400f1529e8c
    Closes-Bug: #1779534
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 79063a3e10ba733ea50a404627570c6a21bebd83)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/pike)

Reviewed: https://review.openstack.org/584098
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=0e03f46a2ebb0ffc6f12384f19ec1184434e7a09
Submitter: Zuul
Branch: stable/pike

commit 0e03f46a2ebb0ffc6f12384f19ec1184434e7a09
Author: Dave Wilde <email address hidden>
Date: Tue Jul 17 14:07:41 2018 -0500

    Update get-pip to version 3.3

    Version 3.2 has a bug with it on some systems that can result in the
    following stacktrace: [ http://paste.openstack.org/show/726064 ]. To
    correct this issue the version of the get-pip script has been set to 3.3
    which does not suffer from the same issue.

    Change-Id: I61a7234dc4fbde1b9319874d82fe33578f490abc
    Partial-Bug: 1779534
    (cherry picked from commit 184dbb8e18973a8baf69d203c0b159367cb1ff8e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/ocata)

Reviewed: https://review.openstack.org/584101
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=f69a336501ba1533ee568cbc83d06fadf7441dbc
Submitter: Zuul
Branch: stable/ocata

commit f69a336501ba1533ee568cbc83d06fadf7441dbc
Author: Dave Wilde <email address hidden>
Date: Tue Jul 17 14:07:41 2018 -0500

    Update get-pip to version 3.3

    Version 3.2 has a bug with it on some systems that can result in the
    following stacktrace: [ http://paste.openstack.org/show/726064 ]. To
    correct this issue the version of the get-pip script has been set to 3.3
    which does not suffer from the same issue.

    Change-Id: I61a7234dc4fbde1b9319874d82fe33578f490abc
    Partial-Bug: 1779534
    (cherry picked from commit 184dbb8e18973a8baf69d203c0b159367cb1ff8e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/queens)

Reviewed: https://review.openstack.org/584095
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=44c98893b48693d17231842e33336e6575bd4a31
Submitter: Zuul
Branch: stable/queens

commit 44c98893b48693d17231842e33336e6575bd4a31
Author: Dave Wilde <email address hidden>
Date: Tue Jul 17 14:07:41 2018 -0500

    Update get-pip to version 3.3

    Version 3.2 has a bug with it on some systems that can result in the
    following stacktrace: [ http://paste.openstack.org/show/726064 ]. To
    correct this issue the version of the get-pip script has been set to 3.3
    which does not suffer from the same issue.

    Change-Id: I61a7234dc4fbde1b9319874d82fe33578f490abc
    Partial-Bug: 1779534
    (cherry picked from commit 184dbb8e18973a8baf69d203c0b159367cb1ff8e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 16.0.16

This issue was fixed in the openstack/openstack-ansible 16.0.16 release.

Revision history for this message
Ondrej Vasko (ondrej.vasko) wrote : [Autoreply] [Bug 1779534] Fix included in openstack/openstack-ansible 16.0.16

Dobrý deň,
ďakujem za Váš e-mail, momentálne som mimo kancelárie. Vrátim sa
dňa 01.08.2018. V prípade potreby sa neváhajte obrátiť na VNET
Zákaznícku linku 0800 24 24 24 alebo nás kontaktujte e-mailom na
<email address hidden>.

Thank you for your message.
I am currently out of the office. I will be returning on 01.08.2018.
If you need any assistance before then, you may contact VNET Technical
support 0800 24 24 24 / +421 2 2129 0290 from abroad or you can send
us e-mail <email address hidden>.

This issue was fixed in the openstack/openstack-ansible 16.0.16 release.

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1779534

Title:
  pip install offline fails with new version of get-pip.py

Status in openstack-ansible:
  Fix Released

Bug description:
  Task `pip cache install files locally` [1] fails with new (default)
  version of get-pip.py [2].

  The command is executed currently as:

  python /tmp/get-pip.py -d /tmp/pip_install --constraint /opt/global-
  requirement-pins.txt --constraint
  https://git.openstack.org/cgit/openstack/requirements/plain/upper-
  constraints.txt?id=23a4a4b5c9b17a31a367edbd2e28954e8d9bb231 pip
  setuptools wheel

  But new version of pip does not support argument `-d`, so it fails
  with error `no such option: -d`.

  Problem is that get-pip.py does not support new command download. I
  tried to use new syntax with command below and it doesn't work. It
  looks like this must be implemented upstream.

  python /tmp/get-pip.py download --root /tmp/pip_install --constraint
  https://git.openstack.org/cgit/openstack/requirements/plain/upper-
  constraints.txt\?id\=23a4a4b5c9b17a31a367edbd2e28954e8d9bb231 pip
  setuptools wheel

  As a workaround people may still use older version from URL
  https://bootstrap.pypa.io/3.2/get-pip.py. You will however need to
  override parameter:

  pip_upstream_url: https://bootstrap.pypa.io/3.2/get-pip.py

  This should concern all OSA versions and operating systems.

  [1] https://github.com/openstack/openstack-ansible-pip_install/blob/master/tasks/install_offline.yml#L66
  [2] https://bootstrap.pypa.io/get-pip.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/openstack-ansible/+bug/1779534/+subscriptions

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 15.1.24

This issue was fixed in the openstack/openstack-ansible 15.1.24 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 18.0.0.0b3

This issue was fixed in the openstack/openstack-ansible 18.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-pip_install ocata-em

This issue was fixed in the openstack/openstack-ansible-pip_install ocata-em release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-pip_install 16.0.29

This issue was fixed in the openstack/openstack-ansible-pip_install 16.0.29 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-pip_install queens-eol

This issue was fixed in the openstack/openstack-ansible-pip_install queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-pip_install rocky-eol

This issue was fixed in the openstack/openstack-ansible-pip_install rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-repo_build rocky-eol

This issue was fixed in the openstack/openstack-ansible-repo_build rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-pip_install stein-eol

This issue was fixed in the openstack/openstack-ansible-pip_install stein-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-repo_build stein-eol

This issue was fixed in the openstack/openstack-ansible-repo_build stein-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-pip_install train-eol

This issue was fixed in the openstack/openstack-ansible-pip_install train-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-repo_build train-eol

This issue was fixed in the openstack/openstack-ansible-repo_build train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.