Horizon health check fails when developer panels enabled

[Stuart Grace]

The ServerName in Apache's openstack_dashboard.conf is being set to the Horizon container name with no suffix. When developer panels and debug are enabled, the http health checks from haproxy fail and Horizon logs this error:

Invalid HTTP_HOST header: u'infra3_horizon_container-7eec7066:80'. The domain name provided is not valid according to RFC 1034/1035

Haproxy httpchk uses HTTP/1.0 with no Host: header, so the ServerName setting in Apache config gets used for the host name. This needs to be an FQDN or an IP address.

A similar problem was fixed in 2016 here: https://review.openstack.org/#/c/350955/

Workaround:

  horizon_server_name: "{{ ansible_fqdn }}"

This sets ServerName to {{container_name}}.openstack.local which is accepted as valid.

Making this the default for horizon_server_name could be a fix?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/578151

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mohammed Naser (<email address hidden>) on branch: master
Review: https://review.openstack.org/578151

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/578348

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/578348
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_horizon/commit/?id=252ac6af5cca8083bea7220257bc436ea8c57ca4
Submitter: Zuul
Branch: master

commit 252ac6af5cca8083bea7220257bc436ea8c57ca4
Author: Stuart Grace <email address hidden>
Date: Wed Jun 27 11:11:20 2018 +0100

    Change default horizon_server_name to ansible_fqdn

    horizon_server_name setting in apache config file must be a FQDN
    otherwise when debug mode is enabled, HTTP requests without a
    host: header (such as haproxy health checks) fail with a message
    about invaid domain name.

    Change-Id: I8672593019e4cc5cf6144c40359ecb9d64bc9224
    Closes-Bug: #1778085

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon stein-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon yoga-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon victoria-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon xena-eom release.