Glance NFS client not working in Pike

[Bjoern]

I have noticed several issues with the os_glance role since Pike, were glance_nfs_client configuration are not working due do several errors including but not limited:

Issues during container boot:

May 28 01:34:55 infra01-glance-container-3b74d2fb systemd[1]: Configuration file /etc/systemd/system/var-lib-glance-images.mount is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.

May 29 14:29:06infra01-glance-container-3b74d2fb systemd[1]: run-rpc_pipefs.mount: Mount process exited, code=exited status=32

Issues within the var-lib-glance-images.mount, not fully defining the dependency towards NFS and glance-api:

- Unit config not dependent on rpcbind
- Unit config not dependent on rpc-statd
- No hint that service is needed before glance-api

Issues with local bind mount config, over mounting NFS:

lxc.mount.entry = /openstack/infra01-glance-container-3b74d2fb var/lib/glance/images none bind,create=dir 0 0

The latter issue may be related due to a situation that NFS was configured after the initial setup but the role should be smart enough to remove such mount entries when NFS is configured.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/573247

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/573259

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/573375

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kevin Carter (cloudnull) (<email address hidden>) on branch: master
Review: https://review.openstack.org/573247
Reason: I've added these changes into the glance role update to use the common systemd roles which can be found here: https://review.openstack.org/#/c/552185/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/574806

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/574806
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_glance/commit/?id=971403b6d99161329d2f1ac71e416c566a9cce6e
Submitter: Zuul
Branch: stable/queens

commit 971403b6d99161329d2f1ac71e416c566a9cce6e
Author: Bjoern Teipel <email address hidden>
Date: Thu Jun 7 09:03:51 2018 -0500

    Adding systemd dependencies for NFS mounts

    The mount service is dependent on successful starts of
    the rpcbind and rpc-statd services and to prevent race conditions
    during systemd target.
    Proper unit configuration ensures that the mount is completed
    before the glance-api service

    Change-Id: I6744f01e0648607652d6bb497c8206d37522deac
    Closes-Bug: #1774037

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/573259
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_hosts/commit/?id=57eb57419df43cab9b0c44bd8093a9529ce186ab
Submitter: Zuul
Branch: master

commit 57eb57419df43cab9b0c44bd8093a9529ce186ab
Author: Bjoern Teipel <email address hidden>
Date: Tue May 29 13:44:44 2018 -0500

    Adding rpc_pipefs for lxc-openstack aa profile

    The RPC pipefs is needed for NFS kernel/userspace
    interaction and need to be added to the LXC profile.
    This is important for containers like glance-api who
    can mount NFS onto `/var/lib/glance/images`.

    Change-Id: Ib1a697ad9a63dd1f7be66321291882ffab82255a
    Closes-Bug: #1774037

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552185
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_glance/commit/?id=659e3278d06f72605eb0c7092221db7a2152e93b
Submitter: Zuul
Branch: master

commit 659e3278d06f72605eb0c7092221db7a2152e93b
Author: Kevin Carter <email address hidden>
Date: Mon Mar 12 18:59:42 2018 -0500

    Convert role to use a common systemd mount role

    The systemd unit files are being converted to use common roles to reduce
    code sprawl throughout the playbooks. This change allows us to use a
    common systemd_mount role as an include which will give us a consistent
    experience when deploying services and setting up their resournces on
    OS's that uses systemd.

    Closes-Bug: #1774037
    Change-Id: I11d083788cd388dab0695878193ab18af1b5038b
    Signed-off-by: Kevin Carter <email address hidden>

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bjoern Teipel (<email address hidden>) on branch: master
Review: https://review.opendev.org/573375

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_glance queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_glance rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts stein-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_glance stein-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_glance train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_glance ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts yoga-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_glance yoga-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts victoria-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_glance victoria-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_glance wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts xena-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_glance xena-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts zed-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_glance zed-eom release.