No need to restart rabbitmq if there is no version upgrade

Bug #1766636 reported by Albert Mikaelyan on 2018-04-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-ansible
High
Albert Mikaelyan

Bug Description

According to minor version upgrade guide: https://docs.openstack.org/openstack-ansible/latest/admin/upgrades/minor-updates.html

You should include "rabbitmq_upgrade=true" to setup-infrastructure run (nowhere it says that it's not required).
However, even if user does include this flag, there is no reason to do anything if the version equals to the upgrade version. Unfortunately, it still does stop/start to the service, even if no version upgrade was needed:

See the following include:
https://github.com/openstack/openstack-ansible-rabbitmq_server/blob/stable/ocata/tasks/rabbitmq_upgrade_check.yml#L68

Which results in including this:
https://github.com/openstack/openstack-ansible-rabbitmq_server/blob/stable/ocata/tasks/rabbitmq_upgrade_prep.yml#L26

This results in unnecessary downtime of openstack services. I don't think we need to restart rabbit if there is no version change, even if "rabbitmq_upgrade=true" flag is set.

Changed in openstack-ansible:
status: New → Confirmed
importance: Undecided → High

Fix proposed to branch: master
Review: https://review.openstack.org/565940

Changed in openstack-ansible:
assignee: nobody → Kevin Carter (kevin-carter)
status: Confirmed → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/566017

Changed in openstack-ansible:
assignee: Kevin Carter (kevin-carter) → Albert Mikaelyan (tahvok)

Reviewed: https://review.openstack.org/566017
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=c78e0b1d026ff34a53143fb897df0fdc8c5f8342
Submitter: Zuul
Branch: master

commit c78e0b1d026ff34a53143fb897df0fdc8c5f8342
Author: Albert Mikaelyan <email address hidden>
Date: Thu May 3 13:03:38 2018 +0300

    Do not restart rabbitmq when no version is changed

    If rabbitmq version in the role equals to already installed version
    there is no reason to stop/start rabbitmq and cause a downtime.

    Change-Id: I523be647b5e82e6f088428bf2db24dc4cd2cfb53
    Closes-Bug: 1766636

Changed in openstack-ansible:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/566116
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=bfd11dbb89ce1428a4dc85b64f5df154157b06ab
Submitter: Zuul
Branch: stable/queens

commit bfd11dbb89ce1428a4dc85b64f5df154157b06ab
Author: Albert Mikaelyan <email address hidden>
Date: Thu May 3 13:03:38 2018 +0300

    Do not restart rabbitmq when no version is changed

    If rabbitmq version in the role equals to already installed version
    there is no reason to stop/start rabbitmq and cause a downtime.

    Change-Id: I523be647b5e82e6f088428bf2db24dc4cd2cfb53
    Closes-Bug: 1766636
    (cherry picked from commit c78e0b1d026ff34a53143fb897df0fdc8c5f8342)

tags: added: in-stable-queens
Albert Mikaelyan (tahvok) wrote :

Problem found with the latest fix, as the version needs to be always checked, even when running rabbitmq_upgrade

Changed in openstack-ansible:
status: Fix Released → Confirmed

Fix proposed to branch: master
Review: https://review.openstack.org/566243

Changed in openstack-ansible:
status: Confirmed → In Progress

Change abandoned by Albert Mikaelyan (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/566121

Change abandoned by Albert Mikaelyan (<email address hidden>) on branch: master
Review: https://review.openstack.org/566269
Reason: Going to work on different approach here

Change abandoned by Albert Mikaelyan (<email address hidden>) on branch: master
Review: https://review.openstack.org/566243

Change abandoned by Albert Mikaelyan (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/566119

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers