No need to restart rabbitmq if there is no version upgrade

[Albert Mikaelyan]

According to minor version upgrade guide: https://docs.openstack.org/openstack-ansible/latest/admin/upgrades/minor-updates.html

You should include "rabbitmq_upgrade=true" to setup-infrastructure run (nowhere it says that it's not required).
However, even if user does include this flag, there is no reason to do anything if the version equals to the upgrade version. Unfortunately, it still does stop/start to the service, even if no version upgrade was needed:

See the following include:
https://github.com/openstack/openstack-ansible-rabbitmq_server/blob/stable/ocata/tasks/rabbitmq_upgrade_check.yml#L68

Which results in including this:
https://github.com/openstack/openstack-ansible-rabbitmq_server/blob/stable/ocata/tasks/rabbitmq_upgrade_prep.yml#L26

This results in unnecessary downtime of openstack services. I don't think we need to restart rabbit if there is no version change, even if "rabbitmq_upgrade=true" flag is set.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/565940

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/566017

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/566017
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=c78e0b1d026ff34a53143fb897df0fdc8c5f8342
Submitter: Zuul
Branch: master

commit c78e0b1d026ff34a53143fb897df0fdc8c5f8342
Author: Albert Mikaelyan <email address hidden>
Date: Thu May 3 13:03:38 2018 +0300

    Do not restart rabbitmq when no version is changed

    If rabbitmq version in the role equals to already installed version
    there is no reason to stop/start rabbitmq and cause a downtime.

    Change-Id: I523be647b5e82e6f088428bf2db24dc4cd2cfb53
    Closes-Bug: 1766636

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/566116

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/566119

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/566121

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/566116
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=bfd11dbb89ce1428a4dc85b64f5df154157b06ab
Submitter: Zuul
Branch: stable/queens

commit bfd11dbb89ce1428a4dc85b64f5df154157b06ab
Author: Albert Mikaelyan <email address hidden>
Date: Thu May 3 13:03:38 2018 +0300

    Do not restart rabbitmq when no version is changed

    If rabbitmq version in the role equals to already installed version
    there is no reason to stop/start rabbitmq and cause a downtime.

    Change-Id: I523be647b5e82e6f088428bf2db24dc4cd2cfb53
    Closes-Bug: 1766636
    (cherry picked from commit c78e0b1d026ff34a53143fb897df0fdc8c5f8342)

[Albert Mikaelyan (tahvok)]

Problem found with the latest fix, as the version needs to be always checked, even when running rabbitmq_upgrade

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/566243

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/566269

[OpenStack Infra (hudson-openstack)]

Change abandoned by Albert Mikaelyan (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/566121

[OpenStack Infra (hudson-openstack)]

Change abandoned by Albert Mikaelyan (<email address hidden>) on branch: master
Review: https://review.openstack.org/566269
Reason: Going to work on different approach here

[OpenStack Infra (hudson-openstack)]

Change abandoned by Albert Mikaelyan (<email address hidden>) on branch: master
Review: https://review.openstack.org/566243

[OpenStack Infra (hudson-openstack)]

Change abandoned by Albert Mikaelyan (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/566119

[Dmitriy Rabotyagov (noonedeadpunk)]

Tbh I can't agree that there's no reason in doing anything when rabbitmq_upgrade is true, but the version is the same. As I really use that flag when I want to re-configure rabbit (ie re-create queues and etc), and this flag works like a magic when rabbit is stuck. So I'd rather either won't touch behaviour of upgrade flag or create another one which would dublicate that behaviour.
And there's no downtime of openstack services, because we use HA queues for rabbit, so we have only single server down, while 2 others continue operations. So no downtime when running with that flag is expected.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server stein-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server yoga-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server victoria-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server xena-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-rabbitmq_server zed-eom release.