Wrong version of pip is used in venvs

Bug #1764470 reported by Bryce Nordgren
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
High
Jesse Pretorius

Bug Description

The version of pip bundled with get-pip is now 10.0.0. Note that when running the failing command manually below, it finds that the pip version is satisfied by the bundled version in /tmp/... and does not install it in the venv.

root@control1-repo-container-e2e07242:/tmp/openstack-venv-builder/venvs# /tmp/openstack-venv-builder/venvs/keystone/bin/python /var/www/repo/os-releases/17.0.0/ubuntu-16.04-x86_64/get-pip.py pip setuptools wheel --find-links /var/www/repo/os-releases/17.0.0/ubuntu-16.04-x86_64 --timeout 120 --find-links /var/www/repo/os-releases/17.0.0/ubuntu-16.04-x86_64
Looking in links: /var/www/repo/os-releases/17.0.0/ubuntu-16.04-x86_64, /var/www/repo/os-releases/17.0.0/ubuntu-16.04-x86_64
Requirement already up-to-date: pip in /tmp/tmpK2Y9gw/pip.zip (10.0.0)
Requirement already up-to-date: setuptools in ./keystone/lib/python2.7/site-packages (39.0.1)
Requirement already up-to-date: wheel in ./keystone/lib/python2.7/site-packages (0.31.0)

The ansible scripts (at tag 17.0.1) have a different error which I exploited to workaround this. While the scripts always download the current version to /opt/get-pip.py, this file is not copied to /var/www/repos/os-releases/17.0.0/ubuntu-16.04-x86-64. I manually downloaded an old version of get-pip.py into the "/var/www/..." directory and the ansible scripts completed successfully.

Also notice a third bug in this report. I am at tag 17.0.1, and it is building repos in the 17.0.0 directory.

description: updated
Revision history for this message
Jean-Philippe Evrard (jean-philippe-evrard) wrote :

Could you try again with 17.0.2? All those issues should be fixed.

Revision history for this message
Jean-Philippe Evrard (jean-philippe-evrard) wrote :

Also, could you show on which task this issue appeared? A log would do the trick.

Revision history for this message
Jesse Pretorius (jesse-pretorius) wrote :

The get-pip.py script should be copied in this task: https://github.com/openstack/openstack-ansible-repo_build/blob/stable/queens/tasks/repo_build_wheels.yml#L123

The installation of pip/setuptools/wheel should be constrained but looking at the template of the script that does the build and the options used, it's plausible that it could be pulling something else in. Let me try to verify that.

The folder used is based on the openstack_release which wasn't set correctly for 17.0.1. This is resolved in 17.0.2.

Changed in openstack-ansible:
assignee: nobody → Jesse Pretorius (jesse-pretorius)
Revision history for this message
Jesse Pretorius (jesse-pretorius) wrote :

OK, I've confirmed that the wrong version of pip/setuptools/wheel is installed into the venvs and will work on a patch shortly.

summary: - upgraded get-pip does not install pip in venvs in repo container
+ Wrong version of pip is used in venvs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-repo_build (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562017

Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562020

Changed in openstack-ansible:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-role-python_venv_build (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562033

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562157

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_aodh (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562158

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_barbican (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562161

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562163

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562164

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_cloudkitty (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562165

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562167

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562168

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_gnocchi (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562171

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562173

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562176

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562177

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562179

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_molteniron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562180

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562183

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562184

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_octavia (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562185

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_panko (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562190

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_rally (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562191

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562195

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_searchlight (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562196

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562197

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_tacker (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562199

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562200

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562201

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_watcher (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562202

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_zaqar (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562203

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_monasca (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562206

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_monasca-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/562208

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_molteniron (master)

Reviewed: https://review.openstack.org/562180
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_molteniron/commit/?id=0dae54128d45e7be3f1a823cdd8080e7ff536c78
Submitter: Zuul
Branch: master

commit 0dae54128d45e7be3f1a823cdd8080e7ff536c78
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:46:05 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Icc757ac36b298e46c0f257cd8304ac8553b85ee3
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_keystone (master)

Reviewed: https://review.openstack.org/562020
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_keystone/commit/?id=4d92214d6b0ae93f0fd28d67783d7bf25d5d3234
Submitter: Zuul
Branch: master

commit 4d92214d6b0ae93f0fd28d67783d7bf25d5d3234
Author: Jesse Pretorius <email address hidden>
Date: Tue Apr 17 19:25:22 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I0f0751a11dffbd77eaf2bfd238f2f934f11847c8
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_octavia (master)

Reviewed: https://review.openstack.org/562185
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_octavia/commit/?id=23b68a02919b114c261dfa2571c01e33ee30dc3e
Submitter: Zuul
Branch: master

commit 23b68a02919b114c261dfa2571c01e33ee30dc3e
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:51:27 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: If553ad33bd071792198239bc567c2e06058ebddd
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-repo_build (master)

Reviewed: https://review.openstack.org/562017
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-repo_build/commit/?id=30ac05c5b02dcf4fa2350cf52298c7ca312fb342
Submitter: Zuul
Branch: master

commit 30ac05c5b02dcf4fa2350cf52298c7ca312fb342
Author: Jesse Pretorius <email address hidden>
Date: Tue Apr 17 19:12:22 2018 +0100

    Constrain the pip/setuptools/wheel versions in the venvs

    The installation of these packages are currently not constrained,
    resulting in inconsistent experiences at deploy time.

    This patch ensures that the venv preparation process properly
    constrains the installation so that results are consistent.

    Change-Id: I744e43d8a1b85d5bdaf7019a6420a39222911330
    Partial-Bug: #1764470

tags: added: in-stable-queens
54 comments hidden view all 134 comments
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_magnum (stable/queens)

Reviewed: https://review.openstack.org/562673
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_magnum/commit/?id=9a13e5c100f3a80432239b734e7d8598c47c3a60
Submitter: Zuul
Branch: stable/queens

commit 9a13e5c100f3a80432239b734e7d8598c47c3a60
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:45:01 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Ie71d42836014c2354e252389cc14e52a06b6f062
    Partial-Bug: #1764470
    (cherry picked from commit 71a7b842472c3333e3736b00e98dfe81bf778a87)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_tempest (master)

Reviewed: https://review.openstack.org/562200
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_tempest/commit/?id=ce9d7ae0b31833037d21c79cf61d60970ba35bcb
Submitter: Zuul
Branch: master

commit ce9d7ae0b31833037d21c79cf61d60970ba35bcb
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:03:46 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Icf39a1b5057e998d92923026a587ee3fdcb37c13
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_nova (stable/queens)

Reviewed: https://review.openstack.org/562709
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=3307d4694bcef4f7e94949d89b75d1d8e4b9dff6
Submitter: Zuul
Branch: stable/queens

commit 3307d4694bcef4f7e94949d89b75d1d8e4b9dff6
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:50:16 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I5f7e8fd36185537543d0741d88a5ccc9cd1f1645
    Partial-Bug: #1764470
    (cherry picked from commit a686b93020ee8ab6dae364864dcb45ffb7255307)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_tempest (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/563148

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_octavia (stable/queens)

Reviewed: https://review.openstack.org/562710
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_octavia/commit/?id=2c462c7424ae8b1bfb7c9b0e8748b13428ab9918
Submitter: Zuul
Branch: stable/queens

commit 2c462c7424ae8b1bfb7c9b0e8748b13428ab9918
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:51:27 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: If553ad33bd071792198239bc567c2e06058ebddd
    Partial-Bug: #1764470
    (cherry picked from commit 23b68a02919b114c261dfa2571c01e33ee30dc3e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_molteniron (stable/queens)

Reviewed: https://review.openstack.org/562717
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_molteniron/commit/?id=4d5d83d4905dc9e285154e15e6cb129446343dac
Submitter: Zuul
Branch: stable/queens

commit 4d5d83d4905dc9e285154e15e6cb129446343dac
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:46:05 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Icc757ac36b298e46c0f257cd8304ac8553b85ee3
    Partial-Bug: #1764470
    (cherry picked from commit 0dae54128d45e7be3f1a823cdd8080e7ff536c78)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_ceilometer (stable/queens)

Reviewed: https://review.openstack.org/562675
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ceilometer/commit/?id=828218215b75ba378cd255d29367494d24a70135
Submitter: Zuul
Branch: stable/queens

commit 828218215b75ba378cd255d29367494d24a70135
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:25:48 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I3c589dd4c105bb247f06479d3881ffd68e699224
    Partial-Bug: #1764470
    (cherry picked from commit 07d9cc32bed99f4f7613d5f7f296f9c4a60313ed)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_panko (stable/queens)

Reviewed: https://review.openstack.org/562720
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_panko/commit/?id=6c3790d9d51baf7fc38d39e82d8e03c8ded17e29
Submitter: Zuul
Branch: stable/queens

commit 6c3790d9d51baf7fc38d39e82d8e03c8ded17e29
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:53:23 2018 +0100

    Replace virtualenv-tools with a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I8b40b4bceaf90fadecb4512c0cb9dbee143fe987
    Partial-Bug: #1741634
    Partial-Bug: #1764470
    (cherry picked from commit 3a254e3582f9b9238fe5f6246c5e5c93ade92bbf)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_trove (master)

Reviewed: https://review.openstack.org/562201
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_trove/commit/?id=365cbc29b1ccfaa8aa6ef12f782795f201aa8062
Submitter: Zuul
Branch: master

commit 365cbc29b1ccfaa8aa6ef12f782795f201aa8062
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:04:29 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I59a70585a2bfe4916b3df8eb627f6f6a4b1ef19b
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_horizon (master)

Reviewed: https://review.openstack.org/562176
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_horizon/commit/?id=1085b03ec5e56f1ad1b75fd0db3c618272b217fa
Submitter: Zuul
Branch: master

commit 1085b03ec5e56f1ad1b75fd0db3c618272b217fa
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:42:39 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Ic69473a9723df59d0a3a93fb3a8209d59fe1c6b6
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_ironic (stable/queens)

Reviewed: https://review.openstack.org/562674
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ironic/commit/?id=f5177470588f166d6bbe6847a69bdfc8ecdf923a
Submitter: Zuul
Branch: stable/queens

commit f5177470588f166d6bbe6847a69bdfc8ecdf923a
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:43:41 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I34958aa7c965a161b7699115d5602b94dc68beac
    Partial-Bug: #1764470
    (cherry picked from commit 90a92f5eca7a186d35b2c6f1ab7c334f55e605a1)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_keystone (stable/queens)

Reviewed: https://review.openstack.org/562711
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_keystone/commit/?id=be874224aa1521949b7cc9e57340f647c9881707
Submitter: Zuul
Branch: stable/queens

commit be874224aa1521949b7cc9e57340f647c9881707
Author: Jesse Pretorius <email address hidden>
Date: Tue Apr 17 19:25:22 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I0f0751a11dffbd77eaf2bfd238f2f934f11847c8
    Partial-Bug: #1764470
    (cherry picked from commit 4d92214d6b0ae93f0fd28d67783d7bf25d5d3234)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_swift (stable/queens)

Reviewed: https://review.openstack.org/562798
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_swift/commit/?id=e4e2f380eccabc68ef93fbaf144ee9862df2d498
Submitter: Zuul
Branch: stable/queens

commit e4e2f380eccabc68ef93fbaf144ee9862df2d498
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:02:08 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I05d9ee40e596afcc35559b53f6a773521b1d1534
    Partial-Bug: #1764470
    (cherry picked from commit 1a789263bd15a44a4e9774ee5dd57b634e4e3676)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_trove (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/563306

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_horizon (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/563307

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_aodh (stable/queens)

Reviewed: https://review.openstack.org/562972
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_aodh/commit/?id=e75bf460a7ef5070cffd7dcd28c818151d28e0ee
Submitter: Zuul
Branch: stable/queens

commit e75bf460a7ef5070cffd7dcd28c818151d28e0ee
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:20:59 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I982e042c472693ba73702b9be15438c1a0c045c2
    Partial-Bug: #1764470
    (cherry picked from commit 1c10d38b6d3d725b68f61f3c695b7e2051c541e8)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_watcher (master)

Reviewed: https://review.openstack.org/562202
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_watcher/commit/?id=1f606ff46173bd04990891b2d833b1443d6e04a7
Submitter: Zuul
Branch: master

commit 1f606ff46173bd04990891b2d833b1443d6e04a7
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:05:20 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I9205f5f3183eff8059e7589b6a3a2bbf36f8b60a
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_horizon (stable/queens)

Reviewed: https://review.openstack.org/563307
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_horizon/commit/?id=8f5a4228145ebdb7a2b0d235602a34febd6dff8a
Submitter: Zuul
Branch: stable/queens

commit 8f5a4228145ebdb7a2b0d235602a34febd6dff8a
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:42:39 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Ic69473a9723df59d0a3a93fb3a8209d59fe1c6b6
    Partial-Bug: #1764470
    (cherry picked from commit 1085b03ec5e56f1ad1b75fd0db3c618272b217fa)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_watcher (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/563515

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_congress (master)

Reviewed: https://review.openstack.org/562167
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_congress/commit/?id=e24db20c91044664658bde27f8d62c0860e497d6
Submitter: Zuul
Branch: master

commit e24db20c91044664658bde27f8d62c0860e497d6
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:29:37 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Ie26f236c0d1d433e0bb69da4fcb251a4e40a5615
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_congress (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/563656

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_zaqar (master)

Reviewed: https://review.openstack.org/562203
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_zaqar/commit/?id=da4ea69eb2de6025822c60f8678404f79126f8f4
Submitter: Zuul
Branch: master

commit da4ea69eb2de6025822c60f8678404f79126f8f4
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:06:06 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I8772e90fa3ff2653836870921ee0e182150715e4
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_zaqar (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/563981

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_monasca (master)

Reviewed: https://review.openstack.org/562206
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_monasca/commit/?id=cac7008e57e701a9f8fed5fe5ad4d3d68b9c98bd
Submitter: Zuul
Branch: master

commit cac7008e57e701a9f8fed5fe5ad4d3d68b9c98bd
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:08:23 2018 +0100

    Replace virtualenv-tools with a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I62ae0b1f406f102fcb184913c5a6de54bb84c4c2
    Partial-Bug: #1741634
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_monasca (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/564052

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/564489

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/queens)

Reviewed: https://review.openstack.org/564489
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=72c8be49071ae7ff09d0a5c0315429df2ecfde87
Submitter: Zuul
Branch: stable/queens

commit 72c8be49071ae7ff09d0a5c0315429df2ecfde87
Author: Jesse Pretorius <email address hidden>
Date: Thu Apr 26 13:47:03 2018 +0100

    Update role SHA's to resolve pip/python venv issues

    With the release of pip10 and the use of python3 as the
    default for the deploy host there were a bunch of patches
    needed across all roles to ensure that the pinned versions
    of pip/setuptools/wheel were actually being used for hosts,
    containers and virtualenvs.

    This patch updates the role SHA's to ensure that all these
    fixes are brought in for the next release.

    Closes-Bug: #1764470
    Change-Id: I5552fe62a9567f43c9f7c958cc30fe7ddfc16d92

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_congress (stable/queens)

Reviewed: https://review.openstack.org/563656
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_congress/commit/?id=a8a023264eb14188bcf84dd1703a85519a9b6d77
Submitter: Zuul
Branch: stable/queens

commit a8a023264eb14188bcf84dd1703a85519a9b6d77
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:29:37 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Ie26f236c0d1d433e0bb69da4fcb251a4e40a5615
    Partial-Bug: #1764470
    (cherry picked from commit e24db20c91044664658bde27f8d62c0860e497d6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_monasca (stable/queens)

Reviewed: https://review.openstack.org/564052
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_monasca/commit/?id=9b4bfa1a2c02fde89feb01fd3a113ec83c3c3c67
Submitter: Zuul
Branch: stable/queens

commit 9b4bfa1a2c02fde89feb01fd3a113ec83c3c3c67
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:08:23 2018 +0100

    Replace virtualenv-tools with a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I62ae0b1f406f102fcb184913c5a6de54bb84c4c2
    Partial-Bug: #1741634
    Partial-Bug: #1764470
    (cherry picked from commit cac7008e57e701a9f8fed5fe5ad4d3d68b9c98bd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_zaqar (stable/queens)

Reviewed: https://review.openstack.org/563981
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_zaqar/commit/?id=743d97c71cbac2160ba58e7f9bfa4e0b58013abb
Submitter: Zuul
Branch: stable/queens

commit 743d97c71cbac2160ba58e7f9bfa4e0b58013abb
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:06:06 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I8772e90fa3ff2653836870921ee0e182150715e4
    Partial-Bug: #1764470
    (cherry picked from commit da4ea69eb2de6025822c60f8678404f79126f8f4)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_trove (stable/queens)

Reviewed: https://review.openstack.org/563306
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_trove/commit/?id=9d486a964754fa04ba8a2ea499aab3da956f31e7
Submitter: Zuul
Branch: stable/queens

commit 9d486a964754fa04ba8a2ea499aab3da956f31e7
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:04:29 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I59a70585a2bfe4916b3df8eb627f6f6a4b1ef19b
    Partial-Bug: #1764470
    (cherry picked from commit 365cbc29b1ccfaa8aa6ef12f782795f201aa8062)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 17.0.3

This issue was fixed in the openstack/openstack-ansible 17.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_tempest (stable/queens)

Reviewed: https://review.openstack.org/563148
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_tempest/commit/?id=19dfb8a8bfba2e192f703dab839913a2faa3671c
Submitter: Zuul
Branch: stable/queens

commit 19dfb8a8bfba2e192f703dab839913a2faa3671c
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:03:46 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Icf39a1b5057e998d92923026a587ee3fdcb37c13
    Partial-Bug: #1764470
    (cherry picked from commit ce9d7ae0b31833037d21c79cf61d60970ba35bcb)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_cloudkitty (master)

Reviewed: https://review.openstack.org/562165
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_cloudkitty/commit/?id=94b71a3b0a7a57e3f86915a40dee0c6fd4715ccc
Submitter: Zuul
Branch: master

commit 94b71a3b0a7a57e3f86915a40dee0c6fd4715ccc
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:28:46 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Id29497b36cd2b9cca3f3b08474e1001d528931b6
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_cloudkitty (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/565477

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_masakari (master)

Fix proposed to branch: master
Review: https://review.openstack.org/566015

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_masakari (master)

Reviewed: https://review.openstack.org/566015
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_masakari/commit/?id=e86fe0c26b776853aa78a72c70c67c423e1a8af5
Submitter: Zuul
Branch: master

commit e86fe0c26b776853aa78a72c70c67c423e1a8af5
Author: Jesse Pretorius <email address hidden>
Date: Thu May 3 10:50:20 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Ic03405a6f07ca16201cc1e35aea2cde2f298d4cd
    Partial-Bug: #1764470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_cloudkitty (stable/queens)

Reviewed: https://review.openstack.org/565477
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_cloudkitty/commit/?id=ea22f08dc0c8dfcb86ff16513fa9531814d61fce
Submitter: Zuul
Branch: stable/queens

commit ea22f08dc0c8dfcb86ff16513fa9531814d61fce
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:28:46 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: Id29497b36cd2b9cca3f3b08474e1001d528931b6
    Partial-Bug: #1764470
    (cherry picked from commit 94b71a3b0a7a57e3f86915a40dee0c6fd4715ccc)

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_searchlight (stable/queens)

Reviewed: https://review.openstack.org/562676
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_searchlight/commit/?id=ff60d12358e7a6091a7582917ef5523d1e334015
Submitter: Zuul
Branch: stable/queens

commit ff60d12358e7a6091a7582917ef5523d1e334015
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:01:24 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I39e64f29e794075ef303d3e1a2c0c1a6a18937b6
    Partial-Bug: #1764470
    (cherry picked from commit a9561bbce96a0dc545f18aaa88be0988be2ac3ad)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_watcher (stable/queens)

Reviewed: https://review.openstack.org/563515
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_watcher/commit/?id=7db164e27493f2c82378f833166208cbea615a4c
Submitter: Zuul
Branch: stable/queens

commit 7db164e27493f2c82378f833166208cbea615a4c
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:05:20 2018 +0100

    Only replace python when re-initializing the venv

    We reinitialize the venv to ensure that the right version of
    python is in the venv, but we do not want virtualenv to also
    replace pip, setuptools and wheel so we tell it not to. If we
    don't do this then virtualenv will install the latest available
    version, which is not what we want.

    Change-Id: I9205f5f3183eff8059e7589b6a3a2bbf36f8b60a
    Partial-Bug: #1764470
    (cherry picked from commit 1f606ff46173bd04990891b2d833b1443d6e04a7)

Displaying first 40 and last 40 comments. View all 134 comments or add a comment.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.