Gate jobs don't cover Glance image upload to non-NFS file store

[Florian Haas]

Bug 1759552 uncovered a regression that the gate jobs did not catch: a prior change to the Glance role broke image upload to a file store-backed Glance API, on account of incorrect ownership of the /var/lib/glance/images directory.

Subsequent discussion on IRC revealed that while there is a gate job for Swift-backed Glance, and one for file-backed Glance that uses an NFS mount, there is no such thing for file-backed Glance without NFS.

Relevant messages from IRC below, for reference:

(13:55:04) ***fghaas is just lurking here in case someone needs more info on https://bugs.launchpad.net/openstack-ansible/+bug/1759552 which he filed a few minutes ago
(14:22:43) evrardjp[m]: niraj_singh: we can start with simple http testing for api.
(14:23:26) evrardjp[m]: fghaas: i will have a look later today :)
(14:24:37) evrardjp[m]: that look serious.
(14:24:54) evrardjp[m]: weird that we haven't caught that.
(14:25:15) evrardjp[m]: will have a look later.
(17:32:16) cloudnull: we have nfs tests in the gate which replicate the nfs use case and so long as they continue to pass I'm +2
(17:33:49) logan-: how do we not hit fghaas issue in the integrated gate? glance is using file backend there right?
(17:34:15) fghaas: does the gate job actually upload an image?
(17:34:28) cloudnull: logan-: the integrated gate uses swift
(17:34:31) logan-: ahhh ok
(17:51:10) evrardjp: between what's happening in gates and what's happening in deploys, could you point that somewhere? Like in a bug?
(17:51:15) evrardjp: We should not hide things.
(18:08:09) fghaas: evrardjp, sure, I can file one for that

[Jean-Philippe Evrard (jean-philippe-evrard)]

Please see our bug triage conversation for the reason of this classification.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/551791
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=ada265c8449334538a011300785634774787d54d
Submitter: Zuul
Branch: master

commit ada265c8449334538a011300785634774787d54d
Author: Jesse Pretorius <email address hidden>
Date: Wed Nov 21 14:29:01 2018 +0000

    Implement AIO changes to allow test usage by roles

    In this patch we change the 'scenario' for the AIO bootstrap
    to allow it to be overloaded with any additional service names
    which correspond to an appropriate conf.d AIO configuration file.

    This allows us to implement jobs using a scenario called something
    like 'aio_lxc_octavia' and it will implement the base AIO and add
    the octavia service.

    In order to make use of this for the experimental jobs, we change
    the job names so that the appropriate services are deployed.

    Related-bug: #1759784
    Change-Id: If6b7e401021ea57a908a616ec8b86e7aa6798558

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/622513

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/622513
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=55bfbdbd93882fbb98df706f2a70ceabc08e2e9e
Submitter: Zuul
Branch: stable/rocky

commit 55bfbdbd93882fbb98df706f2a70ceabc08e2e9e
Author: Jesse Pretorius <email address hidden>
Date: Wed Nov 21 14:29:01 2018 +0000

    Implement AIO changes to allow test usage by roles

    In this patch we change the 'scenario' for the AIO bootstrap
    to allow it to be overloaded with any additional service names
    which correspond to an appropriate conf.d AIO configuration file.

    This allows us to implement jobs using a scenario called something
    like 'aio_lxc_octavia' and it will implement the base AIO and add
    the octavia service.

    In order to make use of this for the experimental jobs, we change
    the job names so that the appropriate services are deployed.

    Related-bug: #1759784
    Change-Id: If6b7e401021ea57a908a616ec8b86e7aa6798558
    (cherry picked from commit ada265c8449334538a011300785634774787d54d)