apt_repository config file changes not recognised by Ansible when cache update fails and task retried

[git-harry]

Upstream issue: https://github.com/ansible/ansible/issues/36605

If `apt_repository` fails when attempting to update the apt cache after adding the repository, and the task is set to retry on failure, the second attempt finds the repository has already been added and so no change is made resulting in no attempt to update the cache. This means the second attempt always succeeds without updating the cache. This can result in the failure to install libmariadbclient-dev.

The following example failures where seen on the stable/pike version of galera_client and galera_server but there may be similar examples in other roles.

```
TASK [galera_client : Add galera repo] *****************************************
Friday 16 February 2018 14:42:14 -0600 (0:00:00.713) 0:36:52.759 *******
FAILED - RETRYING: Add galera repo (5 retries left).
ok: [infra1_repo_container-55057f82]

TASK [galera_client : Install galera distro packages] **************************
Friday 16 February 2018 14:42:21 -0600 (0:00:06.969) 0:36:59.729 *******
FAILED - RETRYING: Install galera distro packages (5 retries left).
FAILED - RETRYING: Install galera distro packages (4 retries left).
FAILED - RETRYING: Install galera distro packages (3 retries left).
FAILED - RETRYING: Install galera distro packages (2 retries left).
FAILED - RETRYING: Install galera distro packages (1 retries left).
fatal: [infra1_repo_container-55057f82]: FAILED! => {"attempts": 5, "changed": false, "failed": true, "msg": "No package matching 'libmariadbclient-dev' is available"}
```

```
TASK [galera_server : Add galera repo] *****************************************
Friday 16 February 2018 14:37:20 -0600 (0:00:00.921) 1:01:47.812 *******
FAILED - RETRYING: Add galera repo (5 retries left).
ok: [infra3_galera_container-01038d4c]

TASK [galera_server : Add percona repo] ****************************************
Friday 16 February 2018 14:37:27 -0600 (0:00:07.075) 1:01:54.888 *******
ok: [infra3_galera_container-01038d4c]

TASK [galera_server : Preseed galera password(s)] ******************************
Friday 16 February 2018 14:37:28 -0600 (0:00:00.844) 1:01:55.732 *******
changed: [infra3_galera_container-01038d4c] => (item={u'vtype': u'string', u'question': u'mysql-server/root_password', u'name': u'mariadb-server-10.1', u'value': u'***'})
changed: [infra3_galera_container-01038d4c] => (item={u'vtype': u'string', u'question': u'mysql-server/root_password_again', u'name': u'mariadb-server-10.1', u'value': u'***'})

TASK [galera_server : Prevent galera from starting on install] *****************
Friday 16 February 2018 14:37:29 -0600 (0:00:01.332) 1:01:57.064 *******
changed: [infra3_galera_container-01038d4c]

TASK [galera_server : Install galera_server role remote packages (apt)] ********
Friday 16 February 2018 14:37:30 -0600 (0:00:01.271) 1:01:58.335 *******
fatal: [infra3_galera_container-01038d4c]: FAILED! => {"changed": false, "failed": true, "msg": "No package matching 'libmariadbclient-dev' is available"}
```

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/546312

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/546559

[Jean-Philippe Evrard (jean-philippe-evrard)]

After a discussion this looks valid to me:
Because https://github.com/ansible/ansible/blob/v2.4.3.0-1/lib/ansible/modules/packaging/os/apt_repository.py#L542-L544 is in the same try: block of the file saving, any failure would get reported as a failure, but the file wouldn't be reverted to previous state before reporting failure on https://github.com/ansible/ansible/blob/v2.4.3.0-1/lib/ansible/modules/packaging/os/apt_repository.py#L547.

We have the state of before/after, so it should be used for a revert.

[Jean-Philippe Evrard (jean-philippe-evrard)]

That's an ansible upstream bug that needs tracking, and we need to adapt ourselves to this issue.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/546559
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_client/commit/?id=69729be3d1a24f639a9526e09ed027801442ed8c
Submitter: Zuul
Branch: master

commit 69729be3d1a24f639a9526e09ed027801442ed8c
Author: git-harry <email address hidden>
Date: Wed Feb 21 10:35:06 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I41de2b9a98977bb89de812a9fbc85a9f99d62942
    Partial-bug: 1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/546312
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_server/commit/?id=7596eaa8898e774e4779417ac8c1fec38f634977
Submitter: Zuul
Branch: master

commit 7596eaa8898e774e4779417ac8c1fec38f634977
Author: git-harry <email address hidden>
Date: Tue Feb 20 20:57:00 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change puts responsibility for updating the cache on the apt module
    task, this means updating the cache will get retried on failure and no
    longer fail silently.

    The changes made include:
    - the two apt_repository tasks have their update_cache parameter set to
      no so it is clear where any update happens and there is no unnecessary
      duplication of cache updates.
    - the use of retries is removed given the tasks no longer need to make
      use of the network.
    - the apt_repository task result variables have been given unique names
      to ensure that the cache is updated if only the galera repository is
      added.

    Change-Id: I91b7929113f720bc3c55343c481096657376302f
    Partial-bug: 1750656

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/547000

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/547003

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/547004

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/547015

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/547021

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/547043

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/547044

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/547048

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/547052

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/547053

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/547061

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/547063

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/547074

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547048
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_client/commit/?id=3a01c65e3d09d2fe23cbb8c2a6c6a75d73791c4b
Submitter: Zuul
Branch: stable/ocata

commit 3a01c65e3d09d2fe23cbb8c2a6c6a75d73791c4b
Author: git-harry <email address hidden>
Date: Wed Feb 21 10:35:06 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I41de2b9a98977bb89de812a9fbc85a9f99d62942
    Partial-bug: 1750656
    (cherry picked from commit 69729be3d1a24f639a9526e09ed027801442ed8c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547052
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_client/commit/?id=fbc780f422f606a32bcf483fb9ac868d8c42318d
Submitter: Zuul
Branch: stable/newton

commit fbc780f422f606a32bcf483fb9ac868d8c42318d
Author: git-harry <email address hidden>
Date: Wed Feb 21 10:35:06 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I41de2b9a98977bb89de812a9fbc85a9f99d62942
    Partial-bug: 1750656
    (cherry picked from commit 69729be3d1a24f639a9526e09ed027801442ed8c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547043
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_client/commit/?id=78a6637b16d5529c9181b600d86db301c644c624
Submitter: Zuul
Branch: stable/queens

commit 78a6637b16d5529c9181b600d86db301c644c624
Author: git-harry <email address hidden>
Date: Wed Feb 21 10:35:06 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I41de2b9a98977bb89de812a9fbc85a9f99d62942
    Partial-bug: 1750656
    (cherry picked from commit 69729be3d1a24f639a9526e09ed027801442ed8c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547044
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_client/commit/?id=f94c4b90629bb34638035e575596feea0b14fe63
Submitter: Zuul
Branch: stable/pike

commit f94c4b90629bb34638035e575596feea0b14fe63
Author: git-harry <email address hidden>
Date: Wed Feb 21 10:35:06 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I41de2b9a98977bb89de812a9fbc85a9f99d62942
    Partial-bug: 1750656
    (cherry picked from commit 69729be3d1a24f639a9526e09ed027801442ed8c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547074
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_server/commit/?id=684601b9af402de1e1b0301e2f99353860fcbce2
Submitter: Zuul
Branch: stable/newton

commit 684601b9af402de1e1b0301e2f99353860fcbce2
Author: git-harry <email address hidden>
Date: Thu Feb 22 17:14:41 2018 +0000

    Fix Apt cache update due to adding Galera repo

    Registering the same variable when adding the Galera and Percona
    repositories means that the cache is not updated if the Galera
    repository is added but the Percona one isn't. This change gives the
    variables separate names to ensure the cache update happens when
    required.

    Change-Id: Ie754888e2ee97e7455ae1f7328afde0e9a6cb25e
    Partial-bug: 1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547063
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_server/commit/?id=ea7b8b253bee0c9bcee1a27a2fa4119bf1d70047
Submitter: Zuul
Branch: stable/ocata

commit ea7b8b253bee0c9bcee1a27a2fa4119bf1d70047
Author: git-harry <email address hidden>
Date: Tue Feb 20 20:57:00 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change puts responsibility for updating the cache on the apt module
    task, this means updating the cache will get retried on failure and no
    longer fail silently.

    The changes made include:
    - the two apt_repository tasks have their update_cache parameter set to
      no so it is clear where any update happens and there is no unnecessary
      duplication of cache updates.
    - the use of retries is removed given the tasks no longer need to make
      use of the network.
    - the apt_repository task result variables have been given unique names
      to ensure that the cache is updated if only the galera repository is
      added.

    In addition, this cherry-pick separates out the cache update step from
    the install task so that the update is not performed for every item.

    Change-Id: I91b7929113f720bc3c55343c481096657376302f
    Partial-bug: 1750656
    (cherry picked from commit 7596eaa8898e774e4779417ac8c1fec38f634977)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547061
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_server/commit/?id=daf9d5dc03e732a85476a5c2555ee0570c1acbac
Submitter: Zuul
Branch: stable/pike

commit daf9d5dc03e732a85476a5c2555ee0570c1acbac
Author: git-harry <email address hidden>
Date: Tue Feb 20 20:57:00 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change puts responsibility for updating the cache on the apt module
    task, this means updating the cache will get retried on failure and no
    longer fail silently.

    The changes made include:
    - the two apt_repository tasks have their update_cache parameter set to
      no so it is clear where any update happens and there is no unnecessary
      duplication of cache updates.
    - the use of retries is removed given the tasks no longer need to make
      use of the network.
    - the apt_repository task result variables have been given unique names
      to ensure that the cache is updated if only the galera repository is
      added.

    Change-Id: I91b7929113f720bc3c55343c481096657376302f
    Partial-bug: 1750656
    (cherry picked from commit 7596eaa8898e774e4779417ac8c1fec38f634977)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547053
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_server/commit/?id=63b17cc25055d2b410e579960cdf043d774923a9
Submitter: Zuul
Branch: stable/queens

commit 63b17cc25055d2b410e579960cdf043d774923a9
Author: git-harry <email address hidden>
Date: Tue Feb 20 20:57:00 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change puts responsibility for updating the cache on the apt module
    task, this means updating the cache will get retried on failure and no
    longer fail silently.

    The changes made include:
    - the two apt_repository tasks have their update_cache parameter set to
      no so it is clear where any update happens and there is no unnecessary
      duplication of cache updates.
    - the use of retries is removed given the tasks no longer need to make
      use of the network.
    - the apt_repository task result variables have been given unique names
      to ensure that the cache is updated if only the galera repository is
      added.

    Change-Id: I91b7929113f720bc3c55343c481096657376302f
    Partial-bug: 1750656
    (cherry picked from commit 7596eaa8898e774e4779417ac8c1fec38f634977)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547003
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=e647596930fb898e13630a449722f3a75160e0be
Submitter: Zuul
Branch: master

commit e647596930fb898e13630a449722f3a75160e0be
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:29:00 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: Ia0723407a08a84d5a1a59f4cc3b9006e8587d7b3
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547000
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-ceph_client/commit/?id=db7093684666282d9890eb564b7424ab4ae3cf75
Submitter: Zuul
Branch: master

commit db7093684666282d9890eb564b7424ab4ae3cf75
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:23:47 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I43bd89e9bd5e2094eb0c138e17045ea64cd62c4d
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547021
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=c68db4e674e744f4e75841de801731f3de5da8fa
Submitter: Zuul
Branch: stable/pike

commit c68db4e674e744f4e75841de801731f3de5da8fa
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 15:00:41 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I3a346bec7b5656d780416054fbaa6e322b6216f2
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547015
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=23bd341129bc9fc6449f3b1f38f07fb4914aa298
Submitter: Zuul
Branch: master

commit 23bd341129bc9fc6449f3b1f38f07fb4914aa298
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:48:19 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: Id059dbec3466cb1ef3ea567249f52384a8ade515
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547004
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=fe537c7a29ff7022e30771d2f59c00c9bece008e
Submitter: Zuul
Branch: master

commit fe537c7a29ff7022e30771d2f59c00c9bece008e
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:34:56 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I1d71deeee64fe27df1275965aac8240cc2ab427c
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/547393

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/547394

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/547395

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/547396

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/547397

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/547398

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/547399

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/547400

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/547401

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/547402

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/547433

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/547438

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/547448

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/547469

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/547497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547448
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=c0fc932d6ea9984777bf3184827fd82bfbd5191f
Submitter: Zuul
Branch: stable/newton

commit c0fc932d6ea9984777bf3184827fd82bfbd5191f
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 15:00:41 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I3a346bec7b5656d780416054fbaa6e322b6216f2
    Partial-Bug: #1750656
    (cherry picked from commit c68db4e674e744f4e75841de801731f3de5da8fa)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547398
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=351380e4e63707188d66e2699d5ca0ed3be4d0e3
Submitter: Zuul
Branch: stable/ocata

commit 351380e4e63707188d66e2699d5ca0ed3be4d0e3
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 15:00:41 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I3a346bec7b5656d780416054fbaa6e322b6216f2
    Partial-Bug: #1750656
    (cherry picked from commit c68db4e674e744f4e75841de801731f3de5da8fa)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547469
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-ceph_client/commit/?id=999f8ad819c217066f468b81c2ed0bf13022f7a4
Submitter: Zuul
Branch: stable/newton

commit 999f8ad819c217066f468b81c2ed0bf13022f7a4
Author: Jesse Pretorius <email address hidden>
Date: Fri Feb 23 14:48:54 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I43bd89e9bd5e2094eb0c138e17045ea64cd62c4d
    Partial-Bug: #1750656
    (cherry picked from commit db7093684666282d9890eb564b7424ab4ae3cf75)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547400
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-ceph_client/commit/?id=6dd85991b2d052b58305a0ebb6984d9b29c263d9
Submitter: Zuul
Branch: stable/pike

commit 6dd85991b2d052b58305a0ebb6984d9b29c263d9
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:23:47 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I43bd89e9bd5e2094eb0c138e17045ea64cd62c4d
    Partial-Bug: #1750656
    (cherry picked from commit db7093684666282d9890eb564b7424ab4ae3cf75)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547395
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=cffd1ebd45e20331ee505568cd34c277d3225138
Submitter: Zuul
Branch: stable/queens

commit cffd1ebd45e20331ee505568cd34c277d3225138
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:48:19 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Backport includes: https://review.openstack.org/547471

    Change-Id: Id059dbec3466cb1ef3ea567249f52384a8ade515
    Partial-Bug: #1750656
    (cherry picked from commit 23bd341129bc9fc6449f3b1f38f07fb4914aa298)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547396
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=44f63d92dc3d0555dcf2c8ff587f4c4e09b10fdc
Submitter: Zuul
Branch: stable/pike

commit 44f63d92dc3d0555dcf2c8ff587f4c4e09b10fdc
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:48:19 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Backport includes: https://review.openstack.org/547471

    Change-Id: Id059dbec3466cb1ef3ea567249f52384a8ade515
    Partial-Bug: #1750656
    (cherry picked from commit 23bd341129bc9fc6449f3b1f38f07fb4914aa298)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547397
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=14cced1d77d6b2ad74d8aa5a19538dbe0e6bc506
Submitter: Zuul
Branch: stable/ocata

commit 14cced1d77d6b2ad74d8aa5a19538dbe0e6bc506
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:48:19 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Backport includes: https://review.openstack.org/547471

    Change-Id: Id059dbec3466cb1ef3ea567249f52384a8ade515
    Partial-Bug: #1750656
    (cherry picked from commit 23bd341129bc9fc6449f3b1f38f07fb4914aa298)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547433
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=d85329add054c834e2c1f4a0593c4038f67a0593
Submitter: Zuul
Branch: stable/newton

commit d85329add054c834e2c1f4a0593c4038f67a0593
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:34:56 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I1d71deeee64fe27df1275965aac8240cc2ab427c
    Partial-Bug: #1750656
    (cherry picked from commit fe537c7a29ff7022e30771d2f59c00c9bece008e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547394
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=c11f8230514d5c2ae577a6af033253dd7099d097
Submitter: Zuul
Branch: stable/pike

commit c11f8230514d5c2ae577a6af033253dd7099d097
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:34:56 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I1d71deeee64fe27df1275965aac8240cc2ab427c
    Partial-Bug: #1750656
    (cherry picked from commit fe537c7a29ff7022e30771d2f59c00c9bece008e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547402
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=b48de36760e789ee6bcaf52bab1c54165de236ef
Submitter: Zuul
Branch: stable/queens

commit b48de36760e789ee6bcaf52bab1c54165de236ef
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:29:00 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: Ia0723407a08a84d5a1a59f4cc3b9006e8587d7b3
    Partial-Bug: #1750656
    (cherry picked from commit e647596930fb898e13630a449722f3a75160e0be)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547399
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-ceph_client/commit/?id=50ea8b644c0713d007f6f172cd7bbc850f44a55a
Submitter: Zuul
Branch: stable/queens

commit 50ea8b644c0713d007f6f172cd7bbc850f44a55a
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:23:47 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I43bd89e9bd5e2094eb0c138e17045ea64cd62c4d
    Partial-Bug: #1750656
    (cherry picked from commit db7093684666282d9890eb564b7424ab4ae3cf75)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547401
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-ceph_client/commit/?id=94cf883b09b1308dea03fa4c6f8217d03de5fa01
Submitter: Zuul
Branch: stable/ocata

commit 94cf883b09b1308dea03fa4c6f8217d03de5fa01
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:23:47 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I43bd89e9bd5e2094eb0c138e17045ea64cd62c4d
    Partial-Bug: #1750656
    (cherry picked from commit db7093684666282d9890eb564b7424ab4ae3cf75)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547471
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=76fc65b4e7a158628aff8f3a95ec91a0ec3ce2f0
Submitter: Zuul
Branch: master

commit 76fc65b4e7a158628aff8f3a95ec91a0ec3ce2f0
Author: Jesse Pretorius <email address hidden>
Date: Fri Feb 23 14:53:57 2018 +0000

    Explicitly ensure when apt cache updates happen

    In https://review.openstack.org/547015 we adjusted
    the apt installation process to ensure that the cache
    update happens after the repository changes, but left
    out the explicit instruction not to do it in the task
    which changes the repo config.

    This patch adds that, but also seperates out the cache
    update into its own task so that the package install
    task remains more readable.

    Partial-Bug: #1750656
    Change-Id: Id70ad28caa63267c2bb17d8c56a8fa6e00cf55d4

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547438
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=62dd9d0cf67c9d6fb18b5fca19416bba377db645
Submitter: Zuul
Branch: stable/ocata

commit 62dd9d0cf67c9d6fb18b5fca19416bba377db645
Author: Jesse Pretorius <email address hidden>
Date: Fri Feb 23 14:26:11 2018 +0000

    Restore PowerVM repo setup

    In https://review.openstack.org/466301 the PowerVM repo
    configuration was mistakenly removed.

    This patch restores the file.

    Change-Id: I1d71deeee64fe27df1275965aac8240cc2ab427c
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547393
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=882f36dc2a2547b17e7a5bc2931d31813068d74d
Submitter: Zuul
Branch: stable/queens

commit 882f36dc2a2547b17e7a5bc2931d31813068d74d
Author: Jesse Pretorius <email address hidden>
Date: Thu Feb 22 14:34:56 2018 +0000

    Fix cache update after initial apt_repository fail

    If apt_repository fails to update the apt cache after updating the
    configuration, retries don't register there was a change and so no
    attempt is made to update the cache by the module on the second attempt.
    This failure can result in a failure to install packages.

    This change adds an apt module task to update the cache if the
    apt_repository task registers a change. This means updating the cache
    will get retried on failure and no longer fail silently.

    Change-Id: I1d71deeee64fe27df1275965aac8240cc2ab427c
    Partial-Bug: #1750656
    (cherry picked from commit fe537c7a29ff7022e30771d2f59c00c9bece008e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/547497
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=67bfc907030d7f0ce6fbb63f0608aa021f0b5400
Submitter: Zuul
Branch: master

commit 67bfc907030d7f0ce6fbb63f0608aa021f0b5400
Author: git-harry <email address hidden>
Date: Fri Feb 23 16:10:20 2018 +0000

    Add ansible-lint rule for apt_repository

    This rule is designed to prevent the Ansible module `apt_repository`
    from being used to update the APT cache. There is a bug [1] in
    `apt_repository` that prevents cache updates from being performed
    whenever the module is retried. If the cache update fails at the first
    attempt, it is skipped on the subsequent attempt of the task causing the
    task to always complete successfully. Until this bug is addressed this
    rule should prevent it from being introduced into OpenStack-Ansible.

    Partial-bug: 1750656

    [1] https://github.com/ansible/ansible/issues/36605

    Change-Id: If440ce129c31fb4e62a8e0ac5094195f4d4d7167

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/550594

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/550595

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/550596

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/551246

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/551246
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=cb435cea4545599bef2ccd8bf053453d6d69cd25
Submitter: Zuul
Branch: master

commit cb435cea4545599bef2ccd8bf053453d6d69cd25
Author: git-harry <email address hidden>
Date: Fri Mar 9 10:22:47 2018 +0000

    Add tests for APTRepositoryCacheUpdateRule

    The custom ansible-lint rule APTRepositoryCacheUpdateRule was added in
    67bfc907030d7f0ce6fbb63f0608aa021f0b5400, this change adds tests to
    validate its functionality.

    Change-Id: Ie0642cc41c016fc016b2bc6fc6d04b6afdf2be2c
    Partial-bug: 1750656

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/552024

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/552025

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/552027

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550594
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=80216154fa93c828ed159bdcbad1470cdec33966
Submitter: Zuul
Branch: stable/queens

commit 80216154fa93c828ed159bdcbad1470cdec33966
Author: git-harry <email address hidden>
Date: Fri Feb 23 16:10:20 2018 +0000

    Add ansible-lint rule for apt_repository

    This rule is designed to prevent the Ansible module `apt_repository`
    from being used to update the APT cache. There is a bug [1] in
    `apt_repository` that prevents cache updates from being performed
    whenever the module is retried. If the cache update fails at the first
    attempt, it is skipped on the subsequent attempt of the task causing the
    task to always complete successfully. Until this bug is addressed this
    rule should prevent it from being introduced into OpenStack-Ansible.

    Partial-bug: 1750656

    [1] https://github.com/ansible/ansible/issues/36605

    Change-Id: If440ce129c31fb4e62a8e0ac5094195f4d4d7167
    (cherry picked from commit 67bfc907030d7f0ce6fbb63f0608aa021f0b5400)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550595
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=131ea49076d553f93b329f52743ec4a15dbd9d57
Submitter: Zuul
Branch: stable/pike

commit 131ea49076d553f93b329f52743ec4a15dbd9d57
Author: git-harry <email address hidden>
Date: Fri Feb 23 16:10:20 2018 +0000

    Add ansible-lint rule for apt_repository

    This rule is designed to prevent the Ansible module `apt_repository`
    from being used to update the APT cache. There is a bug [1] in
    `apt_repository` that prevents cache updates from being performed
    whenever the module is retried. If the cache update fails at the first
    attempt, it is skipped on the subsequent attempt of the task causing the
    task to always complete successfully. Until this bug is addressed this
    rule should prevent it from being introduced into OpenStack-Ansible.

    Partial-bug: 1750656

    [1] https://github.com/ansible/ansible/issues/36605

    Change-Id: If440ce129c31fb4e62a8e0ac5094195f4d4d7167
    (cherry picked from commit 67bfc907030d7f0ce6fbb63f0608aa021f0b5400)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550596
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=af8ecc5ae60884b27c3c9a71ac8b3d274e83d9b6
Submitter: Zuul
Branch: stable/ocata

commit af8ecc5ae60884b27c3c9a71ac8b3d274e83d9b6
Author: git-harry <email address hidden>
Date: Fri Feb 23 16:10:20 2018 +0000

    Add ansible-lint rule for apt_repository

    This rule is designed to prevent the Ansible module `apt_repository`
    from being used to update the APT cache. There is a bug [1] in
    `apt_repository` that prevents cache updates from being performed
    whenever the module is retried. If the cache update fails at the first
    attempt, it is skipped on the subsequent attempt of the task causing the
    task to always complete successfully. Until this bug is addressed this
    rule should prevent it from being introduced into OpenStack-Ansible.

    Partial-bug: 1750656

    [1] https://github.com/ansible/ansible/issues/36605

    Change-Id: If440ce129c31fb4e62a8e0ac5094195f4d4d7167
    (cherry picked from commit 67bfc907030d7f0ce6fbb63f0608aa021f0b5400)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552024
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=a3e9a87cb3b9aaa1d82e6ab539289b616dea729d
Submitter: Zuul
Branch: stable/queens

commit a3e9a87cb3b9aaa1d82e6ab539289b616dea729d
Author: git-harry <email address hidden>
Date: Fri Mar 9 10:22:47 2018 +0000

    Add tests for APTRepositoryCacheUpdateRule

    The custom ansible-lint rule APTRepositoryCacheUpdateRule was added in
    67bfc907030d7f0ce6fbb63f0608aa021f0b5400, this change adds tests to
    validate its functionality.

    Includes fix from 44761d390b9f9f4794e8521a503be88f3757cc43 to ensure
    unit tests only run against this repository.

    Change-Id: Ie0642cc41c016fc016b2bc6fc6d04b6afdf2be2c
    Partial-bug: 1750656
    (cherry picked from commit cb435cea4545599bef2ccd8bf053453d6d69cd25)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552025
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=4ab3e95a8041fb652a4cdf3555f5400f50cd99aa
Submitter: Zuul
Branch: stable/pike

commit 4ab3e95a8041fb652a4cdf3555f5400f50cd99aa
Author: git-harry <email address hidden>
Date: Fri Mar 9 10:22:47 2018 +0000

    Add tests for APTRepositoryCacheUpdateRule

    The custom ansible-lint rule APTRepositoryCacheUpdateRule was added in
    67bfc907030d7f0ce6fbb63f0608aa021f0b5400, this change adds tests to
    validate its functionality.

    Includes fix from 44761d390b9f9f4794e8521a503be88f3757cc43 to ensure
    unit tests only run against this repository.

    Change-Id: Ie0642cc41c016fc016b2bc6fc6d04b6afdf2be2c
    Partial-bug: 1750656
    (cherry picked from commit cb435cea4545599bef2ccd8bf053453d6d69cd25)

[OpenStack Infra (hudson-openstack)]

Change abandoned by git-harry (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/552027

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553327

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553331

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553332

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553334

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553327
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-pip_install/commit/?id=4e708955be6675af8195c98d1cf543bb40f7757e
Submitter: Zuul
Branch: stable/newton

commit 4e708955be6675af8195c98d1cf543bb40f7757e
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 10:55:01 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Icec853745b4aaa9f8745ec5cb42d85ccc606bac0
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553335

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553336

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553338

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553340

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553342

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553343

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553344

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553345

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553346

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553347

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553348

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553349

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553350

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553352

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553353

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553354

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553355

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553356

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553357

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553358

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553359

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553360

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553361

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/553362

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553362
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rsyslog_server/commit/?id=cdf4139194e54968473d293c04dee18a5dbc49fb
Submitter: Zuul
Branch: stable/newton

commit cdf4139194e54968473d293c04dee18a5dbc49fb
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:41:06 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I0a9a8e79e617517661f89b79bd38bba8e674f6cf
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553361
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rsyslog_client/commit/?id=a4d857cd5b5fdabd02ede29c52598d2ba5ae2850
Submitter: Zuul
Branch: stable/newton

commit a4d857cd5b5fdabd02ede29c52598d2ba5ae2850
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:40:35 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Ia6d0a2ed533c596525bd0b09a949e6e90ea2a010
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553338
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_hosts/commit/?id=d5cd809f25ca3ee0fc900ba0ee6696f54b7ba378
Submitter: Zuul
Branch: stable/newton

commit d5cd809f25ca3ee0fc900ba0ee6696f54b7ba378
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:21:24 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Ib57970262715258e9c26a99707f96a370d95b933
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553332
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-ceph_client/commit/?id=8f6683876e5c0844ddbedbbdc0cb1984eb59daf2
Submitter: Zuul
Branch: stable/newton

commit 8f6683876e5c0844ddbedbbdc0cb1984eb59daf2
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:12:57 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I5ab8e0ab8baae8823b77fad30d8c3f02dbf23a43
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553334
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_client/commit/?id=44b84beee12f3667ec8f50afcb4156c56397fad1
Submitter: Zuul
Branch: stable/newton

commit 44b84beee12f3667ec8f50afcb4156c56397fad1
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:15:41 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I07ca53a0c20cd92313e06df64ede9be1de7989ab
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553340
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-memcached_server/commit/?id=2ca66836533a6bb7e5b971b20ddedfd6d5b101a1
Submitter: Zuul
Branch: stable/newton

commit 2ca66836533a6bb7e5b971b20ddedfd6d5b101a1
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:22:12 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I60d17d3cae97aed3d9bfd26652ef6306a678399c
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553336
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-haproxy_server/commit/?id=135dace0e79724639c73f4457a66721276de76a8
Submitter: Zuul
Branch: stable/newton

commit 135dace0e79724639c73f4457a66721276de76a8
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:18:26 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Icd14bbc15b418bffaddd01701f0ec0bdde7f2e0a
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553360
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-repo_server/commit/?id=e7f5ccab43d644f206f1d54a7ea8957195b305ff
Submitter: Zuul
Branch: stable/newton

commit e7f5ccab43d644f206f1d54a7ea8957195b305ff
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:40:04 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Id48c745dda308323c7e7c9d36f54b900fe83e910
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553342
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=5b936f6569bc9ef1c00cbe81056654484357793f
Submitter: Zuul
Branch: stable/newton

commit 5b936f6569bc9ef1c00cbe81056654484357793f
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:22:59 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Ib879989a839a77135ba48720d27e981d80931b0d
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553331
Committed: https://git.openstack.org/cgit/openstack/ansible-hardening/commit/?id=128cd2f2eb91fcd24e860597cf924db34d9e44b9
Submitter: Zuul
Branch: stable/newton

commit 128cd2f2eb91fcd24e860597cf924db34d9e44b9
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:11:47 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: If83f70b9ceef4e610401b48fa16bdd41c12a3ca0
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553335
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_server/commit/?id=4f6c0f1053ce639eb07dbd3cb980e8db43fabd21
Submitter: Zuul
Branch: stable/newton

commit 4f6c0f1053ce639eb07dbd3cb980e8db43fabd21
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:17:29 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Ie23891b3fd8d8503044769a51b9b3fc5caf02eba
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553359
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-repo_build/commit/?id=d383ea7cbeacd78f6dfd03a4c99e8db79562fced
Submitter: Zuul
Branch: stable/newton

commit d383ea7cbeacd78f6dfd03a4c99e8db79562fced
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:38:46 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I9b32eb1aa5a126968ae9bb039318c8431851e86e
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553354
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_rally/commit/?id=1520559a52cb4a509f03a56fc12be7a142cafe54
Submitter: Zuul
Branch: stable/newton

commit 1520559a52cb4a509f03a56fc12be7a142cafe54
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:32:52 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Ic9b30235f41595e08352efeee3a99cca55f7a40f
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553358
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rabbitmq_server/commit/?id=365981385549cf2d93ed604ff2c262417f523d44
Submitter: Zuul
Branch: stable/newton

commit 365981385549cf2d93ed604ff2c262417f523d44
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:37:54 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I946766d6f63f24dcf10ad8ea80e07dae6e5f4d8f
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553346
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_glance/commit/?id=3579d388583615f9ccd460a710904ca26a47fbc8
Submitter: Zuul
Branch: stable/newton

commit 3579d388583615f9ccd460a710904ca26a47fbc8
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:26:03 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Ie756516564dfcfefb7d8ece79911e5a5d515f483
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553348
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_heat/commit/?id=a10c50f0d67349c38d2fe0a5d9bf39c0371319a5
Submitter: Zuul
Branch: stable/newton

commit a10c50f0d67349c38d2fe0a5d9bf39c0371319a5
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:27:26 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I069da552098abfe2d1e8293090c8f5c6cf37b5bc
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553347
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_gnocchi/commit/?id=5e35c064073c7e1b98a6c024f014a566a7cc92e1
Submitter: Zuul
Branch: stable/newton

commit 5e35c064073c7e1b98a6c024f014a566a7cc92e1
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:26:37 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I24fbd4c701bd8c70e071bc7ecc0881029712f03d
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553343
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_aodh/commit/?id=c0e22c914460326786a2ae3133d33bcfdc72b604
Submitter: Zuul
Branch: stable/newton

commit c0e22c914460326786a2ae3133d33bcfdc72b604
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:23:50 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I9c36f01c09bd12611108f71c11a356b962460319
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553344
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ceilometer/commit/?id=9c89824af1eb1c635f66349222d76e6cf7eb7b16
Submitter: Zuul
Branch: stable/newton

commit 9c89824af1eb1c635f66349222d76e6cf7eb7b16
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:24:52 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Icc2ce1e48b7dfcb8a339494ba8033d7ecc4565f2
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553349
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_horizon/commit/?id=6501e93f6322dfedab0ac6ce9eb08c2b9e6be09b
Submitter: Zuul
Branch: stable/newton

commit 6501e93f6322dfedab0ac6ce9eb08c2b9e6be09b
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:27:55 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I0b9b74cc05b338c24e6adac1af7a08e95c663666
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553355
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_sahara/commit/?id=462a93d047460ede112d81e5a93faa2d075b1538
Submitter: Zuul
Branch: stable/newton

commit 462a93d047460ede112d81e5a93faa2d075b1538
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:33:22 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I6d73a7889e0d11c63fba4588f244b9e961e3a376
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553345
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_cinder/commit/?id=6c2fb4ef75e9232cbd8f19673755cb88de1d08e8
Submitter: Zuul
Branch: stable/newton

commit 6c2fb4ef75e9232cbd8f19673755cb88de1d08e8
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:25:25 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I6260f408065b26a1d2e7404266c0ccee30d06d9f
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553352
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_neutron/commit/?id=206bbc211ba4ec651cbe2e4c4ba249ae239f60b7
Submitter: Zuul
Branch: stable/newton

commit 206bbc211ba4ec651cbe2e4c4ba249ae239f60b7
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:30:23 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I66db37c6a55f9133befd8f9803cab217034547c1
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553353
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=b3caae5506fbceeb7dfb55f52d2f2f5c6bf1f80b
Submitter: Zuul
Branch: stable/newton

commit b3caae5506fbceeb7dfb55f52d2f2f5c6bf1f80b
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:31:32 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: Ia53420dc3c19928afdc0740328b77aacee697f1d
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553356
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_swift/commit/?id=eca6db29b16aae6dcbaa99a9ee3148f296c7865a
Submitter: Zuul
Branch: stable/newton

commit eca6db29b16aae6dcbaa99a9ee3148f296c7865a
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:34:00 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Change-Id: I55f45ea78adbc77f66b1ae7dc9d9de447201b5cb
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553350
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_magnum/commit/?id=9dc110a096f103d5312700527f8d7417f0cb0b85
Submitter: Zuul
Branch: stable/newton

commit 9dc110a096f103d5312700527f8d7417f0cb0b85
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:29:07 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Depends-On: https://review.openstack.org/553462
    Change-Id: Id564e84ee69093c781357d7f3c78dbf612e1d130
    Partial-Bug: #1750656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553357
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_tempest/commit/?id=500bea4b54c36dff471005831c45cd5c4aca36c3
Submitter: Zuul
Branch: stable/newton

commit 500bea4b54c36dff471005831c45cd5c4aca36c3
Author: Jesse Pretorius <email address hidden>
Date: Thu Mar 15 11:34:31 2018 +0000

    Add retries to apt cache update

    Updating the apt cache sometimes fails due to it being
    an operation that uses mirrors on the internet. The
    task should be retried to reduce the chance of a
    transient failure causing the playbook to fail.

    Depends-On: https://review.openstack.org/553462
    Change-Id: I49351d7234fc39d25ba03f01f7e524c963334992
    Partial-Bug: #1750656