Use default sysctl_file in openstack_hosts

[Kevin Stevens]

All Openstack-specific kernel parameters specified in "openstack_kernel_options" and "openstack_user_kernel_options" are added to /etc/sysctl.conf. We should have the option to override sysctl_file and place these parameters into their own config file ( eg. /etc/sysctl.d/openstack-tuning.conf ) and maybe even default to something other than sysctl.conf.

[Jean-Philippe Evrard (jean-philippe-evrard)]

We are using the sysctl ansible module, so it should be idempotent, and therefore not have issues with its edition.

However we are not passing the sysctl_file argument of the module.
For now, we could consider this sysctl_file addition as a wishlist.

What's your use case?

[Kevin Stevens (kstev)]

In our case we have a post-provisioning script that writes a specific /etc/sysctl.conf. This could be handled better and I do not have a strong opinion on the default value of "sysctl_file" but I do think we should be able to override it.

[Jean-Philippe Evrard (jean-philippe-evrard)]

Using the module would work without the need to implement sysctl_file.
We've considered the sysctl_file for inclusion and are not against including it, should someone patch it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/openstack-ansible-openstack_hosts/+/908912