default_bind_mount_logs changes on N>O upgrade

[Marc Gariépy]

This will set default_bind_mount_logs to false when upgrading newton to Ocata.

https://github.com/openstack/openstack-ansible/blob/stable/ocata/scripts/upgrade-utilities/playbooks/deploy-config-changes.yml#L74-L75

While this setting can trigger a reboot it would be better if set to false if not present in the user_variables (due to default changes) and left untouched if already present since the default was overwritten by the deployer.

we should probably remove that from Pike and master

[Marc Gariépy (mgariepy)]

same should be for pike upgrade.

[Major Hayden (rackerhacker)]

That change makes sense to me, Marc.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/537641

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/537641
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=7cd9fec86f11a294b67b8ae990141cdb7a97fdfe
Submitter: Zuul
Branch: master

commit 7cd9fec86f11a294b67b8ae990141cdb7a97fdfe
Author: Marc Gariepy <email address hidden>
Date: Wed Jan 24 15:12:54 2018 -0500

    Remove default_bind_mount_logs from config changes.

    Changing the value for default_bind_mount_logs on upgrade will make all
    container restart. It only make sense to add this to the config when:
    - you upgrade to the release that changes the default behavior
        - this is to keep the old default.
    - The setting is not set in the configuration.
        - If the config is present, you don't want to change it.

    Change-Id: I37217352357dee8c844d3b20d28075f7e4ef1223
    Related-Bug: #1745212

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/538324

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/538324
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=900a2f6be5bf85f0ee203d0b353e0fb19e9718bd
Submitter: Zuul
Branch: stable/pike

commit 900a2f6be5bf85f0ee203d0b353e0fb19e9718bd
Author: Marc Gariepy <email address hidden>
Date: Wed Jan 24 15:12:54 2018 -0500

    Remove default_bind_mount_logs from config changes.

    Changing the value for default_bind_mount_logs on upgrade will make all
    container restart. It only make sense to add this to the config when:
    - you upgrade to the release that changes the default behavior
        - this is to keep the old default.
    - The setting is not set in the configuration.
        - If the config is present, you don't want to change it.

    Change-Id: I37217352357dee8c844d3b20d28075f7e4ef1223
    Related-Bug: #1745212
    (cherry picked from commit 7cd9fec86f11a294b67b8ae990141cdb7a97fdfe)