Tests repo has too many repetitions of the branch name

Bug #1742749 reported by Jean-Philippe Evrard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Wishlist
Nicolas Bock

Bug Description

There are many places where branch or previous branch is defined.
We should probably instead put the branchname in a file, and reference to this file when appropriate.

It would remove duplications.

tags: added: low-hanging-fruit
Changed in openstack-ansible:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Nicolas Bock (nicolasbock) wrote :

Are you referring to only the `openstack-ansible-tests` repository here? I can't find _that_ many definitions in it :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-tests (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/566718

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-tests (stable/ocata)

Reviewed: https://review.openstack.org/566718
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=8691aa9e4f8a091cfa3925162877a5ab64c44e9e
Submitter: Zuul
Branch: stable/ocata

commit 8691aa9e4f8a091cfa3925162877a5ab64c44e9e
Author: Nicolas Bock <email address hidden>
Date: Mon May 7 13:40:37 2018 -0600

    Backport to refactor hardcoded branch references

    Change-Id: I49726b9b0cdcb87f3bbe340c055d1934f31a2df1
    Closes-Bug: 1742749

tags: added: in-stable-ocata
Changed in openstack-ansible:
assignee: nobody → Nicolas Bock (nicolasbock)
Revision history for this message
Jonathan Rosser (jrosser) wrote :

Marking as fix released

Changed in openstack-ansible:
status: Confirmed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on openstack-ansible-tests (stable/queens)

Change abandoned by Nicolas Bock (<email address hidden>) on branch: stable/queens
Review: https://review.opendev.org/573812

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.