virtualenv-tools is unreliable for changing path in venvs

Bug #1741634 reported by Jean-Philippe Evrard on 2018-01-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-ansible
Critical
Jean-Philippe Evrard

Bug Description

virtualenv-tools has been unmaintained for a while, or at least it has not changed for a while, while still having pending PR.
(Edit: It's a dead project, according to its author [7])

In the past we raised a few issues against it [2], and had to do conditional behavior depending on distros [1].

virtualenv-tools is also a python2 only tool, and will break with python3 (it would be easy to move it to python3, because the code is simple, but I foresee issues with the print statements already!).

Anyway, on top of that we are victim of a bug while changing paths.

Our repo-build process builds a virtualenv and pip install software into it. By default, the shabang of python binaries in the virtualenv's archive is something like #!/tmp/openstack-venv-builder/venvs/keystone/bin/python.

This lines comes virtualenv itself, as proven by the first line of the venv build's log (for example /var/log/repo/venv_build_keystone-master-x86_64.log): "New python executable in /tmp/openstack-venv-builder/venvs/keystone/bin/python"

This line comes is logged during our venv-build-script.sh process, whose ${VENV_CREATE_COMMAND} is the first command to log on the ${ROLE_VENV_LOG}, and generates a few lines.

This venv-build-script.sh script takes the virtualenv options, for example /var/www/repo/os-releases/master/ubuntu-16.04-x86_64/venv-build-options-os_keystone.txt, which contains the virtualenv command, in my example: "/usr/local/bin/virtualenv --always-copy --extra-search-dir /var/www/repo/os-releases/master/ubuntu-16.04-x86_64 --never-download").

Long story short, the "New executable" line come from [3], which formats the py_executable, whose value is (unless python interpreter path is set with -p), coming from sys.executable [4], if I am not mistaken.

I didn't dig deeper on the following part, but I expect that some sys.executable can be different on different systems, which would explain why some could return python2 instead of python.
So on those systems, the generated line would be #!/tmp/openstack-venv-builder/venvs/keystone/bin/python2 as shown in the log [5].
(Edit: This probably comes from the shabang of /usr/bin/virtualenv, which
could contain python2 instead of python
Edit 2: That is exact, see [8] for gate tests to prove this)

virtualenv-tools wouldn't recognize those shabangs [6] because they don't end with python (they would end with python2), and therefore won't modify them.

The impact is now that the pip installed packages in the venv are pointing to a wrong executable and therefore can't execute: the path #!/tmp/openstack-venv-builder/venvs/keystone/bin/python2 won't exist on the destination machine.

We should probably get rid of virtualenv-tools, or be more explicit with the executable used, all the way in the process, and replace it with simply line in files (sedding) the py files. The binary files should not be shipped in the virtualenv tgz anyway.

[1]: https://github.com/openstack/openstack-ansible-os_keystone/blob/a48a73089286a370312a35fc7df54a6a3a513fa2/tasks/keystone_install.yml#L165-L171
[2]: https://github.com/fireteam/virtualenv-tools/issues/5
[3]: https://github.com/evrardjp/virtualenv/blob/master/virtualenv.py#L1217
[4]: https://github.com/evrardjp/virtualenv/blob/master/virtualenv.py#L1205
[5]: http://logs.openstack.org/24/504224/40/check/openstack-ansible-deploy-all_metal-ubuntu-xenial/9b0dec0/logs/host/repo/venv_build_keystone-master-x86_64.log.txt.gz
[6]: https://github.com/fireteam/virtualenv-tools/blob/master/virtualenv_tools.py#L68-L69
[7]: https://twitter.com/evrardjp/status/950069466112692224
[8]: https://review.openstack.org/#/c/531687/

description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
Changed in openstack-ansible:
importance: Undecided → Critical
assignee: nobody → Jean-Philippe Evrard (jean-philippe-evrard)

Fix proposed to branch: master
Review: https://review.openstack.org/531731

Changed in openstack-ansible:
status: New → In Progress

Manually moved to new, this way we can discuss it during our triage.

Changed in openstack-ansible:
status: In Progress → New
Changed in openstack-ansible:
status: New → Confirmed
status: Confirmed → In Progress

Change abandoned by Jean-Philippe Evrard (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/533672
Reason: Needs master to merge first!

Reviewed: https://review.openstack.org/531731
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_keystone/commit/?id=851f1063f5ca22d7802f1a782813dbdfe85c0dd7
Submitter: Zuul
Branch: master

commit 851f1063f5ca22d7802f1a782813dbdfe85c0dd7
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 8 12:31:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I75f189b7e8856f6ec4e844ca8fdf2c8c81fb3faa
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/533673
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-plugins/commit/?id=6743087df3f25ba418fb75eee4718a8f8015d85f
Submitter: Zuul
Branch: master

commit 6743087df3f25ba418fb75eee4718a8f8015d85f
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Remove virtualenv-tools in the examples.

    We shouldn't use virtualenv-tools, and it shouldn't appear
    in our documentation.

    Change-Id: I7f29d8b150d1f312422110936d7cf22e0f9cba81
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/533680
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=7d580a1c58877cfd79604b73fea757809a469162
Submitter: Zuul
Branch: master

commit 7d580a1c58877cfd79604b73fea757809a469162
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Remove virtualenv-tools in the examples.

    We shouldn't use virtualenv-tools, and it shouldn't appear
    in our documentation.

    Change-Id: I98d4ac05fa303cad4069c9939a251b07a154286e
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/533678
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-repo_server/commit/?id=92ef35d41843bb306b8e9120bdeaa72287708595
Submitter: Zuul
Branch: master

commit 92ef35d41843bb306b8e9120bdeaa72287708595
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Remove virtualenv-tools in the examples.

    We shouldn't use virtualenv-tools, and it shouldn't appear
    in our documentation.

    Change-Id: I168e400ab8176bc94e48822284441368d8e73441
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/533650
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_designate/commit/?id=8a23491fad868610d958ffa27d335027958af8f2
Submitter: Zuul
Branch: master

commit 8a23491fad868610d958ffa27d335027958af8f2
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I7351e9e7e842b6de4b3e841ee9e44b6b6c514522
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/533663
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_sahara/commit/?id=e2810f4427563591d85b11bb38a89018130b0f0c
Submitter: Zuul
Branch: master

commit e2810f4427563591d85b11bb38a89018130b0f0c
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I5c8b8d102829e84179f94e10a7464008ac5753c4
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/533660
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=307add03721263576a092acbeee8c0283b2addb1
Submitter: Zuul
Branch: master

commit 307add03721263576a092acbeee8c0283b2addb1
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: Iafa7b6d43291fde11a1a072ce624474712ec99eb
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/533667
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_tempest/commit/?id=4314c3e47f1be882727bf3e5be7ba43f67bcf866
Submitter: Zuul
Branch: master

commit 4314c3e47f1be882727bf3e5be7ba43f67bcf866
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: Icbe6b72cebede21de7a63f3a5340ee11a50e6fd3
    Partial-Bug: #1741634

41 comments hidden view all 121 comments

Reviewed: https://review.openstack.org/535842
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_cloudkitty/commit/?id=8191a1329d5a9644751f59cfc2e0683082e82b7c
Submitter: Zuul
Branch: master

commit 8191a1329d5a9644751f59cfc2e0683082e82b7c
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:54:07 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: I8bd55222c6e058c7c26075aab219043c5fb076ed
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535846
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_designate/commit/?id=e0e07a2868a85cd91152539f6e6e361b5cace62a
Submitter: Zuul
Branch: master

commit e0e07a2868a85cd91152539f6e6e361b5cace62a
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:54:07 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: I987ef9bd82cac9aa3d5258006094c0390c1b7aa2
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535845
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_sahara/commit/?id=b21bec6c3183004e03ba04c5073b808dfb2c21ac
Submitter: Zuul
Branch: master

commit b21bec6c3183004e03ba04c5073b808dfb2c21ac
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:54:07 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: Ida7378a3502f52e55bcc9e816c2b4cd77292a5dc
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535816
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ironic/commit/?id=fca90c2398f9d76e7464b4fa1ea9f1801845e79b
Submitter: Zuul
Branch: master

commit fca90c2398f9d76e7464b4fa1ea9f1801845e79b
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:18:00 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: I63efb84603b6503e1f2f171681c6f842a52a9de2
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535809
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_octavia/commit/?id=d79374bb9c36c1b9a66396ecc0a0385565f0550a
Submitter: Zuul
Branch: master

commit d79374bb9c36c1b9a66396ecc0a0385565f0550a
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:08:20 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: I20a5ad10f89bafb841f5718d74317fcd22260742
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535821
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_tacker/commit/?id=32153e2001cc92e55b100bc8840fddf44433c3f3
Submitter: Zuul
Branch: master

commit 32153e2001cc92e55b100bc8840fddf44433c3f3
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:25:54 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: If5b344a5d2282c130ffeb1f012cec3e858901529
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535818
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_gnocchi/commit/?id=deffb07f39c7e99bcb3481adb87cb6eefeed4a9b
Submitter: Zuul
Branch: master

commit deffb07f39c7e99bcb3481adb87cb6eefeed4a9b
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:19:01 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: I70e914103d9cea256ab8e3c898f2cea46bc3a621
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535823
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_barbican/commit/?id=19c40bf969aef794f6dcc4e6a539c788e261efa3
Submitter: Zuul
Branch: master

commit 19c40bf969aef794f6dcc4e6a539c788e261efa3
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:30:32 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: Ib62da7388ac16da44f7a1aa13c3cc7e928daa2e6
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535813
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_neutron/commit/?id=5e0f66b63e5438d9954895908b2537757307d86f
Submitter: Zuul
Branch: master

commit 5e0f66b63e5438d9954895908b2537757307d86f
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:12:27 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: I2c28ba14626e76180fb8e9b93b9a3cbf4bf86014
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535815
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_horizon/commit/?id=744c3733f36ef6c8760cf87d30cdc056b513466a
Submitter: Zuul
Branch: master

commit 744c3733f36ef6c8760cf87d30cdc056b513466a
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:16:44 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: I9b20102a82e26b6772bfab342632dcd53ddf18f3
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535814
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_swift/commit/?id=cbf01f694a15d66881b5bfedc519b9a91d0758c5
Submitter: Zuul
Branch: master

commit cbf01f694a15d66881b5bfedc519b9a91d0758c5
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:14:23 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: I33906abc0e145dc671c2781924c4c20e9df3ba48
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/535844
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=9ffe93f64c120331bc14b69d66ee460e566aa4e1
Submitter: Zuul
Branch: master

commit 9ffe93f64c120331bc14b69d66ee460e566aa4e1
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:54:07 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: I8fe7209662fd198cfc18bb324f74eaf53bc1711d
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/533651
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_glance/commit/?id=4e2dddf278f9870fb8189265d3a65a30b72e5d91
Submitter: Zuul
Branch: master

commit 4e2dddf278f9870fb8189265d3a65a30b72e5d91
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I6cc40b4fc473df29c6e3d7844fde6340694d43bb
    Partial-Bug: #1741634

Changed in openstack-ansible:
assignee: Jean-Philippe Evrard (jean-philippe-evrard) → Mohammed Naser (mnaser)

Reviewed: https://review.openstack.org/533648
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ceilometer/commit/?id=049f1e048ec70263e60a38c1ab55b01fc1f41bcf
Submitter: Zuul
Branch: master

commit 049f1e048ec70263e60a38c1ab55b01fc1f41bcf
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I02b7f6ce8c550a7d64dee908876ccb9a146e959a
    Partial-Bug: #1741634

Changed in openstack-ansible:
assignee: Mohammed Naser (mnaser) → Jean-Philippe Evrard (jean-philippe-evrard)

Reviewed: https://review.openstack.org/535822
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_rally/commit/?id=a3cd6db5be83a51cff6852f1dc6c5b9cea742619
Submitter: Zuul
Branch: master

commit a3cd6db5be83a51cff6852f1dc6c5b9cea742619
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 19 16:29:26 2018 +0000

    Reinitialize the virtualenv

    In the previous patch removing the virtualenv-tools, we've updated
    paths to the proper binaries, but we don't reset the virtualenv
    like what we used to do.

    Change-Id: Ib71894b97ba13a9c7a9f8b36ca9c02cc1cc10da3
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/533657
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_magnum/commit/?id=7b96ecf17b5452ca4735a6ec3e657d251a63f06c
Submitter: Zuul
Branch: master

commit 7b96ecf17b5452ca4735a6ec3e657d251a63f06c
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I7c4f7acf052989bd0947b0c54e2f539639cf834c
    Partial-Bug: #1741634

Changed in openstack-ansible:
assignee: Jean-Philippe Evrard (jean-philippe-evrard) → Mohammed Naser (mnaser)

Reviewed: https://review.openstack.org/533668
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_trove/commit/?id=2b51da5f0a3a1c088c5e8c27a2907e781ac6a131
Submitter: Zuul
Branch: master

commit 2b51da5f0a3a1c088c5e8c27a2907e781ac6a131
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: Iad3a44f35c57d92dcbbfde4acbd86a3a4eb1879d
    Partial-Bug: #1741634

Fix proposed to branch: master
Review: https://review.openstack.org/544106

Changed in openstack-ansible:
assignee: Mohammed Naser (mnaser) → Jean-Philippe Evrard (jean-philippe-evrard)

Reviewed: https://review.openstack.org/533645
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_aodh/commit/?id=01597f254c04f30748f9eeee70aace4bd123eec7
Submitter: Zuul
Branch: master

commit 01597f254c04f30748f9eeee70aace4bd123eec7
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: If934acbcfe81578366d1ecc0c5fec7c6de5b2040
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/545343
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_trove/commit/?id=bd9d47c11bc82437c5f9ff05db0cfb090accfa50
Submitter: Zuul
Branch: stable/queens

commit bd9d47c11bc82437c5f9ff05db0cfb090accfa50
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: Iad3a44f35c57d92dcbbfde4acbd86a3a4eb1879d
    Partial-Bug: #1741634
    (cherry picked from commit 2b51da5f0a3a1c088c5e8c27a2907e781ac6a131)

tags: added: in-stable-queens

Reviewed: https://review.openstack.org/544106
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_cinder/commit/?id=7b16d80ca3288deba6bd4452102cba4596238894
Submitter: Zuul
Branch: master

commit 7b16d80ca3288deba6bd4452102cba4596238894
Author: Jean-Philippe Evrard <email address hidden>
Date: Tue Feb 13 21:50:44 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I6cc40b4fc473df29c6e3d7844fde6340694d43bb
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/545722
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_cinder/commit/?id=7f904825db9472ce1150e8c034cacefae00882c5
Submitter: Zuul
Branch: stable/queens

commit 7f904825db9472ce1150e8c034cacefae00882c5
Author: Jean-Philippe Evrard <email address hidden>
Date: Tue Feb 13 21:50:44 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I6cc40b4fc473df29c6e3d7844fde6340694d43bb
    Partial-Bug: #1741634

Reviewed: https://review.openstack.org/545344
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_trove/commit/?id=747de3b9ec5c9af78de4456bb7d604da5299b13b
Submitter: Zuul
Branch: stable/pike

commit 747de3b9ec5c9af78de4456bb7d604da5299b13b
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: Iad3a44f35c57d92dcbbfde4acbd86a3a4eb1879d
    Partial-Bug: #1741634
    (cherry picked from commit 2b51da5f0a3a1c088c5e8c27a2907e781ac6a131)

tags: added: in-stable-pike
Changed in openstack-ansible:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/562208
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_monasca-agent/commit/?id=89c616ff32a2cb3f871c291ac8ec69a66745dfe3
Submitter: Zuul
Branch: master

commit 89c616ff32a2cb3f871c291ac8ec69a66745dfe3
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:12:02 2018 +0100

    Replace virtualenv-tools with a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: Ic37abfb14303b93dfc80398d6e37706a68135cb0
    Partial-Bug: #1741634
    Partial-Bug: #1764470

Reviewed: https://review.openstack.org/562190
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_panko/commit/?id=3a254e3582f9b9238fe5f6246c5e5c93ade92bbf
Submitter: Zuul
Branch: master

commit 3a254e3582f9b9238fe5f6246c5e5c93ade92bbf
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:53:23 2018 +0100

    Replace virtualenv-tools with a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I8b40b4bceaf90fadecb4512c0cb9dbee143fe987
    Partial-Bug: #1741634
    Partial-Bug: #1764470

Reviewed: https://review.openstack.org/562677
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_monasca-agent/commit/?id=2366c457ef454a25781a07318624b60c4784c979
Submitter: Zuul
Branch: stable/queens

commit 2366c457ef454a25781a07318624b60c4784c979
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:12:02 2018 +0100

    Replace virtualenv-tools with a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: Ic37abfb14303b93dfc80398d6e37706a68135cb0
    Partial-Bug: #1741634
    Partial-Bug: #1764470
    (cherry picked from commit 89c616ff32a2cb3f871c291ac8ec69a66745dfe3)

Reviewed: https://review.openstack.org/562720
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_panko/commit/?id=6c3790d9d51baf7fc38d39e82d8e03c8ded17e29
Submitter: Zuul
Branch: stable/queens

commit 6c3790d9d51baf7fc38d39e82d8e03c8ded17e29
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 10:53:23 2018 +0100

    Replace virtualenv-tools with a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I8b40b4bceaf90fadecb4512c0cb9dbee143fe987
    Partial-Bug: #1741634
    Partial-Bug: #1764470
    (cherry picked from commit 3a254e3582f9b9238fe5f6246c5e5c93ade92bbf)

Reviewed: https://review.openstack.org/562971
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_aodh/commit/?id=7c1e162ebafea5c8ab807e532c0844a7fc1d3344
Submitter: Zuul
Branch: stable/queens

commit 7c1e162ebafea5c8ab807e532c0844a7fc1d3344
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Jan 15 13:54:00 2018 +0000

    Replace virtualenv-tools by a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: If934acbcfe81578366d1ecc0c5fec7c6de5b2040
    Partial-Bug: #1741634
    (cherry picked from commit 01597f254c04f30748f9eeee70aace4bd123eec7)

Reviewed: https://review.openstack.org/562206
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_monasca/commit/?id=cac7008e57e701a9f8fed5fe5ad4d3d68b9c98bd
Submitter: Zuul
Branch: master

commit cac7008e57e701a9f8fed5fe5ad4d3d68b9c98bd
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:08:23 2018 +0100

    Replace virtualenv-tools with a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I62ae0b1f406f102fcb184913c5a6de54bb84c4c2
    Partial-Bug: #1741634
    Partial-Bug: #1764470

Reviewed: https://review.openstack.org/564052
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_monasca/commit/?id=9b4bfa1a2c02fde89feb01fd3a113ec83c3c3c67
Submitter: Zuul
Branch: stable/queens

commit 9b4bfa1a2c02fde89feb01fd3a113ec83c3c3c67
Author: Jesse Pretorius <email address hidden>
Date: Wed Apr 18 11:08:23 2018 +0100

    Replace virtualenv-tools with a script

    virtualenv-tools has a bug which gets triggered in gates: it can't
    change the shebang of a virtualenv python bin/ files if they
    were generated with a virtualenv script whose shebang ends with
    python2 instead of python.

    Because we can't modify virtualenv-tools, we use shell scripts
    instead.

    Change-Id: I62ae0b1f406f102fcb184913c5a6de54bb84c4c2
    Partial-Bug: #1741634
    Partial-Bug: #1764470
    (cherry picked from commit cac7008e57e701a9f8fed5fe5ad4d3d68b9c98bd)

Displaying first 40 and last 40 comments. View all 121 comments or add a comment.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers