P-Q upgrade fails due to change in inventory

[Jean-Philippe Evrard]

Here is an extract of my log:

    xenial: System is bootstrapped and ready for use.
    xenial: + echo 'System is bootstrapped and ready for use.'
    xenial: /opt/openstack-ansible/playbooks /opt/openstack-ansible
    xenial: basename ${file_part} .yml
    xenial: openstack-ansible /opt/openstack-ansible/scripts/upgrade-utilities/playbooks/ansible_fact_cleanup.yml
    xenial: Variable files: "-e @/etc/openstack_deploy/user_secrets.yml -e @/etc/openstack_deploy/user_variables.yml "
    xenial: [WARNING]: Unable to parse /opt/openstack-ansible/playbooks/inventory as an
    xenial: inventory source
    xenial: [WARNING]: No inventory was parsed, only implicit localhost is available
    xenial: [WARNING]: Could not match supplied host pattern, ignoring: all
    xenial: [WARNING]: provided hosts list is empty, only localhost is available

Re-running it outside my vagrant environment works, which proves there are variables still hanging around in the process, even after: https://review.openstack.org/#/c/531123/

[Jean-Philippe Evrard (jean-philippe-evrard)]

As you can see, the folder is /opt/openstack-ansible/playbooks/inventory instead of the current /opt/openstack-ansible/inventory.

The wrapper rc file is correct:
export ANSIBLE_INVENTORY="${ANSIBLE_INVENTORY:-/opt/openstack-ansible/inventory/dynamic_inventory.py,/etc/openstack_deploy/inventory.ini}"

[Jean-Philippe Evrard (jean-philippe-evrard)]

Modifying patch 531123 (to remove the ANSIBLE_INVENTORY variable definition) opened a new series of issues namely:

    xenial: [WARNING]: * Failed to parse /opt/openstack-
    xenial: ansible/inventory/dynamic_inventory.py with script plugin: Inventory script
    xenial: (/opt/openstack-ansible/inventory/dynamic_inventory.py) had an execution error:
    xenial: Traceback (most recent call last): File "/opt/openstack-
    xenial: ansible/inventory/dynamic_inventory.py", line 80, in <module> output =
    xenial: generate.main(**all_args) File "/opt/openstack-
    xenial: ansible/osa_toolkit/generate.py", line 1134, in main user_defined_config
    xenial: File "/opt/openstack-ansible/osa_toolkit/generate.py", line 740, in
    xenial: container_skel_load address_prefix=p_net.get('address_prefix') File
    xenial: "/opt/openstack-ansible/osa_toolkit/generate.py", line 576, in
    xenial: _add_additional_networks address_prefix File "/opt/openstack-
    xenial: ansible/osa_toolkit/generate.py", line 576, in _add_additional_networks
    xenial: address_prefix File "/opt/openstack-ansible/osa_toolkit/generate.py", line
    xenial: 646, in _add_additional_networks phg = user_config[cphg][container_host]
    xenial: KeyError: 'aio1_neutron_agents_container-a551b468'
    xenial: [WARNING]: * Failed to parse /opt/openstack-
    xenial: ansible/inventory/dynamic_inventory.py with ini plugin: /opt/openstack-
    xenial: ansible/inventory/dynamic_inventory.py:18: Expected key=value host variable
    xenial: assignment, got: argparse
    xenial: [WARNING]: Unable to parse /opt/openstack-
    xenial: ansible/inventory/dynamic_inventory.py as an inventory source
    xenial: [WARNING]: Unable to parse /etc/openstack_deploy/inventory.ini as an inventory
    xenial: source
    xenial: [WARNING]: No inventory was parsed, only implicit localhost is available
    xenial: [WARNING]: Could not match supplied host pattern, ignoring: all
    xenial: [WARNING]: provided hosts list is empty, only localhost is available

[Jean-Philippe Evrard (jean-philippe-evrard)]

This seems related to https://github.com/openstack/openstack-ansible/blob/master/inventory/dynamic_inventory.py#L26 will try a patch now.

[Jean-Philippe Evrard (jean-philippe-evrard)]

Loading the dynamic inventory manually gives me the following:

  File "/opt/openstack-ansible/osa_toolkit/generate.py", line x, in _add_additional_networks
    phg = user_config[cphg][container_host]
KeyError: 'aio1_neutron_agents_container-a551b468'

Needs further investigation to see if it's related to the hyper converged work.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531123
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=81e1f8d173d663e5f7f6a385e89359c3e9d75a54
Submitter: Zuul
Branch: master

commit 81e1f8d173d663e5f7f6a385e89359c3e9d75a54
Author: Jean-Philippe Evrard <email address hidden>
Date: Thu Jan 4 10:43:26 2018 +0000

    Include P-Q changes into the upgrade script

    We need to include changes in the upgrade script to handle
    the changes done during the Queens timeframe:

    - Inventory is fixed to prevent a stacktrace if a container
      default was moved from is_metal: False to is_metal: True,
      and now respects existing container properties.
    - Ensuring previous inventory location isn't overriding the
      Queens inventory location in memory, by unsetting
      ANSIBLE_INVENTORY.
    - Ensuring all containers are using the repo that was build
      during the upgrade.

    Change-Id: I0fd3a8803bf345ccad07dc97968e104cd0a7bf70
    Partial-Bug: #1741462
    Closes-Bug: #1675810