got an unexpected keyword argument 'domain' when using keystone federation

Bug #1733108 reported by Michael Rice
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Jesse Pretorius

Bug Description

when using keystone federation an error is raised in the keystone ansible plugin:

failed: [aio1_keystone_container-12c3ddec] (item={u'project': u'fedproject', u'group': u'fedgroup', u'domain': u'Default', u'role': u'_member_'}) => {"failed": true, "item": {"domain": "Default", "group": "fedgroup", "project": "fedproject", "role": "_member_"}, "module_stderr": "mesg: ttyname failed: Inappropriate ioctl for device\nTraceback (most recent call last):\n File \"/tmp/ansible_5jk8kW/ansible_module_keystone.py\", line 1458, in <module>\n main()\n File \"/tmp/ansible_5jk8kW/ansible_module_keystone.py\", line 1452, in main\n km.command_router()\n File \"/tmp/ansible_5jk8kW/ansible_module_keystone.py\", line 484, in command_router\n facts = action(variables=action_command['variables'])\n File \"/tmp/ansible_5jk8kW/ansible_module_keystone.py\", line 966, in ensure_group_role\n name=role_name, group=group, project=project, domain=domain\nTypeError: _get_group_roles() got an unexpected keyword argument 'domain'\n", "module_stdout": "", "msg": "MODULE FAILURE"}

In the keystone library the function _get_group_roles() is missing the domain parameter.

Revision history for this message
Michael Rice (michael-rice) wrote :

I have a patch coming for this and will need it to go all the way back to Newton because we have a customer install next week that will depend on this.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-plugins (master)

Fix proposed to branch: master
Review: https://review.openstack.org/521283

Changed in openstack-ansible:
assignee: nobody → Michael Rice (michael-rice)
status: New → In Progress
Changed in openstack-ansible:
assignee: Michael Rice (michael-rice) → Jesse Pretorius (jesse-pretorius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-plugins (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/521600

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-plugins (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/521601

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-plugins (stable/newton)

Reviewed: https://review.openstack.org/521601
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-plugins/commit/?id=776bb05646e151a9019dd252bfdfa25862a81e0c
Submitter: Zuul
Branch: stable/newton

commit 776bb05646e151a9019dd252bfdfa25862a81e0c
Author: Michael Rice <email address hidden>
Date: Sat Nov 18 13:07:18 2017 -0600

    Add missing domain parameter to _get_group_roles

    Adds missing 'domain' parameter to function which
    was causing errors when using keystone federation.

    Change-Id: Icfc06feae806a9faf8f4d12bf2281dd6c9772989
    Closes-Bug: 1733108
    Signed-off-by: Michael Rice <email address hidden>

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-plugins (master)

Reviewed: https://review.openstack.org/521283
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-plugins/commit/?id=8ead9b26853dfe8a23053059d94c3b6839347ebb
Submitter: Zuul
Branch: master

commit 8ead9b26853dfe8a23053059d94c3b6839347ebb
Author: Michael Rice <email address hidden>
Date: Sat Nov 18 13:07:18 2017 -0600

    Add missing domain parameter to _get_group_roles

    Adds missing 'domain' parameter to function which
    was causing errors when using keystone federation.

    Change-Id: Icfc06feae806a9faf8f4d12bf2281dd6c9772989
    Closes-Bug: 1733108
    Signed-off-by: Michael Rice <email address hidden>

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-plugins (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/521926

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-plugins (stable/pike)

Reviewed: https://review.openstack.org/521926
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-plugins/commit/?id=943c196d1155907a6e1a191e21f156c225fbf7f8
Submitter: Zuul
Branch: stable/pike

commit 943c196d1155907a6e1a191e21f156c225fbf7f8
Author: Michael Rice <email address hidden>
Date: Sat Nov 18 13:07:18 2017 -0600

    Add missing domain parameter to _get_group_roles

    Adds missing 'domain' parameter to function which
    was causing errors when using keystone federation.

    Change-Id: Icfc06feae806a9faf8f4d12bf2281dd6c9772989
    Closes-Bug: 1733108
    Signed-off-by: Michael Rice <email address hidden>
    (cherry picked from commit 8ead9b26853dfe8a23053059d94c3b6839347ebb)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-plugins (stable/ocata)

Reviewed: https://review.openstack.org/521600
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-plugins/commit/?id=4840348680c65bbd30e357f7dc2d81f3cdbacd53
Submitter: Zuul
Branch: stable/ocata

commit 4840348680c65bbd30e357f7dc2d81f3cdbacd53
Author: Michael Rice <email address hidden>
Date: Sat Nov 18 13:07:18 2017 -0600

    Add missing domain parameter to _get_group_roles

    Adds missing 'domain' parameter to function which
    was causing errors when using keystone federation.

    Change-Id: Icfc06feae806a9faf8f4d12bf2281dd6c9772989
    Closes-Bug: 1733108
    Signed-off-by: Michael Rice <email address hidden>

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins 14.2.13

This issue was fixed in the openstack/openstack-ansible-plugins 14.2.13 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins 16.0.5

This issue was fixed in the openstack/openstack-ansible-plugins 16.0.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins 15.1.13

This issue was fixed in the openstack/openstack-ansible-plugins 15.1.13 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-plugins 17.0.0.0b2

This issue was fixed in the openstack/openstack-ansible-plugins 17.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.