os_ceilometer fails without swift installed

[Ondrej Vasko]

Hello OSA,

I am doing upgrade from Ocata (stable/ocata) to Pike (stable/pike) manually by using official guide [1].

When running last step - `openstack-ansible setup-openstack.yml`, the playbook for `os_ceilometer` fails because it has not defined variable `swift_system_comment`.

Now this fails in my environment, where I do not have OS Swift installed but on the other hand I have defined `swift_ceilometer_enabled: false` in `user_variables.yml`.

The play that fails is located in file `os_ceilometer/tasks/ceilometer_pre_install.yml` which in my opinion should respect setting of `swift_ceilometer_enabled`, or if it is necessary to do this task, it should include variables needed for that.

Edit: pasted error log

TASK [os_ceilometer : Create the swift system user and add to ceilometer group] **************************************************************************************************************************************************************
Thursday 05 October 2017 14:12:26 +0200 (0:00:03.248) 1:49:14.169 ******
fatal: [controller2_ceilometer_api_container-535462bf]: FAILED! => {"failed": true, "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'swift_system_comment' is undefined\n\nThe error appears to have been in '/etc/ansible/roles/os_ceilometer/tasks/ceilometer_pre_install.yml': line 32, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Create the swift system user and add to ceilometer group\n ^ here\n"}

[1] https://docs.openstack.org/openstack-ansible/pike/user/manual-upgrade.html

[Jean-Philippe Evrard (jean-philippe-evrard)]

We have sadly not enough resources to triage this bug, and confirm it.

[Jean-Philippe Evrard (jean-philippe-evrard)]

I am adding this bug to the list of things to do for telemetry in openstack-ansible.

[Jean-Philippe Evrard (jean-philippe-evrard)]

https://etherpad.openstack.org/p/osa-telemetry-stack-fixing

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/541374

[Ondrej Vasko (ondrej.vasko)]

dobrý deň,

ďakujem za Váš e-mail, momentálne som mimo kancelárie. Vrátim sa
dňa 08.02.2018. V prípade potreby kontaktujte, prosím, obchodné
oddelenie (<email address hidden>, [phone]) alebo technickú podporu
(<email address hidden>, [phone]).

Thank you for your message. I am currently out of the office. I will
be returning on 08.02.2018. If you need assistance before then, you
may contact sales dpt. (<email address hidden>, [phone]) or
techsupport (<email address hidden>, [phone]).

** Changed in: openstack-ansible
     Assignee: (unassigned) => Mohammed Naser (mnaser)

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1721554

Title:
  os_ceilometer fails without swift installed

Status in openstack-ansible:
  In Progress

Bug description:
  Hello OSA,

  I am doing upgrade from Ocata (stable/ocata) to Pike (stable/pike)
  manually by using official guide [1].

  When running last step - `openstack-ansible setup-openstack.yml`, the
  playbook for `os_ceilometer` fails because it has not defined variable
  `swift_system_comment`.

  Now this fails in my environment, where I do not have OS Swift
  installed but on the other hand I have defined
  `swift_ceilometer_enabled: false` in `user_variables.yml`.

  The play that fails is located in file
  `os_ceilometer/tasks/ceilometer_pre_install.yml` which in my opinion
  should respect setting of `swift_ceilometer_enabled`, or if it is
  necessary to do this task, it should include variables needed for
  that.

  Edit: pasted error log

  TASK [os_ceilometer : Create the swift system user and add to ceilometer group] **************************************************************************************************************************************************************
  Thursday 05 October 2017 14:12:26 +0200 (0:00:03.248) 1:49:14.169 ******
  fatal: [controller2_ceilometer_api_container-535462bf]: FAILED! => {"failed": true, "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'swift_system_comment' is undefined\n\nThe error appears to have been in '/etc/ansible/roles/os_ceilometer/tasks/ceilometer_pre_install.yml': line 32, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Create the swift system user and add to ceilometer group\n ^ here\n"}

  [1] https://docs.openstack.org/openstack-ansible/pike/user/manual-
  upgrade.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/openstack-ansible/+bug/1721554/+subscriptions

[Ondrej Vasko (ondrej.vasko)]

dobrý deň,

ďakujem za Váš e-mail, momentálne som mimo kancelárie. Vrátim sa
dňa 08.02.2018. V prípade potreby kontaktujte, prosím, obchodné
oddelenie (<email address hidden>, [phone]) alebo technickú podporu
(<email address hidden>, [phone]).

Thank you for your message. I am currently out of the office. I will
be returning on 08.02.2018. If you need assistance before then, you
may contact sales dpt. (<email address hidden>, [phone]) or
techsupport (<email address hidden>, [phone]).

Fix proposed to branch: master
Review: https://review.openstack.org/541374

** Changed in: openstack-ansible
       Status: New => In Progress

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1721554

Title:
  os_ceilometer fails without swift installed

Status in openstack-ansible:
  In Progress

Bug description:
  Hello OSA,

  I am doing upgrade from Ocata (stable/ocata) to Pike (stable/pike)
  manually by using official guide [1].

  When running last step - `openstack-ansible setup-openstack.yml`, the
  playbook for `os_ceilometer` fails because it has not defined variable
  `swift_system_comment`.

  Now this fails in my environment, where I do not have OS Swift
  installed but on the other hand I have defined
  `swift_ceilometer_enabled: false` in `user_variables.yml`.

  The play that fails is located in file
  `os_ceilometer/tasks/ceilometer_pre_install.yml` which in my opinion
  should respect setting of `swift_ceilometer_enabled`, or if it is
  necessary to do this task, it should include variables needed for
  that.

  Edit: pasted error log

  TASK [os_ceilometer : Create the swift system user and add to ceilometer group] **************************************************************************************************************************************************************
  Thursday 05 October 2017 14:12:26 +0200 (0:00:03.248) 1:49:14.169 ******
  fatal: [controller2_ceilometer_api_container-535462bf]: FAILED! => {"failed": true, "msg": "the field 'args' has an invalid value, which appears to include a variable that is undefined. The error was: 'swift_system_comment' is undefined\n\nThe error appears to have been in '/etc/ansible/roles/os_ceilometer/tasks/ceilometer_pre_install.yml': line 32, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Create the swift system user and add to ceilometer group\n ^ here\n"}

  [1] https://docs.openstack.org/openstack-ansible/pike/user/manual-
  upgrade.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/openstack-ansible/+bug/1721554/+subscriptions

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/541374
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_ceilometer/commit/?id=0772d34100bd48e055442f4696b94d9f08a8e6a7
Submitter: Zuul
Branch: master

commit 0772d34100bd48e055442f4696b94d9f08a8e6a7
Author: Mohammed Naser <email address hidden>
Date: Tue Feb 6 12:00:13 2018 -0500

    Skip creation of Swift user if Ceilometer support is disabled

    This patch skips the creation of a Swift user if the integration
    for Swift in Ceilometer is disabled.

    Change-Id: Ic5b619ee7f2dd0bffe018af57d203a980e668760
    Closes-Bug: #1721554

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_ceilometer 17.0.0.0rc1 release candidate.