lxc- host role failed due to absense of unzip and lack of cleanup of old /tmp/rootfs.tar.xz, Release Pike

[bhujay kumar]

Scenario : Pike Release : multios set up with xenial and centos7.4: Async job for Ensure image has been pre-staged failed due to some network issue .

Download for /tmp/rootfs.tar.xz remained incomplete.

In the 2nd run

1)Place container rootfs , unarchive: module failed due to absense of unzip in centos
2)Retrieve base image play could not import-tar /tmp/rootfs.tar.xz due to corrupt file at tmp .

Proposed solun:

1)Ensure unzip is present duing pkg install for centos
2) Cleanup of old downloaded file / or checking file integrity before retrieve base image

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/507639

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507639
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_hosts/commit/?id=49cb0ebe70d85591da22dd854f66d6f41b4f16d0
Submitter: Jenkins
Branch: master

commit 49cb0ebe70d85591da22dd854f66d6f41b4f16d0
Author: Marc Gariepy <email address hidden>
Date: Tue Sep 26 14:03:37 2017 -0400

    Add unzip to Centos pkg list

    Unzip is needed for ansible unarchive module to work properly.

    Change-Id: I315b4bba0c91c82ffe71d1fbf763409774ce1642
    Partial-Bug: #1718979

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/511952

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/511952
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_hosts/commit/?id=8e304ba6c8879af7726f20e50336c42544f8f736
Submitter: Zuul
Branch: stable/pike

commit 8e304ba6c8879af7726f20e50336c42544f8f736
Author: Marc Gariepy <email address hidden>
Date: Tue Sep 26 14:03:37 2017 -0400

    Add unzip to Centos pkg list

    Unzip is needed for ansible unarchive module to work properly.

    Change-Id: I315b4bba0c91c82ffe71d1fbf763409774ce1642
    Partial-Bug: #1718979
    (cherry picked from commit 49cb0ebe70d85591da22dd854f66d6f41b4f16d0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/516487
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_hosts/commit/?id=076493d01485822b1efbc962478150278ecbf566
Submitter: Zuul
Branch: master

commit 076493d01485822b1efbc962478150278ecbf566
Author: Kevin Carter <email address hidden>
Date: Mon Oct 30 20:54:12 2017 -0500

    Update role for efficiency and to make better use modules

    The LXC host role can be tuned up for better overall efficiency.

    Highlights:
    * Move async wait to a later position for role performance. The
      async wait we're doing can be moved elsewhere in the role so
      that we're able to do more in parallel. This change simply moves
      the async wait to a postition just before its required.
    * Move container creation tasks into their own sub-files which are
      accessed using dynamic routing.
    * Several syntatic items were cleaned up.
    * All of the basic cache cleanup has been moved to handlers.

    Closes-Bug: #1718979
    Change-Id: I26eae11be8f7d5b691fbccd3d2fe1cfb21b8cf55
    Signed-off-by: Kevin Carter <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/517341

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517341
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_hosts/commit/?id=be93ac8d3f1ba7f1e786c835436b4839cfbc0932
Submitter: Zuul
Branch: stable/pike

commit be93ac8d3f1ba7f1e786c835436b4839cfbc0932
Author: Kevin Carter <email address hidden>
Date: Mon Oct 30 20:54:12 2017 -0500

    Combined backport to fix issues and enhance efficiency

    The LXC host role can be tuned up for better overall efficiency.

    Highlights:
    * Move async wait to a later position for role performance. The
      async wait we're doing can be moved elsewhere in the role so
      that we're able to do more in parallel. This change simply moves
      the async wait to a postition just before its required.
    * Move container creation tasks into their own sub-files which are
      accessed using dynamic routing.
    * Several syntatic items were cleaned up.
    * All of the basic cache cleanup has been moved to handlers.

    These changes further optimise the lxc_host role so that it's using more
    of the built in modules and making better use of handlers.

    Moving the dnsmasq process to a unit file gives operators the ability to
    restart the dnsmasq process if there's an issue with the service. It
    also ensures the service stays running as systemd will take better care
    of the service by isolating it within a specific cgroup, ensuring good
    reporting and memory management, and providing the ability to recover
    from failures in an automated way.

    Closes-Bug: #1718979
    Closes-Bug: #1518485
    (cherry picked from commit 076493d01485822b1efbc962478150278ecbf566)
    (cherry picked from commit 53a6cce9ed08dc5005a42f064a3b8811d65f9d70)

    Change-Id: If7dfbae19429cb033d7fd7e33f1423627f091534

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts 16.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-lxc_hosts 17.0.0.0b2 development milestone.