Designate role setting http for public uri

[Albert Mikaelyan]

Designate role does not use https for public uri in its defaults

Instead of using the openstack uri variables when available:

openstack_service_publicuri_proto
openstack_service_adminuri_proto
openstack_service_internaluri_proto

It uses it's own variable which is set to http, and only that:
https://github.com/openstack/openstack-ansible-os_designate/blob/master/defaults/main.yml#L129

Keystone has a good example for correct way of using this:
https://github.com/openstack/openstack-ansible-os_keystone/blob/master/defaults/main.yml#L148

The proto is set instead in ansible's inventory:
https://github.com/openstack/openstack-ansible/blob/master/group_vars/designate_all.yml#L24

Needs to align the designate role to other roles, and set to https via defaults.

[Albert Mikaelyan (tahvok)]

After checking, openstack ansible does set the proper proto for designate.

This is done in playbooks/inventory/group_vars/designate_all.yml

Should this be aligned with other services, and done in designate defaults?

[Albert Mikaelyan (tahvok)]

Fix proposed. Review: https://review.openstack.org/#/c/504147

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/504125
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_designate/commit/?id=4b009ca349a9f06188c8dc2d07b6a147e4f29669
Submitter: Jenkins
Branch: master

commit 4b009ca349a9f06188c8dc2d07b6a147e4f29669
Author: Albert Mikaelyan <email address hidden>
Date: Thu Sep 14 20:01:34 2017 +0300

    Use openstack proto variable in defaults

    Use openstack service proto variable in defaults for designate endpoints
    This will align the designate role with other roles method

    Partial-Bug: 1717273
    Change-Id: I033940c29e91945a96bf9a4a9c9058badac37c5e

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/504147
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=7ba5bed1cc4f1f51b8a43df95262a6e0a40ac8e6
Submitter: Jenkins
Branch: master

commit 7ba5bed1cc4f1f51b8a43df95262a6e0a40ac8e6
Author: Albert Mikaelyan <email address hidden>
Date: Thu Sep 14 20:40:43 2017 +0300

    Delete not needed designate variables.

    The varibales are set in designate role defaults with the dependent change.
    No need to set them in inventory any more.

    Closes-Bug: 1717273
    Change-Id: Ia6624b8110f1783133ff30a1ccdafb90f84e1897
    Depends-On: I033940c29e91945a96bf9a4a9c9058badac37c5e

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 17.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 17.0.0.0b2 development milestone.