rsyslog_client is producing broken config files

Bug #1716138 reported by Logan V
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Logan V

Bug Description

rsyslog_client when running after lxc_hosts is producing a logging configuration that looks like this:
# Ansible managed

# Log files
$InputFileName s
$InputFileTag s:
$InputFileStateFile state-s
$InputFileFacility local7
$InputFilePollInterval 1
$InputFilePersistStateInterval 1
$InputRunFileMonitor

$InputFileName e
$InputFileTag e:
$InputFileStateFile state-e
$InputFileFacility local7
$InputFilePollInterval 1
$InputFilePersistStateInterval 1
$InputRunFileMonitor

$InputFileName t
$InputFileTag t:
$InputFileStateFile state-t
$InputFileFacility local7
$InputFilePollInterval 1
$InputFilePersistStateInterval 1
$InputRunFileMonitor

$InputFileName (
$InputFileTag (:
$InputFileStateFile state-(
$InputFileFacility local7
$InputFilePollInterval 1
$InputFilePersistStateInterval 1
$InputRunFileMonitor

$InputFileName )
$InputFileTag ):
$InputFileStateFile state-)
$InputFileFacility local7
$InputFilePollInterval 1
$InputFilePersistStateInterval 1
$InputRunFileMonitor

Causing this rsyslog startup failure here: http://logs.openstack.org/49/501249/6/check/gate-openstack-ansible-openstack-ansible-ceph-ubuntu-xenial/83d4f27/logs/ara/result/2722d656-9221-48a5-808a-8794783c5c60/

The reason why this is happening is because the log file list is currently cast as a string containing "set()" there, due to not being cast as a list.

TASK [rsyslog_client : Union the log files] ****************************************************************************************************************
Saturday 09 September 2017 15:12:55 +0000 (0:00:00.836) 0:00:07.804 ****
ok: [aio1]

TASK [rsyslog_client : Set rsyslog_client_all_log_files when log_files does not exist] *********************************************************************
Saturday 09 September 2017 15:12:55 +0000 (0:00:00.644) 0:00:08.448 ****

TASK [rsyslog_client : debug] ******************************************************************************************************************************
Saturday 09 September 2017 15:12:55 +0000 (0:00:00.020) 0:00:08.469 ****
ok: [aio1] => {
    "msg": "set()"
}

Changed in openstack-ansible:
assignee: nobody → Logan V (loganv)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-rsyslog_client (master)

Reviewed: https://review.openstack.org/502252
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rsyslog_client/commit/?id=424f2ae776b8917883fdcead05750df02baf0052
Submitter: Jenkins
Branch: master

commit 424f2ae776b8917883fdcead05750df02baf0052
Author: Logan V <email address hidden>
Date: Sat Sep 9 10:21:14 2017 -0500

    Cast the log file list as a list

    The log file list, when empty, is cast as a string containing "set()",
    which produces a broken log config file.

    Closes-Bug: #1716138
    Change-Id: If429ba3b63252d066db5a410b80ff29e813d96e1

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-rsyslog_client (stable/pike)

Reviewed: https://review.openstack.org/502413
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rsyslog_client/commit/?id=a78e428e5d550c383bb0d1970c48c634beba4c06
Submitter: Jenkins
Branch: stable/pike

commit a78e428e5d550c383bb0d1970c48c634beba4c06
Author: Jean-Philippe Evrard <email address hidden>
Date: Thu Aug 17 08:35:53 2017 +0000

    Fix postrotate

    Combined backport of:
    - https://review.openstack.org/#/c/494438/
    - https://review.openstack.org/#/c/502252/

    Change-Id: I08357260e45919d9e71586cac6b9ce413adffc22
    Closes-Bug: #1699875
    Closes-Bug: #1709291
    Closes-Bug: #1716138

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-rsyslog_client (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/514350

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-rsyslog_client (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/514357

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-rsyslog_client (stable/newton)

Reviewed: https://review.openstack.org/514357
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-rsyslog_client/commit/?id=69d69c5100dbdbe83fa85c5a94eb15fdfbfb1198
Submitter: Zuul
Branch: stable/newton

commit 69d69c5100dbdbe83fa85c5a94eb15fdfbfb1198
Author: Jean-Philippe Evrard <email address hidden>
Date: Thu Aug 17 08:35:53 2017 +0000

    Fix postrotate

    Adjustment of the restart command for Xenial and Trusty.

    Combined backport of:
    - https://review.openstack.org/#/c/494438/
    - https://review.openstack.org/#/c/502252/

    Change-Id: I08357260e45919d9e71586cac6b9ce413adffc22
    Closes-Bug: #1699875
    Closes-Bug: #1709291
    Closes-Bug: #1716138

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-rsyslog_client 17.0.0.0b1

This issue was fixed in the openstack/openstack-ansible-rsyslog_client 17.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-rsyslog_client 16.0.2

This issue was fixed in the openstack/openstack-ansible-rsyslog_client 16.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-rsyslog_client 15.1.12

This issue was fixed in the openstack/openstack-ansible-rsyslog_client 15.1.12 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-rsyslog_client 14.2.12

This issue was fixed in the openstack/openstack-ansible-rsyslog_client 14.2.12 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.