make urlparse import python3 comaptible

Bug #1712546 reported by Jakob Hasselmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Amy Marrich

Bug Description

Deploying the RC1 Release of Pike we ran into an import issue regarding the import of urlparse:

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ImportError: No module named 'urlparse'
fatal: [localhost]: FAILED! => {"failed": true, "msg": "Unexpected failure during module execution.", "stdout": ""}

We hit this issue twice:

/opt/openstack-ansible/scripts/release-yaml-file-prep.py
/etc/ansible/roles/plugins/osa-filters.py

The osa-filters.py seems to have a fix which we somehow did not yet receive (mbe needs merging for rc2): https://github.com/openstack/openstack-ansible-plugins/commit/057ed9a808cbd8885380ea92739421afbabcfbcb

The release-yaml-file-prep.py still needs the correct import statement (copied from osa-filters.py):

-import urlparse
+try:
+ from urllib.parse import urlparse
+except ImportError:
+ from urlparse import urlparse

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/496821

Changed in openstack-ansible:
assignee: nobody → Jakob Hasselmann (jafeha)
status: New → In Progress
assignee: Jakob Hasselmann (jafeha) → Amy Marrich (amy-marrich)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/496821
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=85d24272bc9288f83ce263d2a9e242dd5f270a3a
Submitter: Jenkins
Branch: master

commit 85d24272bc9288f83ce263d2a9e242dd5f270a3a
Author: Jakob Hasselmann <email address hidden>
Date: Wed Aug 23 18:10:11 2017 +0200

    Fixes python3 non-compatible import of urlparse

        Implements: release-yaml-file-prep.py python3 compatibility
        Closes-Bug: #1712546

    Change-Id: I97f46c017b2cad6f8be757c529ccacd6c971757c

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 17.0.0.0b1

This issue was fixed in the openstack/openstack-ansible 17.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 17.0.0.0b2

This issue was fixed in the openstack/openstack-ansible 17.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.