cinder-manage service list does not output the full hostname

Bug #1712372 reported by Matthew Thode
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Matthew Thode

Bug Description

database has an alternate hostname

# mysql cinder -Be 'select host,`binary` from services where `binary`="cinder-volume"'

host binary
123456-cinder01.foo-bar-1.baz.example.com@lvm cinder-volume

vs what is returned by cinder-manage service list

Binary Host Zone Status State Updated At RPC Version Object Version Cluster cinder-volume 123456-cinder01 nova enabled XXX 2017-08-22 01:15:36 None None

The current output uses svc.host.partition('.')[0]. I'd like to change it to svc.host

It was added in this commit without reasoning behind the split. https://github.com/openstack/cinder/commit/1c77c5416417299953cebabbd88d7385d0c57cd4

Revision history for this message
Jean-Philippe Evrard (jean-philippe-evrard) wrote :

Yes, I think consistency here is good, in case we want to automate an upgrade for example.
If we are following the documentation, we have to remove the services using cinder-manage.

So, it makes sense to automate that with the output of the cinder-manage service list command.

This is, IMO, a consistency bug.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/496284

Changed in cinder:
assignee: nobody → Matthew Thode (prometheanfire)
status: New → In Progress
summary: - cidner-manage service list does not output the full hostname
+ cinder-manage service list does not output the full hostname
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/496284
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9a97496a0032e61239b0a61e2bd5cb3e2ac7a644
Submitter: Jenkins
Branch: master

commit 9a97496a0032e61239b0a61e2bd5cb3e2ac7a644
Author: Matthew Thode <email address hidden>
Date: Tue Aug 22 10:09:47 2017 -0500

    Make cinder-manage service list to print full host

    cinder service-list prints the full host when asked, cinder-manage
    service-list just prints the short hostname, which is not usable.

    123456-cinder01.foo-bar-1.baz.example.com@lvm vs 123456-cinder01

    Update cinder-manage service list to match cinder service-list

    Change-Id: Ie8b0b437aed0fe42a8938747b90a4e83e2c80c0d
    Closes-Bug: #1712372

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.0.0b1

This issue was fixed in the openstack/cinder 12.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.