ANSIBLE_ROLE_FETCH_MODE = 'git-clone' should not source openstack-ansible.rc

[Jesse Pretorius]

In the bootstrap-ansible script, if the fetch mode is set to git-clone then the ansible-playbook wrapper will source the openstack-ansible.rc file because it's executed from within the openstack-ansible git tree.

It's probably best for that instance of the ansible-playbook command to be executed directly from the venv instead of using the wrapper, unless there's a different way to avoid sourcing the openstack-ansible.rc file and therefore including the dynamic inventory, plugins, etc which may not be present, or may be there from a previous clone and therefore cause unwanted side-effects.

[Jean-Philippe Evrard (jean-philippe-evrard)]

We just need to adapt the openstack-ansible.rc with a full path.

[Jesse Pretorius (jesse-pretorius)]

ie in https://github.com/openstack/openstack-ansible/blob/master/scripts/bootstrap-ansible.sh#L259 change 'ansible-playbook get-ansible-role-requirements.yml' to '/opt/ansible-runtime/bin/ansible-playbook get-ansible-role-requirements.yml' or something to that effect

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/512303

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/512303
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=a27be7f4096a20d3e2549bb31c53849f92c17c97
Submitter: Zuul
Branch: master

commit a27be7f4096a20d3e2549bb31c53849f92c17c97
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Oct 16 13:48:04 2017 +0000

    Do not source openstack-ansible.rc when pulling roles

    Maybe there are variables that are set that should be ignored
    during the bootstrap. This ensures the environment is clean and
    working as expected from a clean ansible.

    Change-Id: I1065f7b8e5d84de02252f050e37ba2f1c523770b
    Closes-Bug: #1707967

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/525699

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/525699
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=fa2ddbb361ea8e96992e1b88aee1105f8b8793e9
Submitter: Zuul
Branch: stable/pike

commit fa2ddbb361ea8e96992e1b88aee1105f8b8793e9
Author: Jean-Philippe Evrard <email address hidden>
Date: Mon Oct 16 13:48:04 2017 +0000

    Do not source openstack-ansible.rc when pulling roles

    Maybe there are variables that are set that should be ignored
    during the bootstrap. This ensures the environment is clean and
    working as expected from a clean ansible.

    Change-Id: I1065f7b8e5d84de02252f050e37ba2f1c523770b
    Closes-Bug: #1707967
    (cherry picked from commit a27be7f4096a20d3e2549bb31c53849f92c17c97)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 16.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 17.0.0.0b2 development milestone.