openstack_user_config: 'compute_hosts' is not optional

[Markus Zoeller (markus_z)]

Description
===========
The 'openstack_user_config.yml.example' file specifies the 'compute_hosts'
key as optional [1], but without specifying at least one compute node, the
setup will fail.

Steps to reproduce
==================
A chronological list of steps which will bring off the
issue you noticed:
* Create a VM with Vagrant with Ubuntu 16.04.02 (geerlinguy/ubuntu1604) box
* Configure the 'openstack_user_config.yml' **without** 'compute_hosts'
* On the deploy node (which is also the 1 controller node) do:
    * $ cd /opt/openstack-ansible/playbooks
    * $ openstack-ansible setup-hosts.yml
    * $ openstack-ansible setup-infrastructure.yml

Expected result
===============
openstack-ansible sets up an OpenStack environment which consists only
of 1 controller node, but without any compute nodes.

Actual result
=============
The setup of the infrastructure fails, because the repo container doesn't
contain the nova-lxd code:

    TASK [repo_build : Create OpenStack-Ansible requirement wheels] *****
    Friday 30 June 2017 06:32:47 +0000 (0:00:00.014) 0:01:42.643 *
    fatal: [controller1_repo_container-f3bb61a2]: FAILED! =>
    [...]
    Command \"git clone -q file:///var/www/repo/openstackgit/nova-lxd
    /tmp/openstack-builder/nova-lxd\" failed with error code 128 in None

Environment
===========
openstack-ansible version: 15.1.2
host os: Ubuntu 16.04.02

Logs & Configs
==============
* openstack_user_config.yml without 'compute_hosts' key:
  http://paste.openstack.org/show/614146/
* TASK: repo_build : Create OpenStack-Ansible requirement wheels
  http://paste.openstack.org/show/614147/

References
==========
[1] https://github.com/openstack/openstack-ansible/blob/1f019e3e8daa09d214b2174068ca3f65eb885511/etc/openstack_deploy/openstack_user_config.yml.example#L423-L423

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/480269

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/480269
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=e3524ec0d2fc2cd9ea8934c3e791079b8c24b768
Submitter: Jenkins
Branch: master

commit e3524ec0d2fc2cd9ea8934c3e791079b8c24b768
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 4 18:09:00 2017 +0100

    Correctly map nova git sources

    For any packages the nova role uses which are
    not proprietary, the repo buid process will
    need to git clone and build them from source.

    In a situation where a nova control plane is
    built, but no compute hosts are assigned, the
    repo build currently fails due to the current
    mapping of these git sources to compute hosts.

    With this patch we ensure that the git sources
    are cloned and the packages built as long as
    there are any nova hosts in the inventory.

    Change-Id: Ief9da2c8c555b51a06af9f7cd6145f9d74c14478
    Closes-Bug: 1701468

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/481909

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/481910

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481910
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=c5f07f907e516c449fd9af6e2f07ad750aa48e07
Submitter: Jenkins
Branch: stable/newton

commit c5f07f907e516c449fd9af6e2f07ad750aa48e07
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 4 18:09:00 2017 +0100

    Correctly map nova git sources

    For any packages the nova role uses which are
    not proprietary, the repo buid process will
    need to git clone and build them from source.

    In a situation where a nova control plane is
    built, but no compute hosts are assigned, the
    repo build currently fails due to the current
    mapping of these git sources to compute hosts.

    With this patch we ensure that the git sources
    are cloned and the packages built as long as
    there are any nova hosts in the inventory.

    Change-Id: Ief9da2c8c555b51a06af9f7cd6145f9d74c14478
    Closes-Bug: 1701468
    (cherry picked from commit e3524ec0d2fc2cd9ea8934c3e791079b8c24b768)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481909
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=6c6be4a745b002877be07d7f43b7dad2569853aa
Submitter: Jenkins
Branch: stable/ocata

commit 6c6be4a745b002877be07d7f43b7dad2569853aa
Author: Jesse Pretorius <email address hidden>
Date: Tue Jul 4 18:09:00 2017 +0100

    Correctly map nova git sources

    For any packages the nova role uses which are
    not proprietary, the repo buid process will
    need to git clone and build them from source.

    In a situation where a nova control plane is
    built, but no compute hosts are assigned, the
    repo build currently fails due to the current
    mapping of these git sources to compute hosts.

    With this patch we ensure that the git sources
    are cloned and the packages built as long as
    there are any nova hosts in the inventory.

    Change-Id: Ief9da2c8c555b51a06af9f7cd6145f9d74c14478
    Closes-Bug: 1701468
    (cherry picked from commit e3524ec0d2fc2cd9ea8934c3e791079b8c24b768)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 16.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 14.2.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 15.1.7 release.