error when running os-nova-install.yml playbook with nova-config tag

[Jirayut Nimsaeng]

It shows an error when I running "openstack-ansible os-nova-install.yml --tags nova-config" as below

TASK [os_nova : Install pip packages] ******************************************
Monday 05 June 2017 13:18:35 +0700 (0:00:00.509) 0:03:13.732 ***********
fatal: [infra1]: FAILED! => {"failed": true, "msg": "The conditional check 'nova_get_venv | failed or nova_get_venv | skipped' failed. The error was: |failed expects a dictionary\n\nThe error appears to have been in '/etc/ansible/roles/os_nova/tasks/nova_compute_kvm_install.yml': line 54, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Install pip packages\n ^ here\n"}
fatal: [infra2]: FAILED! => {"failed": true, "msg": "The conditional check 'nova_get_venv | failed or nova_get_venv | skipped' failed. The error was: |failed expects a dictionary\n\nThe error appears to have been in '/etc/ansible/roles/os_nova/tasks/nova_compute_kvm_install.yml': line 54, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Install pip packages\n ^ here\n"}
fatal: [infra3]: FAILED! => {"failed": true, "msg": "The conditional check 'nova_get_venv | failed or nova_get_venv | skipped' failed. The error was: |failed expects a dictionary\n\nThe error appears to have been in '/etc/ansible/roles/os_nova/tasks/nova_compute_kvm_install.yml': line 54, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Install pip packages\n ^ here\n"}

This error from this file https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/drivers/kvm/nova_compute_kvm_install.yml#L58-L76

and if it happens to pass this. I still find another error on ceph_client that it shouldn't run this role at all.

TASK [ceph_client : Retrieve keyrings for openstack clients from ceph cluster] *
Monday 05 June 2017 14:35:46 +0700 (0:00:02.015) 0:04:08.358 ***********
skipping: [infra2] => (item=({u'component': u'glance_api', u'service': [u'glance-api'], u'package': [u'python-ceph']}, u'glance'))
skipping: [infra3] => (item=({u'component': u'glance_api', u'service': [u'glance-api'], u'package': [u'python-ceph']}, u'glance'))
skipping: [infra1] => (item=({u'component': u'glance_api', u'service': [u'glance-api'], u'package': [u'python-ceph']}, u'glance'))
skipping: [infra2] => (item=({u'component': u'cinder_volume', u'service': [u'cinder-volume', u'cinder-backup'], u'package': [u'ceph-common', u'python-ceph']}, u'cinder'))
skipping: [infra3] => (item=({u'component': u'cinder_volume', u'service': [u'cinder-volume', u'cinder-backup'], u'package': [u'ceph-common', u'python-ceph']}, u'cinder'))
skipping: [infra1] => (item=({u'component': u'cinder_volume', u'service': [u'cinder-volume', u'cinder-backup'], u'package': [u'ceph-common', u'python-ceph']}, u'cinder'))
skipping: [infra2] => (item=({u'component': u'cinder_backup', u'service': [u'cinder-volume', u'cinder-backup'], u'package': [u'ceph-common', u'python-ceph']}, u'cinder-backup'))
skipping: [infra3] => (item=({u'component': u'cinder_backup', u'service': [u'cinder-volume', u'cinder-backup'], u'package': [u'ceph-common', u'python-ceph']}, u'cinder-backup'))
skipping: [infra1] => (item=({u'component': u'cinder_backup', u'service': [u'cinder-volume', u'cinder-backup'], u'package': [u'ceph-common', u'python-ceph']}, u'cinder-backup'))
fatal: [infra3]: FAILED! => {"failed": true, "msg": "'ceph_mon_host' is undefined"}
fatal: [infra2]: FAILED! => {"failed": true, "msg": "'ceph_mon_host' is undefined"}
fatal: [infra1]: FAILED! => {"failed": true, "msg": "'ceph_mon_host' is undefined"}

I think Ansible didn't respect tags in os-nova-install.yml playbook file https://github.com/openstack/openstack-ansible/blob/master/playbooks/os-nova-install.yml#L147-L155

[Jean-Philippe Evrard (jean-philippe-evrard)]

Looks legit, these tasks [1] are marked with both install and config.
[1] https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/drivers/kvm/nova_compute_kvm_install.yml#L58-L76
[2] https://github.com/openstack/openstack-ansible-os_nova/blob/master/tasks/drivers/kvm/nova_compute_kvm.yml#L16-L18

We should really enforce this, now that we can.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/494704

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/494704
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=968e9a93a51df1400d62e53b9d0706a7e6d32765
Submitter: Jenkins
Branch: master

commit 968e9a93a51df1400d62e53b9d0706a7e6d32765
Author: Jimmy McCrory <email address hidden>
Date: Thu Aug 17 14:06:53 2017 -0700

    Correct tag for nova_compute_kvm_install tasks

    These tasks should be tagged with 'nova-install' not 'nova-config'.

    Closes-Bug: 1695846
    Change-Id: I48e5f2adec7b53acc2054841f3f4c0ddad0f2015

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_nova 17.0.0.0b1 development milestone.