placement_database config option help is wrong

Bug #1670419 reported by Matt Riedemann on 2017-03-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Matt Riedemann
Newton
Medium
Matt Riedemann
Ocata
Medium
Matt Riedemann
openstack-ansible
Undecided
Jesse Pretorius

Bug Description

The help on the [placement_database] config options is wrong, it mentions Ocata 14.0.0 but 14.0.0 is actually Newton, Ocata was 15.0.0:

"# The *Placement API Database* is a separate database which is used for the new
# placement-api service. In Ocata release (14.0.0) this database is optional:"

It also has some scary words about configuring it with a separate database so you don't have to deal with data migration issues later to migrate data from the nova_api database to a separate placement database, but the placement_database options are not actually used in code. They will be when this blueprint is complete:

https://blueprints.launchpad.net/nova/+spec/optional-placement-database

Fix proposed to branch: master
Review: https://review.openstack.org/442035

Changed in nova:
assignee: nobody → Matt Riedemann (mriedem)
status: Triaged → In Progress

Reviewed: https://review.openstack.org/442035
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7439e9473617a871c032107ab85b1b623369975f
Submitter: Jenkins
Branch: master

commit 7439e9473617a871c032107ab85b1b623369975f
Author: Matt Riedemann <email address hidden>
Date: Mon Mar 6 20:25:55 2017 -0500

    Remove unused placement_database config options

    The placement_database config options were added in Newton
    but the actual code to use the options was reverted and is
    not used. The help text actually has a typo (Ocata was 15.0.0,
    not 14.0.0) and, more importantly, the help text makes it sound
    like you should really be setting up a separate database for the
    placement service but we don't actually use these options, we use
    the api_database options for all of the placement data models.

    To avoid confusion until this is actually supported, let's just
    remove the options which should have been cleaned up as part of
    39fb302fd9c8fc57d3e4bea1c60a02ad5067163f anyway.

    Change-Id: I31293ac4689630e4113588ab2c6373cf572b8f38
    Closes-Bug: #1670419

Changed in nova:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/442762
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9b695d494444289d82a01547fd56ad8f9a50eab5
Submitter: Jenkins
Branch: stable/ocata

commit 9b695d494444289d82a01547fd56ad8f9a50eab5
Author: Matt Riedemann <email address hidden>
Date: Mon Mar 6 20:25:55 2017 -0500

    Remove unused placement_database config options

    The placement_database config options were added in Newton
    but the actual code to use the options was reverted and is
    not used. The help text actually has a typo (Ocata was 15.0.0,
    not 14.0.0) and, more importantly, the help text makes it sound
    like you should really be setting up a separate database for the
    placement service but we don't actually use these options, we use
    the api_database options for all of the placement data models.

    To avoid confusion until this is actually supported, let's just
    remove the options which should have been cleaned up as part of
    39fb302fd9c8fc57d3e4bea1c60a02ad5067163f anyway.

    Conflicts:
            nova/tests/functional/api/openstack/placement/fixtures.py

    NOTE(mriedem): The conflict is due to not having change
    a598af9de6536d8b66046fa329d9960edc706aed in stable/ocata.

    Change-Id: I31293ac4689630e4113588ab2c6373cf572b8f38
    Closes-Bug: #1670419
    (cherry picked from commit 7439e9473617a871c032107ab85b1b623369975f)

This issue was fixed in the openstack/nova 15.0.1 release.

This issue was fixed in the openstack/nova 16.0.0.0b1 development milestone.

Matt Riedemann (mriedem) wrote :

CERN ran into this when upgrading from newton to ocata and were confused because the placement_database option still existed in the newton code and made it sound like that's what they would want to use when deploying placement, but since the code was all reverted that wouldn't work.

Changed in nova:
importance: Low → Medium

Reviewed: https://review.openstack.org/514685
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=02586e698b005ed10f78dbd1cf35bdef2013fab2
Submitter: Zuul
Branch: stable/newton

commit 02586e698b005ed10f78dbd1cf35bdef2013fab2
Author: Matt Riedemann <email address hidden>
Date: Mon Mar 6 20:25:55 2017 -0500

    Remove unused placement_database config options

    The placement_database config options were added in Newton
    but the actual code to use the options was reverted and is
    not used. The help text actually has a typo (Ocata was 15.0.0,
    not 14.0.0) and, more importantly, the help text makes it sound
    like you should really be setting up a separate database for the
    placement service but we don't actually use these options, we use
    the api_database options for all of the placement data models.

    To avoid confusion until this is actually supported, let's just
    remove the options which should have been cleaned up as part of
    39fb302fd9c8fc57d3e4bea1c60a02ad5067163f anyway.

    Conflicts:
          nova/conf/database.py

    NOTE(mriedem): The conflict was due to change
    I4cd84f1750ed7cf6c595cec6d6f52b79c73c311b not being in Newton.

    Change-Id: I31293ac4689630e4113588ab2c6373cf572b8f38
    Closes-Bug: #1670419
    (cherry picked from commit 7439e9473617a871c032107ab85b1b623369975f)
    (cherry picked from commit 9b695d494444289d82a01547fd56ad8f9a50eab5)

This issue was fixed in the openstack/nova 14.0.9 release.

Fix proposed to branch: master
Review: https://review.openstack.org/541685

Changed in openstack-ansible:
assignee: nobody → Jesse Pretorius (jesse-pretorius)
status: New → In Progress

Reviewed: https://review.openstack.org/541685
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=023c4f27fc22845d25254cd2debaa566c070d0ea
Submitter: Zuul
Branch: master

commit 023c4f27fc22845d25254cd2debaa566c070d0ea
Author: Jesse Pretorius <email address hidden>
Date: Wed Feb 7 11:37:46 2018 +0000

    Remove placement_database related options/code

    The placement_database config options were added in Newton
    but the actual code to use the options was reverted and is
    not used.

    Change-Id: Ifb09747056750893e442ebe0b4124e861a70ae55
    Related-Reviews: I31293ac4689630e4113588ab2c6373cf572b8f38
    Closes-Bug: #1670419

Changed in openstack-ansible:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/541692
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-tests/commit/?id=e33000f1bcfaf0d23149cf5ffd7c88a812f0cd6a
Submitter: Zuul
Branch: master

commit e33000f1bcfaf0d23149cf5ffd7c88a812f0cd6a
Author: Jesse Pretorius <email address hidden>
Date: Wed Feb 7 12:02:09 2018 +0000

    Remove placement_database related options/code

    The placement_database config options were added in Newton
    but the actual code to use the options was reverted and is
    not used.

    Change-Id: Idd2edec3e98dbcd3361cf38434027ad16066ac46
    Depends-On: https://review.openstack.org/541685
    Related-Reviews: I31293ac4689630e4113588ab2c6373cf572b8f38
    Closes-Bug: #1670419

Reviewed: https://review.openstack.org/541691
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=604e8217a9c875889377ea03d1fae154d5f5aa5c
Submitter: Zuul
Branch: master

commit 604e8217a9c875889377ea03d1fae154d5f5aa5c
Author: Jesse Pretorius <email address hidden>
Date: Wed Feb 7 11:57:48 2018 +0000

    Remove placement_database related options/code

    The placement_database config options were added in Newton
    but the actual code to use the options was reverted and is
    not used.

    Change-Id: I97f44c0b52af6c356433cf2c1021e9c175a8710d
    Depends-On: https://review.openstack.org/541685
    Related-Reviews: I31293ac4689630e4113588ab2c6373cf572b8f38
    Closes-Bug: #1670419

This issue was fixed in the openstack/openstack-ansible 17.0.0.0rc1 release candidate.

This issue was fixed in the openstack/openstack-ansible-os_nova 17.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints