M->N upgrade causes container reboot due to bind mounts

[Logan V]

The Mitaka upgrade playbooks set a default_bind_mount_logs: false entry to prevent a reboot of all the containers due to the log bind mount change.

However the containers all reboot anyway because of a change in the bind mount syntax deployed to the lxc config for the other non-log bind mounts.

Example old entry:
lxc.mount.entry = /openstack/lsn-d6045_galera_container-174f0faa var/lib/mysql none bind 0 0

another entry is appended to the lxc config for this container:
lxc.mount.entry = /openstack/lsn-d6045_galera_container-174f0faa var/lib/mysql none bind,create=dir 0 0

So the result is the bind mount is specified twice (once with ",create=dir" and once without) in the container config, and the change also triggers a container restart.

The old entry was managed here:
https://github.com/openstack/openstack-ansible/blob/stable/mitaka/playbooks/galera-install.yml#L36-L37

And the new one is managed here:
https://github.com/openstack/openstack-ansible/blob/master/playbooks/common-tasks/os-lxc-container-setup.yml#L47-L58

[Logan V (loganv)]

Typoed the first line line of the bug report, this is the NEWTON upgrade being performed.

[Logan V (loganv)]

Looks like this affects the following playbooks:

playbooks/os-neutron-install.yml: - "lxc.mount.entry=/lib/modules lib/modules none bind 0 0"
playbooks/os-glance-install.yml: - "lxc.mount.entry=/openstack/{{ container_name }} var/lib/glance/images none bind 0 0"
playbooks/repo-server.yml: - "lxc.mount.entry=/openstack/{{ container_name }} var/www none bind 0 0"
playbooks/galera-install.yml: - "lxc.mount.entry=/openstack/{{ container_name }} var/lib/mysql none bind 0 0"

[Jean-Philippe Evrard (jean-philippe-evrard)]

Adding a regexp to the lineinfile would avoid the duplicate lines, while the serialization here: https://review.openstack.org/#/c/426928/ would avoid the mess of the massive restart.

[Mohammed Naser (mnaser)]

Old release