Varaible for WEBSSO_INITIAL_CHOICE missing

[Ingemar Fällman]

WEBSSO_INITIAL_CHOICE should be set by a variable like horizon_websso_initial_choice that defaults to "credentials" in https://github.com/openstack/openstack-ansible-os_horizon/blob/master/templates/horizon_local_settings.py.j2#L178 and a new default value should be set in https://github.com/openstack/openstack-ansible-os_horizon/blob/master/defaults/main.yml

--- /etc/ansible/roles/os_horizon/templates/horizon_local_settings.py.j2.orig 2017-01-30 13:29:54.368304450 +0100
+++ /etc/ansible/roles/os_horizon/templates/horizon_local_settings.py.j2 2017-01-30 13:30:48.981640641 +0100
@@ -175,7 +175,7 @@
 WEBSSO_ENABLED = True

 # Determines which authentication choice to show as default.
-WEBSSO_INITIAL_CHOICE = "credentials"
+WEBSSO_INITIAL_CHOICE = "{{ horizon_websso_initial_choice }}"

 # The list of authentication mechanisms which include keystone
 # federation protocols and identity provider/federation protocol

--- /etc/ansible/roles/os_horizon/defaults/main.yml.orig 2017-01-30 13:32:07.805795654 +0100
+++ /etc/ansible/roles/os_horizon/defaults/main.yml 2017-01-30 13:34:56.349573132 +0100
@@ -288,3 +288,6 @@

 horizon_keystone_admin_roles:
   - admin
+
+# Set the "credentials" authentication choice to show as default.
+horizon_websso_initial_choice: "credentials"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/468845

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/468845
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_horizon/commit/?id=1283febbb18f994d329ed83738ec7bd20aabd329
Submitter: Jenkins
Branch: master

commit 1283febbb18f994d329ed83738ec7bd20aabd329
Author: Duong Ha-Quang <email address hidden>
Date: Mon May 29 17:22:28 2017 +0700

    Move WEBSSO_INITIAL_CHOICE setting to variable

    Currently, WEBSSO_INITIAL_CHOICE is hard-coded in template, this patchset
    convert WEBSSO_INITIAL_CHOICE setting to variable horizon_websso_initial_choice
    in main.yml

    Change-Id: I7e18ec981f6a575ee81da1429545f8b46a771fb8
    Closes-bug: #1660322

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-os_horizon 16.0.0.0b2 development milestone.