Xtrabackup version regression

[Hugh Saunders]

At some point the OSA default changed from installing xtrabackup from the percona repo to, retrieving a package by url and installing it locally.

The packages in the repo were updated as new versions were released, however the var containing the package url has not been updated.

So a deployment may have the latest version from the repo (2.3.x), then upgrade OSA and end up back at xtrabackup 2.2.x because the new OSA default is to not use the percona repo.

Xtrabackup also causes problems with holland mysql backup tool.

[Jean-Philippe Evrard (jean-philippe-evrard)]

Note: This has to be handled differently for power and amd64.
Patch for amd64 on the way.

[Jean-Philippe Evrard (jean-philippe-evrard)]

While technically we did install the percona repo for xtrabackup in Mitaka [1], we ensured it's uninstalled [2] before installing the fetched version [3].

I'm not sure there is therefore a regression in Newton/master there: in the container we, by default, use the package, because use_percona_upstream is set to false by default (on ubuntu).

However, if a container was upgraded from M to N, I don't think (I didn't check) the upgrade tool removed this repo, and we don't ensure the repo was removed (that is a bug IMO) [4], so we could end up with a mess.

Is that what you encountered?

[1]: https://github.com/openstack/openstack-ansible-galera_server/blob/stable/mitaka/tasks/galera_pre_install.yml#L96

[2]: https://github.com/openstack/openstack-ansible-galera_server/blob/stable/mitaka/tasks/galera_install_apt.yml#L58-L73

[3]: https://github.com/openstack/openstack-ansible-galera_server/blob/stable/mitaka/tasks/galera_install_apt.yml#L75-L77

[4]: https://github.com/openstack/openstack-ansible-galera_server/blob/stable/newton/tasks/galera_install_apt.yml#L92-L99

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/417362

[Jean-Philippe Evrard (jean-philippe-evrard)]

This bugfix is targetting the part [4] explained above.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/417362
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_server/commit/?id=2aa7f1ca8ac399b71bc3d106d9548aafdca2a663
Submitter: Jenkins
Branch: master

commit 2aa7f1ca8ac399b71bc3d106d9548aafdca2a663
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 6 12:08:30 2017 +0000

    Remove percona repo if not used

    If the ``use_percona_upstream`` value is changed from True to False,
    don't remove the existing repository. This is also the source of a bug
    in Mitaka: We were installing the repo by default and installed the
    percona-xtrabackup tool with a deb file. If another playbook/role
    installed percona-xtrabackup, it would override (and probably upgrade)
    the deb installed version, which is undesired.

    Change-Id: I2ccc2904d0d4244dc0792411b49763cc3f7e2e22
    Closes-Bug: 1653947
    Signed-off-by: Jean-Philippe Evrard <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/417832

[Hugh Saunders (hughsaunders)]

Hi JP, it turned out that my problem was related to an additional downstream playbook updating the xtrabackup version in the galera playbook :( Sorry for the false alarm in OSA. However bumping the xtrabackup version is no bad thing, thanks for that.

[Jean-Philippe Evrard (jean-philippe-evrard)]

Here is a link to the version bump stated above (happening in master branch, not newton): http://review.openstack.org/#/c/416546/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/417832
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_server/commit/?id=4a2ad199481c4fa9b0fbc701b272f33632a728fd
Submitter: Jenkins
Branch: stable/newton

commit 4a2ad199481c4fa9b0fbc701b272f33632a728fd
Author: Jean-Philippe Evrard <email address hidden>
Date: Fri Jan 6 12:08:30 2017 +0000

    Remove percona repo if not used

    If the ``use_percona_upstream`` value is changed from True to False,
    don't remove the existing repository. This is also the source of a bug
    in Mitaka: We were installing the repo by default and installed the
    percona-xtrabackup tool with a deb file. If another playbook/role
    installed percona-xtrabackup, it would override (and probably upgrade)
    the deb installed version, which is undesired.

    Combined backport of:
    - https://review.openstack.org/#/c/417362/
    - https://review.openstack.org/#/c/417776/
    - https://review.openstack.org/#/c/416234/

    Change-Id: Ibb2f01e6b61774a2517feb5baf4a5452b7f68a84
    Closes-Bug: 1653947
    Signed-off-by: Jean-Philippe Evrard <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-galera_server 15.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-galera_server 14.0.7 release.