OpenStack-Ansible

Role os_nova uses wrong ansible variable for ironic service user

Bug #1647253 reported by Uros Orozel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Jimmy McCrory

Bug Description

Role os_nova uses wrong ansible variable for ironic service user.

role os_ironic is using "ironic_service_user_name" for defining service user name variable while template in role os_nova addresses "ironic_service_name" which is incorrect and may result in error if using non standard user id for ironic.

https://github.com/openstack/openstack-ansible-os_nova/blob/2b872538862b03b0e96b3024601454de38ca457c/templates/nova.conf.j2#L264

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/406689

Changed in openstack-ansible:
assignee: nobody → Uros Orozel (urosorozel)
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in openstack-ansible:
assignee: Uros Orozel (urosorozel) → Jesse Pretorius (jesse-pretorius)
Jesse Pretorius (jesse-pretorius)
Changed in openstack-ansible:
assignee: Jesse Pretorius (jesse-pretorius) → Uros Orozel (urosorozel)
OpenStack Infra (hudson-openstack)
Changed in openstack-ansible:
assignee: Uros Orozel (urosorozel) → Jimmy McCrory (jimmy-mccrory)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_nova (master)

Reviewed: https://review.openstack.org/406689
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=5807424a8fb2143cae638166503858cbb4bbaf8f
Submitter: Jenkins
Branch: master

commit 5807424a8fb2143cae638166503858cbb4bbaf8f
Author: Uros Orozel <email address hidden>
Date: Mon Dec 5 14:52:59 2016 +1100

    Fixes incorrect variable used for ironic user name

    role os_ironic is using "ironic_service_user_name" for defining service
    user name variable while template in role os_nova addresses
    "ironic_service_name" which is incorrect and may result in error if
    using non standard user id for ironic.

    Change-Id: I1a7751bcd202363d0893940c072291f58d548d21
    Closes-Bug: 1647253

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_nova (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/424322

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_nova (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/424325

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_nova (stable/newton)

Reviewed: https://review.openstack.org/424325
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=2de4a70dc3e87255d6f664fc47bda04a786c0be0
Submitter: Jenkins
Branch: stable/newton

commit 2de4a70dc3e87255d6f664fc47bda04a786c0be0
Author: Charles Farquhar <email address hidden>
Date: Mon Jan 23 14:29:07 2017 -0600

    Fix incorrect variable used for ironic user name

    role os_ironic is using "ironic_service_user_name" for defining service
    user name variable while template in role os_nova addresses
    "ironic_service_name" which is incorrect and may result in error if
    using non standard user id for ironic.

    Change-Id: I7b285a650e0b757a45040ac6898c08daed99e2fe
    Closes-Bug: 1647253

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_nova 15.0.0.0b3

This issue was fixed in the openstack/openstack-ansible-os_nova 15.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_nova (stable/mitaka)

Reviewed: https://review.openstack.org/424322
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_nova/commit/?id=9f320c0de991d39f52ffa1fa030a6a86b11cd12c
Submitter: Jenkins
Branch: stable/mitaka

commit 9f320c0de991d39f52ffa1fa030a6a86b11cd12c
Author: Charles Farquhar <email address hidden>
Date: Mon Jan 23 14:25:14 2017 -0600

    Fix incorrect variable used for ironic user name

    role os_ironic is using "ironic_service_user_name" for defining service
    user name variable while template in role os_nova addresses
    "ironic_service_name" which is incorrect and may result in error if
    using non standard user id for ironic.

    Change-Id: I75b8e4f973ded9a76565fe764cb9923417ad5ac4
    Closes-Bug: 1647253

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/436740

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/437143

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/437144

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/436740
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=3bdf5aabbbef0e2fd62eafd6beb74a884cfc05b0
Submitter: Jenkins
Branch: master

commit 3bdf5aabbbef0e2fd62eafd6beb74a884cfc05b0
Author: Michael Davies <email address hidden>
Date: Wed Feb 22 13:52:45 2017 +1030

    Add in ironic_service_user_name group_vars/all.yml

    The os_nova role is referring to the ironic_service_user_name variable
    but it is not defined anywhere. This patch adds it back into the
    default set of variables.

    Change-Id: I4b9f49db9b101be84d4792fb2d409c489161c953
    Closes-Bug: #1647253

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/ocata)

Reviewed: https://review.openstack.org/437143
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=a84de56553bdcfab5859d863753d115f63eb7743
Submitter: Jenkins
Branch: stable/ocata

commit a84de56553bdcfab5859d863753d115f63eb7743
Author: Michael Davies <email address hidden>
Date: Wed Feb 22 13:52:45 2017 +1030

    Add in ironic_service_user_name group_vars/all.yml

    The os_nova role is referring to the ironic_service_user_name variable
    but it is not defined anywhere. This patch adds it back into the
    default set of variables.

    Change-Id: I4b9f49db9b101be84d4792fb2d409c489161c953
    Closes-Bug: #1647253

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/newton)

Reviewed: https://review.openstack.org/437144
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=da4f8cdc9102dc6d1692bdcea5b41f02d2aea05a
Submitter: Jenkins
Branch: stable/newton

commit da4f8cdc9102dc6d1692bdcea5b41f02d2aea05a
Author: Michael Davies <email address hidden>
Date: Wed Feb 22 13:52:45 2017 +1030

    Add in ironic_service_user_name group_vars/all.yml

    The os_nova role is referring to the ironic_service_user_name variable
    but it is not defined anywhere. This patch adds it back into the
    default set of variables.

    Change-Id: I4b9f49db9b101be84d4792fb2d409c489161c953
    Closes-Bug: #1647253

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_nova 13.3.14

This issue was fixed in the openstack/openstack-ansible-os_nova 13.3.14 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_nova 14.0.8

This issue was fixed in the openstack/openstack-ansible-os_nova 14.0.8 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 14.1.0

This issue was fixed in the openstack/openstack-ansible 14.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 15.0.0.0rc2

This issue was fixed in the openstack/openstack-ansible 15.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 16.0.0.0b1

This issue was fixed in the openstack/openstack-ansible 16.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.