ceph_apt_pin_packages default value is incorrect

[Miguel Alejandro Cantu]

ceph_apt_pin_packages references "InkTank" as the originator of the packages.
According to the the apt_preferences man page:
"Origin:
    this line names the originator of the packages in the directory tree of the Release file. Most commonly, this is Debian. Specifying this origin in the APT preferences file would require the line:
Pin: release o=Debian"

I think it would be best to set this value to "origin download.ceph.com" instead of "release o=Inktank". I don't see Inktank referenced in the Release files:

http://download.ceph.com/debian-hammer/dists/trusty/
http://download.ceph.com/debian-infernalis/dists/trusty/
http://download.ceph.com/debian-jewel/dists/trusty/
etc..

I could mis-understanding the way apt_preferences work, so I apologize if this is an incorrect understanding.

[Logan V (loganv)]

$ curl http://download.ceph.com/debian-jewel/dists/trusty/Release | grep Origin
Origin: RedHat

[Jean-Philippe Evrard (jean-philippe-evrard)]

FYI, it's happening in templates/ceph_pin.pref.j2

[Jean-Philippe Evrard (jean-philippe-evrard)]

Also ceph_apt_pinned_packages maybe worth a change.

[Jean-Philippe Evrard (jean-philippe-evrard)]

See conversation here: http://eavesdrop.openstack.org/irclogs/%23openstack-ansible/%23openstack-ansible.2016-12-06.log.html#t2016-12-06T16:28:03

[Dale Dude (daledude)]

This caused me an issue while upgrading from mitaka to newton. All my nodes were updated to ceph client 10 but I require ceph client 9 due to backward incompatibilities.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/416602

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/416602
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-ceph_client/commit/?id=5aea478fc34c0d271fd3d3871101de1fde6838cf
Submitter: Jenkins
Branch: master

commit 5aea478fc34c0d271fd3d3871101de1fde6838cf
Author: Major Hayden <email address hidden>
Date: Wed Jan 4 10:03:50 2017 -0600

    Set correct release for ceph pin

    This patch sets the correct release name for Ceph packages. It was
    originally `Inktank` but it has now changed to `RedHat`.

    The `ceph_pin_pref.j2` file was removed since it isn't used by any
    of the tasks in the role.

    Closes-Bug: 1646855
    Change-Id: If45055cdcaebbc47e6091bac84adf8bec00f8bec

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/416984

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/416984
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-ceph_client/commit/?id=928a2f73d3f4a1b0f07899ffdc41dc59323d0f08
Submitter: Jenkins
Branch: stable/newton

commit 928a2f73d3f4a1b0f07899ffdc41dc59323d0f08
Author: Major Hayden <email address hidden>
Date: Wed Jan 4 10:03:50 2017 -0600

    Set correct release for ceph pin

    This patch sets the correct release name for Ceph packages. It was
    originally `Inktank` but it has now changed to `RedHat`.

    The `ceph_pin_pref.j2` file was removed since it isn't used by any
    of the tasks in the role.

    Closes-Bug: 1646855
    Change-Id: If45055cdcaebbc47e6091bac84adf8bec00f8bec
    (cherry picked from commit 5aea478fc34c0d271fd3d3871101de1fde6838cf)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-ceph_client 15.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible-ceph_client 14.0.7 release.