[DOCS] 'preflight checks' incomplete info

[Alexandra Settle]

This section assumes that users know what preflight checks are and how to run them.
Should we assume that? Probably not.
I recommend we provide more instructions or a reference to more information.

The language has had a minor update here: https://review.openstack.org/#/c/403646/1/doc/source/upgrade-guide/manual-upgrade.rst

But a few things still need to be addressed:
- “starting with the new version”: starting what with the new version? (I revised to say 'upgraded version to clarify, but this still applies... is this correct?)
- “everything is fine”: what do we mean by everything and fine? (I revised to say 'stable', but we should find a way to appropriately define this)
- “the upgrade should stop”: should makes this is ambiguous. Does the upgrade stop? Does the user
need to stop it?

[Jean-Philippe Evrard (jean-philippe-evrard)]

I see https://review.openstack.org/#/c/403646/ is still open, why won't we discuss this there?

[Jean-Philippe Evrard (jean-philippe-evrard)]

If this bug is about clarification, maybe we should have more reviewers on the commit mentioned above.

But yes, this can be unclear and needs to be clarified.

Could you, in your review, also mention this bug? Ty.

[Alexandra Settle (alexandra-settle)]

JP - I can mention the bug in my review, for sure.

But the editorial patch that is currently up is simply that, it is edits. This bug is in reference to a new section.

I would not like to merge the two if possible.

[Jean-Philippe Evrard (jean-philippe-evrard)]

Please find our bug triage discussion here: http://eavesdrop.openstack.org/irclogs/%23openstack-ansible/%23openstack-ansible.2016-11-29.log.html#t2016-11-29T16:19:59

[Jonathan Rosser (jrosser)]

This still looks like assumed knowledge https://opendev.org/openstack/openstack-ansible/src/branch/master/doc/source/admin/upgrades/major-upgrades.rst#preflight-checks