Too many failed_when: false

[Jean-Philippe Evrard]

In our playbooks and role, we have many occurrences of failed_when: false, which is a terrible practice.

Only a few of them are really valid, the others are there for convenience, at the risk of breaking things silently.

I'd rather have these fixed by using the proper argument in the modules, writing new modules, or introducing tasks to check/verify state.

This is part, imo, of the "improve testing" of openstack-ansible.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/433860

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/433860
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-galera_client/commit/?id=22b7d9c761be7ec677351f519ff33b27e17ad64f
Submitter: Jenkins
Branch: master

commit 22b7d9c761be7ec677351f519ff33b27e17ad64f
Author: Jimmy McCrory <email address hidden>
Date: Tue Feb 14 10:57:09 2017 -0800

    Replace grep and which commands with find module

    For improved idempotence within the role, replace the use of `grep` and
    `which` through the 'command' module with the 'find' module.
    changed_when and failed_when statements around these tasks can be
    removed.

    Partial-Bug: 1640134
    Partial-Bug: 1640144
    Change-Id: Iebbcd52f673dba657117ac21ef1fa809bf344521